From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B3ACC83035 for ; Tue, 1 Dec 2020 19:26:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EAE3A2151B for ; Tue, 1 Dec 2020 19:26:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ye9t5z4a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392460AbgLATZj (ORCPT ); Tue, 1 Dec 2020 14:25:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392456AbgLATZh (ORCPT ); Tue, 1 Dec 2020 14:25:37 -0500 Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com [IPv6:2607:f8b0:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2150EC0613D6 for ; Tue, 1 Dec 2020 11:25:10 -0800 (PST) Received: by mail-ot1-x344.google.com with SMTP id z23so2762034oti.13 for ; Tue, 01 Dec 2020 11:25:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SPn0F830zPUmEtXrcmbvv0FgpwCM9EIyGtY9pOM0IAQ=; b=ye9t5z4aMn7GwzSPWdrUXPUMc80qSQuyndkXuIcGm2CLfVBcqeMnNX4Rb5z25r3spO 3dxmC2AtDhSVt4JHT96H17KwWd5Wv2LsQVqzncVSl73bE1q7RWin3fvAk1fKxSUVVd1v 2ZgfYQRdhaMCkeI3qU09XWEDrGLXGbVIwlaSM5PSAbLrqAJRSXtIuEZxrkTfwuwUI4Eo LJxaBln4KY0rq+npZR5folnzOAEqQQ9dl4HwC1vsbrmJMcLZrRUZYZacGIJjR7S9nxlk A9UbX9FryyvJwBUgQcIbyRf+7xeQQDh5XPn5sR+qUBRZzwKcSwJH4sPG+VqyduAYKsSj wt0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SPn0F830zPUmEtXrcmbvv0FgpwCM9EIyGtY9pOM0IAQ=; b=EJ2RAn284dDQ9un9+Bs28CZ9HsL7phEBGn177uPTpMOATtFX5Wxzj+V0Kb8QWfe1FL PPqU9Hr2qKoM7Zf2K4+JUS6XP7t4u3vmjXA9UQJ9Rib9qFthDlvePF4nfB1fAdDYJZBa f80TvBtMgCpzsrPqpL8wr8Gnm/7Ek3gnTWQiH9EUrIjRxAQrg9DPTUIV04cSvnyI3rJJ v4qCEhELhsQ3UFr6l6biMjJwTrbAM4pukRLB3SO6D0MDw7kKVgt6rvdMacAAxWrgb/w1 kzDoYNi3TrJuSEvhV1t8td70xmYsrem047vqLh522RABPLtgi4fJQeUd75ccjVN+urTf ZrsA== X-Gm-Message-State: AOAM530bOSaEFB7/3KntBPNWVa8+IdwTSZEdXY2DuTlCPHrhqY4/LNAk mdrjDfn35bz0y2td8lr8Xvtddd5+tikm/Q== X-Google-Smtp-Source: ABdhPJz/bHut46tHZb4PgHRmltl+p9cXraMKQLsDXtH/yFPkd9hkFzYY5uiEd3tq6g0CQlcCcgFy/Q== X-Received: by 2002:a9d:4b82:: with SMTP id k2mr2910223otf.238.1606850709524; Tue, 01 Dec 2020 11:25:09 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id n3sm107544oif.42.2020.12.01.11.25.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Dec 2020 11:25:08 -0800 (PST) Date: Tue, 1 Dec 2020 13:25:07 -0600 From: Bjorn Andersson To: Srinivas Kandagatla Cc: linux-arm-msm@vger.kernel.org, agross@kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] arm64: dts: qcom: sm8250: add apr and its services Message-ID: References: <20201201153706.13450-1-srinivas.kandagatla@linaro.org> <20201201153706.13450-2-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201201153706.13450-2-srinivas.kandagatla@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue 01 Dec 09:37 CST 2020, Srinivas Kandagatla wrote: > Add apr node and its associated services required for audio on RB5. > > Signed-off-by: Srinivas Kandagatla > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 56 ++++++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index 65acd1f381eb..3b4e98b13d36 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -11,6 +11,8 @@ > #include > #include > #include > +#include > +#include Please move this line one step down to maintain the alphabetical sort order. Thanks, Bjorn > #include > #include > > @@ -2620,6 +2622,60 @@ > label = "lpass"; > qcom,remote-pid = <2>; > > + apr { > + compatible = "qcom,apr-v2"; > + qcom,glink-channels = "apr_audio_svc"; > + qcom,apr-domain = ; > + #address-cells = <1>; > + #size-cells = <0>; > + > + apr-service@3 { > + reg = ; > + compatible = "qcom,q6core"; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > + }; > + > + q6afe: apr-service@4 { > + compatible = "qcom,q6afe"; > + reg = ; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > + q6afedai: dais { > + compatible = "qcom,q6afe-dais"; > + #address-cells = <1>; > + #size-cells = <0>; > + #sound-dai-cells = <1>; > + }; > + > + q6afecc: cc { > + compatible = "qcom,q6afe-clocks"; > + #clock-cells = <2>; > + }; > + }; > + > + q6asm: apr-service@7 { > + compatible = "qcom,q6asm"; > + reg = ; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > + q6asmdai: dais { > + compatible = "qcom,q6asm-dais"; > + #address-cells = <1>; > + #size-cells = <0>; > + #sound-dai-cells = <1>; > + iommus = <&apps_smmu 0x1801 0x0>; > + }; > + }; > + > + q6adm: apr-service@8 { > + compatible = "qcom,q6adm"; > + reg = ; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > + q6routing: routing { > + compatible = "qcom,q6adm-routing"; > + #sound-dai-cells = <0>; > + }; > + }; > + }; > + > fastrpc { > compatible = "qcom,fastrpc"; > qcom,glink-channels = "fastrpcglink-apps-dsp"; > -- > 2.21.0 >