From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88149C64E8A for ; Wed, 2 Dec 2020 01:07:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 383B221D7E for ; Wed, 2 Dec 2020 01:07:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727691AbgLBBH2 (ORCPT ); Tue, 1 Dec 2020 20:07:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726556AbgLBBH2 (ORCPT ); Tue, 1 Dec 2020 20:07:28 -0500 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F792C0613CF for ; Tue, 1 Dec 2020 17:06:48 -0800 (PST) Received: by mail-ot1-x343.google.com with SMTP id y24so171866otk.3 for ; Tue, 01 Dec 2020 17:06:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TzeqoxtSCwOZivYVrn0z0SfSqZzaISmAjmKpXvYn4l8=; b=Cq+cR4c3OVPQaxrFJOVz30dXDnWjBJhnqGAs7L4dBRSGcXSq1EGarExWt50WSDI+jU wERxtHTA1hQ1kfv+jxVNjegv7iBnwOOgEtK4Utc/9KOPLX0e/7Cl0OISHVFMTmSiKlO9 X5e5kvkstbdL6D7TtAXRuTh8EMFeKWr2adcrpUf/YILoB3Aw8JrPQbS+x3Mld6M/8k9h /4sxuqAmsdt989NxClZRE2Nvh3iRmZcCl5iNBMiTrGSb4IQiDbqhBcxyvFvNE+ecLrWZ FQl2EVg2FvzdPMsvQb6U25FTNMeEQy1UhbS9FmNVReC/sZEr95iO34DYQPSPrgo1FLR8 ahww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TzeqoxtSCwOZivYVrn0z0SfSqZzaISmAjmKpXvYn4l8=; b=X8x6jRA7AI+g7L6Gv6rUNCRRmV/SePU5+S8AS1OZwBa4Fasd1z5Stfx/4vtRIkSNhm BQdkIpjG+3X2c0FGgBFHY/VoPkXvYizssTN4WYY3nbkbvImpbA3qCxIGgA6ZjXeFcuRt NG6UZcb1Kg4budfonIocRgc3m7TE63tQw/nQ1EQn2vXvCjJhO9s0YtYup3MskvZJDuEt cA6NKcPGa0CzKIARbx4sLvjqmLx5Zv0Q0KQQEmiGoH+Iw3oj4UP/dkYy0RlQx4wENkfD k8mFLjTziCc/I/1kLEBi7e6TwyIwaxnZXnRD48WNbCYsXy2np2E5bkY6yzd+mbyCTOOp cLcw== X-Gm-Message-State: AOAM531zqtSlslZNuwQdX7C9ReYHO+nSSqloab/RdDiEp4j8KkDwoX82 zLTQ8Natx1106b7o6bG3yi0Y7w== X-Google-Smtp-Source: ABdhPJzW0j1aFxBws0ERK/8CeaFHALeC03HBtEzgnq+tJMwDS0p6UG67m1ITDLHOt9ZWR9XKJq46RQ== X-Received: by 2002:a9d:323:: with SMTP id 32mr136962otv.309.1606871207574; Tue, 01 Dec 2020 17:06:47 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id w70sm17223oiw.29.2020.12.01.17.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Dec 2020 17:06:46 -0800 (PST) Date: Tue, 1 Dec 2020 19:06:45 -0600 From: Bjorn Andersson To: Vinod Koul Cc: linux-arm-msm@vger.kernel.org, Andy Gross , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: db845c: Enable gpi_dma0 node Message-ID: References: <20201201042520.2116271-1-vkoul@kernel.org> <20201201042520.2116271-2-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201201042520.2116271-2-vkoul@kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon 30 Nov 22:25 CST 2020, Vinod Koul wrote: > gpi_dma0 can be used for spi and i2c transfers on db845c, so enable it > > Signed-off-by: Vinod Koul > --- > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > index 7cc236575ee2..0653468f26ce 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > @@ -418,6 +418,10 @@ &gcc { > ; > }; > > +&gpi_dma0 { > + status = "okay"; > +}; > + But you're only enabling the gpi, you don't have anything wired to it, so why enable it? I took a look downstream and they have all the i2c and spi nodes with their dmas filled out - and the two gpis enabled at all times (sdm845.dtsi). Can/should we do the same? Regards, Bjorn > &gpu { > zap-shader { > memory-region = <&gpu_mem>; > -- > 2.26.2 >