From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B047CC4167B for ; Thu, 3 Dec 2020 23:55:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6397F22211 for ; Thu, 3 Dec 2020 23:55:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731294AbgLCXzf (ORCPT ); Thu, 3 Dec 2020 18:55:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727175AbgLCXze (ORCPT ); Thu, 3 Dec 2020 18:55:34 -0500 Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB42FC061A51 for ; Thu, 3 Dec 2020 15:54:48 -0800 (PST) Received: by mail-ot1-x341.google.com with SMTP id f12so3532132oto.10 for ; Thu, 03 Dec 2020 15:54:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=O0t18+kPcHS+KN1VyVdHDaXf4t7nULQ3xrxZwQbCCzw=; b=kQ4vnpRQO4qOyQ5wpOc+IfiCZYJS58VHt9zAK7ukLD6MmJ0l2d9eVcVuAbnzgYEeez BpGxRkZAD0XXo6ZdlSJ8vQgqJIrztyFW3HDfe2FY2xuDnDBpgJ0KeUl2u855Bkc/5xKF tAmbaJVscN+USftunMuHx5T0Qqa7r2nCmEx1Gwy6Z7ws4Bei/Fp7Na5d/d0jAQ5Fv28X o0bpD2W4OcC1Rs/i7zAQfoFsLbb08HNAHnloTgvMKm3aE95VThpVxHHavWKROk+VeFyR OlagAMOCSsFDNsQQz4FLFZtfY+Oj5z3cYkX6Qa5qVfBImmgbfOQ7U/rMJyXAUwN1TEPk yVhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=O0t18+kPcHS+KN1VyVdHDaXf4t7nULQ3xrxZwQbCCzw=; b=m5D52a4sLCiW6rcnz9SUZLf5wCztoUVT68eFrvyJgpuCwG5ZeZHV+HCuxG6nQUflea 2ZcdxaXM5H9BBlsosu0YGyLOQX/cJGoKAXvecI9dt6nkCY7v/BEu64ZvPj3E6lAumV2l vlfX/UMVquWOJwNkHl/tnoQSKsNDINx0yXnbq/AOagFYrE4m6tT0CyrNwLL6oZfsdL4z wSug7WYDF78SMJK5TQSRw7M4ErD/UlTx5GlbQe5ztB62zc7JEivU4hEf6+rZj+FeDjxd rs6ZGnachS/5xh4N7FusHmPIX5yFvZ/SCYp7wONe1baDXbLVvFoeoDoamTJT73I3z13h HrWg== X-Gm-Message-State: AOAM532kVdoSpgXd98TJw2/IW4gLq18Z8XnaqO06klU/UrnOLVnBywVw kQmlC7QpjDcGmCD8ZEVmLyvQRQ== X-Google-Smtp-Source: ABdhPJwtqaM1Z35yqMak8X3fUccNxSyftaVhs/xTEEveV1TfKz8NGOGTNdfb7tHwRqfEjYrirmYx3w== X-Received: by 2002:a05:6830:2093:: with SMTP id y19mr1430276otq.219.1607039688168; Thu, 03 Dec 2020 15:54:48 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id e19sm258810oou.42.2020.12.03.15.54.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 15:54:47 -0800 (PST) Date: Thu, 3 Dec 2020 17:54:45 -0600 From: Bjorn Andersson To: Vinod Koul Cc: Linus Walleij , linux-arm-msm@vger.kernel.org, Raghavendra Rao Ananta , Andy Gross , Rob Herring , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jeevan Shriram Subject: Re: [PATCH 2/2] pinctrl: qcom: Add SM8350 pinctrl driver Message-ID: References: <20201203070900.2651127-1-vkoul@kernel.org> <20201203070900.2651127-2-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201203070900.2651127-2-vkoul@kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu 03 Dec 01:09 CST 2020, Vinod Koul wrote: > diff --git a/drivers/pinctrl/qcom/pinctrl-sm8350.c b/drivers/pinctrl/qcom/pinctrl-sm8350.c [..] > +static const int sm8350_reserved_gpios[] = { > + 52, 53, 54, 55, 56, 57, 58, 59, -1 > +}; Reserving these gpios here instead of in the DT means that there can never be a platform configuration using these. Is there a good reason for this? Or should we just mark them reserved in DT? Regards, Bjorn > + > +static const struct msm_pinctrl_soc_data sm8350_pinctrl = { > + .pins = sm8350_pins, > + .npins = ARRAY_SIZE(sm8350_pins), > + .functions = sm8350_functions, > + .nfunctions = ARRAY_SIZE(sm8350_functions), > + .groups = sm8350_groups, > + .ngroups = ARRAY_SIZE(sm8350_groups), > + .reserved_gpios = sm8350_reserved_gpios, > + .ngpios = 204, > +}; > + > +static int sm8350_pinctrl_probe(struct platform_device *pdev) > +{ > + return msm_pinctrl_probe(pdev, &sm8350_pinctrl); > +} > + > +static const struct of_device_id sm8350_pinctrl_of_match[] = { > + { .compatible = "qcom,sm8350-pinctrl", }, > + { }, > +}; > + > +static struct platform_driver sm8350_pinctrl_driver = { > + .driver = { > + .name = "sm8350-pinctrl", > + .of_match_table = sm8350_pinctrl_of_match, > + }, > + .probe = sm8350_pinctrl_probe, > + .remove = msm_pinctrl_remove, > +}; > + > +static int __init sm8350_pinctrl_init(void) > +{ > + return platform_driver_register(&sm8350_pinctrl_driver); > +} > +arch_initcall(sm8350_pinctrl_init); > + > +static void __exit sm8350_pinctrl_exit(void) > +{ > + platform_driver_unregister(&sm8350_pinctrl_driver); > +} > +module_exit(sm8350_pinctrl_exit); > + > +MODULE_DESCRIPTION("QTI sm8350 pinctrl driver"); > +MODULE_LICENSE("GPL v2"); > +MODULE_DEVICE_TABLE(of, sm8350_pinctrl_of_match); > -- > 2.26.2 >