From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA653C433FE for ; Wed, 9 Dec 2020 12:02:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8AED23B79 for ; Wed, 9 Dec 2020 12:02:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731097AbgLIMBz (ORCPT ); Wed, 9 Dec 2020 07:01:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:56494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731046AbgLIMBq (ORCPT ); Wed, 9 Dec 2020 07:01:46 -0500 Date: Wed, 9 Dec 2020 13:02:22 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1607515266; bh=SxUcCOk6EABV426Vv5fQLgQpTaXc7Q0vhKOIeg7/cVo=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=pfoslDmSETsL8y+eBGotK+t74xmX2D24QCVPYznbkYgpPxigNCNOCmmJT99TFtnca d/etSQ5pXonj6iqBTNuW8/7KeTrBKMlGvO5DbJB7ILvjO4YICzj8FsEro+A5z3JqDQ hJgrqwOjWLaCQNBPihkh59k2KfeXL+2n9uIcnImM= From: 'Greg Kroah-Hartman' To: Info Cc: 'Rob Herring' , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH] Staging: silabs si4455 serial driver Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Dec 09, 2020 at 12:09:58PM +0100, Info wrote: > This is a serial port driver for > Silicon Labs Si4455 Sub-GHz transciver. > > Signed-off-by: József Horváth Note, your From: line does not match this line, so I can't take this. But: > --- > .../bindings/staging/serial/silabs,si4455.txt | 39 + staging drivers need to be self-contained, so this should be here. It needs to be reviewed by the DT maintainers when moving out of staging. > index 000000000000..aee5c7613b31 > --- /dev/null > +++ b/drivers/staging/si4455/TODO > @@ -0,0 +1,3 @@ > +TODO: > + - add variable packet length support > + - add firmware patching support in case of Si4455-C2A Why are these a requirement to get it out of staging? Why go into staging at all? Why not go into the 'real' part of the kernel directly? What is keeping that from happening today? These look like new features that you can add later, and shouldn't be a requirement for acceptance into the normal part of the kernel for this driver. Why have you not tried doing that first? thanks, greg k-h