From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7D46C433EF for ; Wed, 2 Feb 2022 12:41:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344183AbiBBMlg convert rfc822-to-8bit (ORCPT ); Wed, 2 Feb 2022 07:41:36 -0500 Received: from aposti.net ([89.234.176.197]:46104 "EHLO aposti.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240128AbiBBMlf (ORCPT ); Wed, 2 Feb 2022 07:41:35 -0500 Date: Wed, 02 Feb 2022 12:41:21 +0000 From: Paul Cercueil Subject: Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output To: "H. Nikolaus Schaller" Cc: Rob Herring , Mark Rutland , Thomas Bogendoerfer , Geert Uytterhoeven , Kees Cook , "Eric W. Biederman" , Miquel Raynal , David Airlie , Daniel Vetter , Neil Armstrong , Robert Foss , Laurent Pinchart , Jernej Skrabec , Harry Wentland , Sam Ravnborg , Maxime Ripard , Hans Verkuil , Liam Girdwood , Mark Brown , Paul Boddie , Andrzej Hajda , Kieran Bingham , devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org, Jonas Karlman , dri-devel@lists.freedesktop.org, Ezequiel Garcia Message-Id: In-Reply-To: <78F51BD7-112A-458D-8FCE-6A67572A182B@goldelico.com> References: <6a7b188769a7ad477bf8cb71e1b9bc086b92388d.1643632014.git.hns@goldelico.com> <1F27171F-DFCA-4707-8F50-D1A343F6D78E@goldelico.com> <37CB6D86-4295-4281-BF3E-3E4B40E74196@goldelico.com> <5ZFO6R.M6Z7S3EBA1YC1@crapouillou.net> <78F51BD7-112A-458D-8FCE-6A67572A182B@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Le mer., févr. 2 2022 at 13:33:15 +0100, H. Nikolaus Schaller a écrit : > > >> Am 02.02.2022 um 13:28 schrieb Paul Cercueil : >> >> >> >> Le mer., févr. 2 2022 at 13:17:14 +0100, H. Nikolaus Schaller >> a écrit : >>> Hi Paul, >>>> Am 02.02.2022 um 13:06 schrieb Paul Cercueil >>>> : >>>> Hi Nikolaus, >>>>>>> @@ -446,6 +454,9 @@ static int >>>>>>> ingenic_drm_plane_atomic_check(struct drm_plane *plane, >>>>>>> if (!crtc) >>>>>>> return 0; >>>>>>> + if (plane == &priv->f0) >>>>>>> + return -EINVAL; >>>>>> This will break JZ4725B -> JZ4770 SoCs, the f0 plane is >>>>>> perfectly usable there. >>>>> Hm. I think it was your request/proposal to add this [1]? >>>> Because otherwise with your current patchset the f0 plane does >>>> not work *on JZ4780*. >>> Not that I am eager to fix that, but... >>> maybe it could be better to fix than having the check and -EINVAL >>> depend on SoC compatible string >>> (or some new flag in soc_info. plane_f0_not_working)? >> >> Totally agree! A proper fix would be much better. A >> "plane_f0_not_working" in the meantime is OK with me. > > Ok, then I'll prepare a v13 with plane_f0_not_working. > >> >> Note that there are other things not working with your current >> implementation, for instance you cannot set the X/Y start position >> of the f1 plane, which means it's only really usable for fullscreen >> desktop/windows. > > Is setting x/y possible for the other SoC? Yes. They support different x/y positions, sizes, and pixel format for both f0, f1 and IPU planes. -Paul >> >>>> It does work on older SoCs. >>>>> What I have forgotten is why the f0 plane should not be usable >>>>> for jz4780. >>>> We return an error here to prevent userspace from using the f0 >>>> plane until it's effectively working on the JZ4780. >>> Well, what would be not working with that plane if user-space >>> would try to use it? >> >> From what I remember, it wouldn't show anything on screen, and >> after that trying to use the f1 plane wouldn't work either. > > Ok. That may become a big project to fix. So let's do step 1 first. > > BR and thanks, > NIkolaus >