From: Lee Jones <lee@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Martin Kurbanov <mmkurbanov@sberdevices.ru>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@sberdevices.ru
Subject: Re: [PATCH v2 2/2] leds: add aw20xx driver
Date: Wed, 1 Mar 2023 08:56:45 +0000 [thread overview]
Message-ID: <Y/8TTRtoFMJhMWV1@google.com> (raw)
In-Reply-To: <Y/5xBGFC3b9Chdtb@duo.ucw.cz>
On Tue, 28 Feb 2023, Pavel Machek wrote:
> Hi!
>
> > +config LEDS_AW200XX
> > + tristate "LED support for Awinic AW20036/AW20054/AW20072"
> > + depends on LEDS_CLASS
> > + depends on I2C
> > + help
> > + This option enables support for the AW20036/AW20054/AW20072 LED driver.
> > + It is a 3x12/6x9/6x12 matrix LED driver programmed via
> > + an I2C interface, up to 36/54/72 LEDs or 12/18/24 RGBs,
> > + 3 pattern controllers for auto breathing or group dimming control.
>
> I'm afraid this should be handled as a display, not as an array of
> individual LEDs.
Just for my own information, where do we draw the line on this?
Is 4x4 okay? How about 6x6?
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-03-01 8:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 21:10 [PATCH v2 0/2] leds: add aw20xx driver Martin Kurbanov
2023-02-28 21:10 ` [PATCH v2 1/2] dt-bindings: leds: add binding for aw200xx Martin Kurbanov
2023-03-02 7:48 ` Krzysztof Kozlowski
2023-03-02 16:02 ` Martin Kurbanov
2023-03-03 7:43 ` Krzysztof Kozlowski
2023-02-28 21:10 ` [PATCH v2 2/2] leds: add aw20xx driver Martin Kurbanov
2023-02-28 21:24 ` Pavel Machek
2023-02-28 21:40 ` AUXdisplay for LED arrays, keyboards with per-key LEDs -- was " Pavel Machek
2023-03-01 9:38 ` Jani Nikula
2023-03-01 8:56 ` Lee Jones [this message]
2023-03-01 9:54 ` Pavel Machek
2023-03-01 14:17 ` Lee Jones
2023-03-02 14:00 ` Martin Kurbanov
2023-02-28 21:51 ` Andy Shevchenko
2023-03-01 5:33 ` kernel test robot
2023-03-01 12:26 ` kernel test robot
2023-03-01 13:51 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/8TTRtoFMJhMWV1@google.com \
--to=lee@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@sberdevices.ru \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mmkurbanov@sberdevices.ru \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).