Re: [PATCH v1 03/10] dt-bindings: sound: nvidia,tegra-audio: add RT5631 CODEC

Rob Herring
2023-02-26T19:37:28Z

On Tue, Feb 21, 2023 at 08:32:04PM +0200, Svyatoslav Ryhel wrote:
> From: David Heidelberg <david@ixit.cz>
>
> Add dt-binding for RT5631 CODEC.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>

Your S-o-b is needed here as well.

> ---
> .../sound/nvidia,tegra-audio-rt5631.yaml | 88 +++++++++++++++++++
> 1 file changed, 88 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5631.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5631.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5631.yaml
> new file mode 100644
> index 000000000000..b347f34c47f2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5631.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/nvidia,tegra-audio-rt5631.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NVIDIA Tegra audio complex with RT5631 CODEC
> +
> +maintainers:
> + - Jon Hunter <jonathanh@nvidia.com>
> + - Thierry Reding <thierry.reding@gmail.com>
> +
> +allOf:
> + - $ref: nvidia,tegra-audio-common.yaml#
> +
> +properties:
> + compatible:
> + items:
> + - pattern: '^[a-z0-9]+,tegra-audio-rt5631(-[a-z0-9]+)+$'
> + - const: nvidia,tegra-audio-rt5631
> +
> + nvidia,audio-routing:
> + $ref: /schemas/types.yaml#/definitions/non-unique-string-array
> + description: |
> + A list of the connections between audio components.
> + Each entry is a pair of strings, the first being the connection's sink,
> + the second being the connection's source. Valid names for sources and
> + sinks are the pins (documented in the binding document),
> + and the jacks on the board.
> + minItems: 2
> + items:
> + enum:
> + # Board Connectors
> + - "Int Spk"
> + - "Headphone Jack"
> + - "Mic Jack"
> + - "Int Mic"
> +
> + # CODEC Pins
> + - MIC1
> + - MIC2
> + - AXIL
> + - AXIR
> + - MONOIN_RXN
> + - MONOIN_RXP
> + - DMIC
> + - MIC Bias1
> + - MIC Bias2
> + - MONO_IN
> + - AUXO1
> + - AUXO2
> + - SPOL
> + - SPOR
> + - HPOL
> + - HPOR
> + - MONO
> +
> +required:
> + - nvidia,i2s-controller
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/tegra30-car.h>
> + #include <dt-bindings/soc/tegra-pmc.h>
> + sound {
> + compatible = "asus,tegra-audio-rt5631-tf700t",
> + "nvidia,tegra-audio-rt5631";
> + nvidia,model = "Asus Transformer Infinity TF700T RT5631";
> +
> + nvidia,audio-routing =
> + "Headphone Jack", "HPOL",
> + "Headphone Jack", "HPOR",
> + "Int Spk", "SPOL",
> + "Int Spk", "SPOR",
> + "MIC1", "MIC Bias1",
> + "MIC Bias1", "Mic Jack",
> + "DMIC", "Int Mic";
> +
> + nvidia,i2s-controller = <&tegra_i2s1>;
> + nvidia,audio-codec = <&rt5631>;
> +
> + clocks = <&tegra_car TEGRA30_CLK_PLL_A>,
> + <&tegra_car TEGRA30_CLK_PLL_A_OUT0>,
> + <&tegra_pmc TEGRA_PMC_CLK_OUT_1>;
> + clock-names = "pll_a", "pll_a_out0", "mclk";
> + };
> --
> 2.37.2
>