Re: [PATCH v1 09/10] staging: dsp: add support for Fortemedia FM34NE DSP

Svyatoslav Ryhel
2023-02-22T08:20:02Z

вт, 21 лют. 2023 р. о 21:27 Greg Kroah-Hartman
<gregkh@linuxfoundation.org> пише:
>
> On Tue, Feb 21, 2023 at 08:32:10PM +0200, Svyatoslav Ryhel wrote:
> > FM34NE is digital sound processing chip used for active
> > noise suppression mainly on ASUS Transformers.
> >
> > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > ---
> > drivers/staging/Kconfig | 2 +
> > drivers/staging/Makefile | 1 +
> > drivers/staging/dsp/Kconfig | 7 +
> > drivers/staging/dsp/Makefile | 2 +
> > drivers/staging/dsp/dsp-fm34ne.c | 364 +++++++++++++
> > drivers/staging/dsp/dsp-fm34ne.h | 845 +++++++++++++++++++++++++++++++
> > 6 files changed, 1221 insertions(+)
> > create mode 100644 drivers/staging/dsp/Kconfig
> > create mode 100644 drivers/staging/dsp/Makefile
> > create mode 100644 drivers/staging/dsp/dsp-fm34ne.c
> > create mode 100644 drivers/staging/dsp/dsp-fm34ne.h
>
>
> Sorry, but why is this going into drivers/staging/ at all? What is
> needed to be done to get this out of staging? Why not do that work
> right now? At the least, we need a TODO file in the directory that
> lists what needs to be done and who is responsible for it.

Because this driver sets up fm34 and switches it to bypass mode allowing
sound to work on the device. There is no dsp framework in kernel which could
be called to operate dsp from the actual sound codec. (If there is, I
would be glad
if you show me). Fm34 must be active only on DMIC use, all other cases require
it to be in bypass.

> But again, just do the work now, it's faster and simpler to do it before
> you submit it instead of waiting until after it is merged.
>
> Also, no need for a .h file when you only have one .c file. Just put
> them all together into one file please.

I understand, but the header contains sets of configuration sequences.
Including those into .c will make it barely readable.

> thanks,
>
> greg k-h