From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BFB1C64ED8 for ; Mon, 27 Feb 2023 18:12:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230436AbjB0SMo (ORCPT ); Mon, 27 Feb 2023 13:12:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230410AbjB0SMo (ORCPT ); Mon, 27 Feb 2023 13:12:44 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CC98234F7; Mon, 27 Feb 2023 10:12:42 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 15492B80D6D; Mon, 27 Feb 2023 18:12:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67D79C433D2; Mon, 27 Feb 2023 18:12:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677521559; bh=zMhMn8aAWF1yij6h/z2ZQ66w5ISBOOImdqMr7vAIcJ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UByeI1j6YFGybIKdXAkZNElk4G3cms0EW3kzf4qqXkGQHebKNAbLiygzTKQH9WdA/ ROmOZ9Vx2kidAqUwx/OK7IB2t3jEVKLDFHk2zxx0BymR3xCsTRgbaJD+qUW6wX2a7z zCcEzcw8idFMHhowAGyfWHFPt8JZ8+IUTR7JEQLZFRTDKPp6tVDi8du4Mnk7Rjal5D pQD01wOZb07LIWDU4Ji6t9RKZ/0oSxUxgQQtD6jwbUlin5OiCi9G/kz/hPebpRXWNq 7JzTw8ofrp9V+lgBkwP1F+DgKofx5TeyV1oYwz5J2U++r0WgDdjqd5LtCHaLzFO60i 1ZjN6FQyN9oCg== Date: Mon, 27 Feb 2023 18:12:33 +0000 From: Conor Dooley To: Hal Feng Cc: Emil Renner Berthing , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, Stephen Boyd , Michael Turquette , Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Palmer Dabbelt , Paul Walmsley , Albert Ou , Ben Dooks , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 19/19] riscv: dts: starfive: Add StarFive JH7110 VisionFive 2 board device tree Message-ID: References: <20230221024645.127922-1-hal.feng@starfivetech.com> <20230221024645.127922-20-hal.feng@starfivetech.com> <2af3f84b-2c2b-dc79-c76c-9411fcbcf7ca@starfivetech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qQDklUlJ7jtziWjT" Content-Disposition: inline In-Reply-To: <2af3f84b-2c2b-dc79-c76c-9411fcbcf7ca@starfivetech.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --qQDklUlJ7jtziWjT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 23, 2023 at 04:50:20PM +0800, Hal Feng wrote: > On Tue, 21 Feb 2023 16:03:08 +0100, Emil Renner Berthing wrote: > > On Tue, 21 Feb 2023 at 03:47, Hal Feng wrot= e: > >> From: Emil Renner Berthing > >> > >> Add a minimal device tree for StarFive JH7110 VisionFive 2 board > >> which has version A and version B. Support booting and basic > >> clock/reset/pinctrl/uart drivers. > >> > >> Acked-by: Conor Dooley > >> Signed-off-by: Emil Renner Berthing > >> Co-developed-by: Jianlong Huang > >> Signed-off-by: Jianlong Huang > >> Co-developed-by: Hal Feng > >> Signed-off-by: Hal Feng > >> --- > >> arch/riscv/boot/dts/starfive/Makefile | 6 +- > >> .../jh7110-starfive-visionfive-2-v1.2a.dts | 13 ++ > >> .../jh7110-starfive-visionfive-2-v1.3b.dts | 13 ++ > >> .../jh7110-starfive-visionfive-2.dtsi | 215 ++++++++++++++++++ > >> 4 files changed, 246 insertions(+), 1 deletion(-) > >> create mode 100644 arch/riscv/boot/dts/starfive/jh7110-starfive-visio= nfive-2-v1.2a.dts > >> create mode 100644 arch/riscv/boot/dts/starfive/jh7110-starfive-visio= nfive-2-v1.3b.dts > >> create mode 100644 arch/riscv/boot/dts/starfive/jh7110-starfive-visio= nfive-2.dtsi > >> > >> diff --git a/arch/riscv/boot/dts/starfive/Makefile b/arch/riscv/boot/d= ts/starfive/Makefile > >> index 039c143cba33..cd73519b907b 100644 > >> --- a/arch/riscv/boot/dts/starfive/Makefile > >> +++ b/arch/riscv/boot/dts/starfive/Makefile > >> @@ -1,2 +1,6 @@ > >> # SPDX-License-Identifier: GPL-2.0 > >> -dtb-$(CONFIG_SOC_STARFIVE) +=3D jh7100-beaglev-starlight.dtb jh7100-s= tarfive-visionfive-v1.dtb > >> +dtb-$(CONFIG_SOC_STARFIVE) +=3D jh7100-beaglev-starlight.dtb > >> +dtb-$(CONFIG_SOC_STARFIVE) +=3D jh7100-starfive-visionfive-v1.dtb > >> + > >> +dtb-$(CONFIG_SOC_STARFIVE) +=3D jh7110-starfive-visionfive-2-v1.2a.dtb > >> +dtb-$(CONFIG_SOC_STARFIVE) +=3D jh7110-starfive-visionfive-2-v1.3b.dtb If you could rebase on top of v6.3-rc1 for the next version & use ARCH_ not SOC_ here that'd be great. > >> +/ { > >> + aliases { > >> + serial0 =3D &uart0; > >> + i2c0 =3D &i2c0; > >> + i2c2 =3D &i2c2; > >> + i2c5 =3D &i2c5; > >> + i2c6 =3D &i2c6; > >=20 > > Let's keep these sorted alphabetically. >=20 > OK, will fix it. >=20 > > It would be great to have some sort of order to this file so it's > > obvious where to add new nodes. I suggest we do > > - root node > > - external clocks > > - other node references in alphabetical order > >=20 > > You're almost there with this patch except the uart0 node is out of pla= ce. >=20 > Will fix accordingly. Thanks for your suggestions. With Emil's suggestions implemented: Reviewed-by: Conor Dooley Thanks, Conor. --qQDklUlJ7jtziWjT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY/zykQAKCRB4tDGHoIJi 0rQPAPkBDZJoRNk6lCcj0ANg8faGvHfRWGdaYyYaWI+YfboLwAD+PN28woxpivfc IvPNVwHix48qqNSe6XV1YTMwD50HggM= =0cCt -----END PGP SIGNATURE----- --qQDklUlJ7jtziWjT--