Re: [PATCH v4 1/8] dt-bindings: phy: Add qcom,snps-eusb2-phy schema file

Rob Herring
2023-02-02T15:03:59Z

On Thu, 02 Feb 2023 15:25:04 +0200, Abel Vesa wrote:
> The SM8550 SoC uses Synopsis eUSB2 PHY. Add a dt-binding schema
> for the new driver.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>
> The v3 version of this patch was here:
> https://lore.kernel.org/all/20230126131415.1453741-2-abel.vesa@linaro.org/
>
> Changes since v3:
> * removed blank line, like Rob suggested
> * dropped quotes and reset description, like Rob suggested
> * dropped the RPMH_CXO_PAD_CLK clock and the ref_src clock name
> to match the schema
> * fixed filenames of the includes in the example (sm8550-gcc and
> sm8550-tcsr)
>
> Changes since v2:
> * none
>
> Changes since v1:
> * dropped the "ref src" clock
> * dropped the usb-repeater property
>
> .../bindings/phy/qcom,snps-eusb2-phy.yaml | 74 +++++++++++++++++++
> 1 file changed, 74 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.example.dts:20:18: fatal error: dt-bindings/clock/qcom,sm8550-tcsr.h: No such file or directory
20 | #include <dt-bindings/clock/qcom,sm8550-tcsr.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:434: Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1508: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230202132511.3983095-2-abel.vesa@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.