Re: [PATCH 3/3] arm64: tegra: Add Tegra234 pinmux device

Thierry Reding
2023-02-08T15:46:40Z

[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]

On Wed, Feb 08, 2023 at 01:06:02PM +0100, Krzysztof Kozlowski wrote:
> On 08/02/2023 13:01, Krzysztof Kozlowski wrote:
> >> I wonder if there's a good way to detect these. We'd have to run checks
> >> on the DT source files, so that's a bit difficult. I do have an
> >> experimental script that tries to capture some common pitfalls on
> >> sources but it's quite ugly and slow, but I guess I could add something
> >> like this. But perhaps there are better ways?
> >
> > One way to easy spot them is to override always by label, thus every
> > node defined like above is a new node. However I think we talked about
> > this and you do not follow this practice, thus there is no way to tell -
> > is the status reasonable or not.
> >
> > Automated tools could help here as well - run fdtdump on DTB and look
> > for status=okay.
>
> Eh, obviously it won't work - every node which was disabled in DTSI and
> enabled in DTS will have the status=okay...

Yeah, I was originally thinking along the same lines, but when things
are overridden that check no longer works. I suppose DTC could be taught
to check for this when it merges nodes.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]