From: Andrew Lunn <andrew@lunn.ch>
To: Md Danish Anwar <a0501179@ti.com>
Cc: Roger Quadros <rogerq@kernel.org>,
MD Danish Anwar <danishanwar@ti.com>,
"Andrew F. Davis" <afd@ti.com>, Suman Anna <s-anna@ti.com>,
YueHaibing <yuehaibing@huawei.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
nm@ti.com, ssantosh@kernel.org, srk@ti.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH v4 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver
Date: Thu, 9 Feb 2023 14:54:56 +0100 [thread overview]
Message-ID: <Y+T7MAu0/s1bjYIt@lunn.ch> (raw)
In-Reply-To: <6713252d-6f86-c674-9229-c4512ebf1d72@ti.com>
> Sure, I'll do that. In the list of all phy modes described in [1], I can only
> see phy-mode "rgmii-txid", for which we can return -EINVAL. Is there any other
> phy-mode that requires enabling/disabling TX internal delays? Please let me
> know if any other phy-mode also needs this. I will add check for that as well.
There are 4 phy-modes for RGMII.
rgmii, rgmii-id, rmgii-rxid, rgmii-txid.
rgmii-id, rgmii-txid both require TX delays. If you do that in the MAC
you then need to pass rgmii-rxid and rgmii to the PHY respectively.
rmii and rgmii-rxid requires no TX delays, which your SoC cannot do,
so you need to return -EINVAl,
The interpretation of these properties is all really messy and
historically not very uniformly done. Which is why i recommend the MAC
does nothing, leaving it to the PHY. That generally works since the
PHYs have a pretty uniform implementation. But in your case, you don't
have that option. So i suggest you do what is described above.
Andrew
next prev parent reply other threads:[~2023-02-09 13:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 6:07 [PATCH v4 0/2] Introduce ICSSG based ethernet Driver MD Danish Anwar
2023-02-06 6:07 ` [PATCH v4 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings MD Danish Anwar
2023-02-06 7:50 ` Krzysztof Kozlowski
2023-02-06 10:39 ` [EXTERNAL] " Md Danish Anwar
2023-02-06 10:41 ` Krzysztof Kozlowski
2023-02-07 5:07 ` Md Danish Anwar
2023-02-06 13:46 ` Rob Herring
2023-02-07 5:00 ` [EXTERNAL] " Md Danish Anwar
2023-02-06 6:07 ` [PATCH v4 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver MD Danish Anwar
2023-02-06 14:15 ` Andrew Lunn
2023-02-07 15:29 ` [EXTERNAL] " Md Danish Anwar
2023-02-07 19:56 ` Roger Quadros
2023-02-08 7:46 ` [EXTERNAL] " Md Danish Anwar
2023-02-08 9:17 ` Roger Quadros
2023-02-08 12:56 ` Andrew Lunn
2023-02-09 10:29 ` [EXTERNAL] " Md Danish Anwar
2023-02-09 12:58 ` Roger Quadros
2023-02-09 13:43 ` [EXTERNAL] " Md Danish Anwar
2023-02-09 13:54 ` Andrew Lunn [this message]
2023-02-10 6:26 ` Md Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+T7MAu0/s1bjYIt@lunn.ch \
--to=andrew@lunn.ch \
--cc=a0501179@ti.com \
--cc=afd@ti.com \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=s-anna@ti.com \
--cc=srk@ti.com \
--cc=ssantosh@kernel.org \
--cc=vigneshr@ti.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).