From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Daniel Kaehn <kaehndan@gmail.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
jikos@kernel.org, benjamin.tissoires@redhat.com,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
ethan.twardy@plexus.com
Subject: Re: [PATCH v4 3/4] HID: cp2112: Fix driver not registering GPIO IRQ chip as threaded
Date: Thu, 9 Feb 2023 16:32:21 -0800 [thread overview]
Message-ID: <Y+WQlf/CjcuPaHf/@google.com> (raw)
In-Reply-To: <CAP+ZCCfnbMpQX4qQee3QZgOft=vQ0BLBgqQUwzPNH7qYopufAQ@mail.gmail.com>
On Tue, Feb 07, 2023 at 06:34:32AM -0600, Daniel Kaehn wrote:
> On Mon, Feb 6, 2023 at 5:15 PM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > On Mon, Feb 06, 2023 at 07:50:15AM -0600, Danny Kaehn wrote:
> > > The CP2112 generates interrupts from a polling routine on a thread,
> > > and can only support threaded interrupts. This patch configures the
> > > gpiochip irq chip with this flag, disallowing consumers to request
> > > a hard IRQ from this driver, which resulted in a segfault previously.
> >
> > This looks like a bugfix not dependent on anything else in the series
> > and can be applied separately...
>
> This is correct (though usage of this patchset to instantiate drivers
> which request interrupts will most of the time be broken without this
> patch). Does this mean I should submit this patch independently from
> the rest of the series? Or should I just include a message to the
> maintainer describing what you said (that this can be applied
> separately)?
I'd simply sent it separately and then you do not need to explain ;)
Thanks.
--
Dmitry
next prev parent reply other threads:[~2023-02-10 0:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 13:50 [PATCH v4 0/4] DeviceTree Support for USB-HID Devices and CP2112 Danny Kaehn
2023-02-06 13:50 ` [PATCH v4 1/4] dt-bindings: i2c: Add CP2112 HID USB to SMBus Bridge Danny Kaehn
2023-02-06 16:17 ` Krzysztof Kozlowski
2023-02-07 18:50 ` Rob Herring
2023-02-08 13:16 ` Daniel Kaehn
2023-02-06 13:50 ` [PATCH v4 2/4] HID: usbhid: Share USB device devicetree node with child HID device Danny Kaehn
2023-02-06 23:14 ` Dmitry Torokhov
2023-02-06 13:50 ` [PATCH v4 3/4] HID: cp2112: Fix driver not registering GPIO IRQ chip as threaded Danny Kaehn
2023-02-06 23:15 ` Dmitry Torokhov
2023-02-07 12:34 ` Daniel Kaehn
2023-02-10 0:32 ` Dmitry Torokhov [this message]
2023-02-06 13:50 ` [PATCH v4 4/4] HID: cp2112: Devicetree Support Danny Kaehn
2023-02-06 23:18 ` Dmitry Torokhov
2023-02-07 10:15 ` Andy Shevchenko
2023-02-07 12:28 ` Daniel Kaehn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+WQlf/CjcuPaHf/@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=ethan.twardy@plexus.com \
--cc=jikos@kernel.org \
--cc=kaehndan@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).