public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: neil.armstrong@linaro.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: dma: qcom,bam-dma: add optional memory interconnect properties
Date: Fri, 10 Feb 2023 11:13:26 +0530	[thread overview]
Message-ID: <Y+XZflMj82Ot/UzW@matsya> (raw)
In-Reply-To: <32153a4b-9974-a42a-ef30-c0bd8cbc732b@linaro.org>

On 09-02-23, 13:55, Bhupesh Sharma wrote:
> On 2/8/23 2:38 PM, neil.armstrong@linaro.org wrote:
> > On 08/02/2023 10:03, Krzysztof Kozlowski wrote:

> > > What I don't really get is that crypto driver sets bandwidth for
> > > interconnects, not the BAM. Why BAM needs interconnect? Usually you do
> > > not need to initialize some middle paths. Getting the final interconnect
> > > path (e.g. crypto-memory) is enough, because it includes everything in
> > > between.
> > 
> > Indeed the interconnect on BAM may be redundant since QCE sets the BW,
> > I'll investigate to understand if it's also necessary on BAM.
> 
> Since we are already doing this via QCE driver (since crypto block on qcom
> SoCs employs BAM DMA services) via [1], this change is not needed for
> sm8150, sm8250, sm8350 and subsequent qcom SoCs (available presently), so
> this patch can be dropped.

Is that the right approach, should the dma consumers request the
bandwidth or the dma driver. I am kind of leaning on the former

-- 
~Vinod

  parent reply	other threads:[~2023-02-10  5:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07 10:03 [PATCH] dt-bindings: dma: qcom,bam-dma: add optional memory interconnect properties Neil Armstrong
2023-02-07 10:32 ` Dmitry Baryshkov
2023-02-07 13:35   ` Neil Armstrong
2023-02-07 15:27     ` Dmitry Baryshkov
2023-02-08  9:03       ` Krzysztof Kozlowski
2023-02-08  9:08         ` neil.armstrong
2023-02-09  8:25           ` Bhupesh Sharma
2023-02-09  8:27             ` neil.armstrong
2023-02-10  5:43             ` Vinod Koul [this message]
2023-02-08  8:58 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+XZflMj82Ot/UzW@matsya \
    --to=vkoul@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bhupesh.sharma@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox