From: Abel Vesa <abel.vesa@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Neil Armstrong <neil.armstrong@linaro.org>
Subject: Re: [PATCH] regulator: dt-bindings: qcom,rpmh: Correct PM8550 family supplies
Date: Sat, 11 Feb 2023 20:47:03 +0200 [thread overview]
Message-ID: <Y+fip91HJ8Fip49i@linaro.org> (raw)
In-Reply-To: <20230210155930.549082-1-krzysztof.kozlowski@linaro.org>
On 23-02-10 16:59:30, Krzysztof Kozlowski wrote:
> PM8550 is different than PM8550VE/VS, because the latter has much
> smaller amount of supplies (l1-3 and s1-6) and regulators. The PM8550
> has on theh other hand one pin for vdd-l1-l4-l10 supplies. Correct the
Nit: ... on the other ...
> if:then: clause with their supplies.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Otherwise, LGTM:
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> .../bindings/regulator/qcom,rpmh-regulator.yaml | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
> index 297a75069f60..fb9621b4b4cd 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
> @@ -308,19 +308,29 @@ allOf:
> compatible:
> enum:
> - qcom,pm8550-rpmh-regulators
> - - qcom,pm8550ve-rpmh-regulators
> - - qcom,pm8550vs-rpmh-regulators
> then:
> properties:
> + vdd-l1-l4-l10-supply: true
> vdd-l2-l13-l14-supply: true
> vdd-l5-l16-supply: true
> vdd-l6-l7-supply: true
> vdd-l8-l9-supply: true
> patternProperties:
> - "^vdd-l([1-4]|1[0-7])-supply$": true
> + "^vdd-l(3|1[1-7])-supply$": true
> "^vdd-s[1-6]-supply$": true
> "^vdd-bob[1-2]-supply$": true
>
> + - if:
> + properties:
> + compatible:
> + enum:
> + - qcom,pm8550ve-rpmh-regulators
> + - qcom,pm8550vs-rpmh-regulators
> + then:
> + patternProperties:
> + "^vdd-l[1-3]-supply$": true
> + "^vdd-s[1-6]-supply$": true
> +
> - if:
> properties:
> compatible:
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-02-11 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 15:59 [PATCH] regulator: dt-bindings: qcom,rpmh: Correct PM8550 family supplies Krzysztof Kozlowski
2023-02-11 18:47 ` Abel Vesa [this message]
2023-02-14 23:47 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+fip91HJ8Fip49i@linaro.org \
--to=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).