* [PATCH v2] arm64: dts: qcom: sc7280: Adjust zombie PWM frequency
@ 2023-02-13 2:59 Owen Yang
2023-02-13 16:45 ` Matthias Kaehlcke
2023-02-13 22:23 ` Bjorn Andersson
0 siblings, 2 replies; 4+ messages in thread
From: Owen Yang @ 2023-02-13 2:59 UTC (permalink / raw)
To: LKML
Cc: Stephen Boyd, Abner Yen, Harvey, Matthias Kaehlcke, Doug Anderson,
Bob Moragues, Gavin Lee, Owen Yang, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-arm-msm
Tune the PWM to solve screen flashing issue and high frequency noise.
While at it, the comment for the PWM settings incorrectly said we were using a 5kHz duty cycle. It should have said "period", not "duty cycle".
Correct this while updating the values.
Signed-off-by: Owen Yang <ecs.taipeikernel@gmail.com>
---
Changes in v2:
-Correct unit and update values in comment.
arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi
index 64deaaabac0f..a4fde22e3355 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtsi
@@ -61,8 +61,8 @@ ap_tp_i2c: &i2c0 {
};
&pm8350c_pwm_backlight {
- /* Set the PWM period to 200 microseconds (5kHz duty cycle) */
- pwms = <&pm8350c_pwm 3 200000>;
+ /* Set the PWM period to 320 microseconds (3.125kHz frequency) */
+ pwms = <&pm8350c_pwm 3 320000>;
};
&pwmleds {
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: sc7280: Adjust zombie PWM frequency
2023-02-13 2:59 [PATCH v2] arm64: dts: qcom: sc7280: Adjust zombie PWM frequency Owen Yang
@ 2023-02-13 16:45 ` Matthias Kaehlcke
2023-02-13 16:49 ` Doug Anderson
2023-02-13 22:23 ` Bjorn Andersson
1 sibling, 1 reply; 4+ messages in thread
From: Matthias Kaehlcke @ 2023-02-13 16:45 UTC (permalink / raw)
To: Owen Yang
Cc: LKML, Stephen Boyd, Abner Yen, Harvey, Doug Anderson,
Bob Moragues, Gavin Lee, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-arm-msm
On Mon, Feb 13, 2023 at 10:59:05AM +0800, Owen Yang wrote:
> Tune the PWM to solve screen flashing issue and high frequency noise.
> While at it, the comment for the PWM settings incorrectly said we were using a 5kHz duty cycle. It should have said "period", not "duty cycle".
Please split this into two lines
> Correct this while updating the values.
>
> Signed-off-by: Owen Yang <ecs.taipeikernel@gmail.com>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sc7280: Adjust zombie PWM frequency
2023-02-13 16:45 ` Matthias Kaehlcke
@ 2023-02-13 16:49 ` Doug Anderson
0 siblings, 0 replies; 4+ messages in thread
From: Doug Anderson @ 2023-02-13 16:49 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Owen Yang, LKML, Stephen Boyd, Abner Yen, Harvey, Bob Moragues,
Gavin Lee, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm
Hi,
On Mon, Feb 13, 2023 at 8:45 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> On Mon, Feb 13, 2023 at 10:59:05AM +0800, Owen Yang wrote:
> > Tune the PWM to solve screen flashing issue and high frequency noise.
> > While at it, the comment for the PWM settings incorrectly said we were using a 5kHz duty cycle. It should have said "period", not "duty cycle".
>
> Please split this into two lines
>
> > Correct this while updating the values.
> >
> > Signed-off-by: Owen Yang <ecs.taipeikernel@gmail.com>
>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sc7280: Adjust zombie PWM frequency
2023-02-13 2:59 [PATCH v2] arm64: dts: qcom: sc7280: Adjust zombie PWM frequency Owen Yang
2023-02-13 16:45 ` Matthias Kaehlcke
@ 2023-02-13 22:23 ` Bjorn Andersson
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2023-02-13 22:23 UTC (permalink / raw)
To: LKML, Owen Yang
Cc: Abner Yen, Doug Anderson, Harvey, Rob Herring, Matthias Kaehlcke,
Krzysztof Kozlowski, Gavin Lee, Andy Gross, Stephen Boyd,
linux-arm-msm, Konrad Dybcio, devicetree, Bob Moragues
On Mon, 13 Feb 2023 10:59:05 +0800, Owen Yang wrote:
> Tune the PWM to solve screen flashing issue and high frequency noise.
> While at it, the comment for the PWM settings incorrectly said we were using a 5kHz duty cycle. It should have said "period", not "duty cycle".
> Correct this while updating the values.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sc7280: Adjust zombie PWM frequency
commit: f15c1b1bd3c2b3a688d1139593be6c620bb9af6f
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-13 22:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-13 2:59 [PATCH v2] arm64: dts: qcom: sc7280: Adjust zombie PWM frequency Owen Yang
2023-02-13 16:45 ` Matthias Kaehlcke
2023-02-13 16:49 ` Doug Anderson
2023-02-13 22:23 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox