From: Christoph Hellwig <hch@infradead.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: JiaJie Ho <jiajie.ho@starfivetech.com>,
"David S . Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Conor Dooley <conor.dooley@microchip.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v2 4/4] crypto: starfive - Add hash and HMAC support
Date: Mon, 13 Feb 2023 22:12:57 -0800 [thread overview]
Message-ID: <Y+smaRL9f7g9RWEB@infradead.org> (raw)
In-Reply-To: <Y+TARjfzt2FMG6oJ@gondor.apana.org.au>
On Thu, Feb 09, 2023 at 05:43:34PM +0800, Herbert Xu wrote:
> On Thu, Feb 09, 2023 at 09:33:06AM +0000, JiaJie Ho wrote:
> >
> > The DMA can only support 32-bit addressing.
> > So, I am copying everything in case kernel allocated memory region >32-bit for a user app.
>
> Does your hardware support scatter-and-gather? If so you should
> at least allocate individual pages rather than one contiguous buffer.
>
> Then you can allocate them on-demand rather than before-hand.
>
> It would also be nice to not do the copy if the input you were
> given was in low memory (and contiguous if your hardware doesn't
> do SG).
All of that is done by the DMA API, or more specifically swiotlb and
does not need to be duplicated in individual drivers.
next prev parent reply other threads:[~2023-02-14 6:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 15:42 [PATCH v2 0/4] crypto: starfive - Add drivers for crypto engine Jia Jie Ho
2023-01-30 15:42 ` [PATCH v2 1/4] dt-bindings: crypto: Add StarFive crypto module Jia Jie Ho
2023-02-01 1:44 ` Rob Herring
2023-01-30 15:42 ` [PATCH v2 2/4] crypto: starfive - Add crypto engine support Jia Jie Ho
2023-01-30 15:42 ` [PATCH v2 3/4] riscv: dts: starfive: Add crypto and DMA node for VisionFive 2 Jia Jie Ho
2023-03-07 21:48 ` Palmer Dabbelt
2023-01-30 15:42 ` [PATCH v2 4/4] crypto: starfive - Add hash and HMAC support Jia Jie Ho
2023-02-09 9:14 ` Herbert Xu
2023-02-09 9:33 ` JiaJie Ho
2023-02-09 9:43 ` Herbert Xu
2023-02-10 1:05 ` JiaJie Ho
2023-02-14 6:12 ` Christoph Hellwig [this message]
2023-02-14 7:11 ` JiaJie Ho
2023-02-10 2:40 ` Herbert Xu
2023-02-14 6:12 ` Christoph Hellwig
2023-02-09 9:46 ` Herbert Xu
2023-02-10 1:39 ` JiaJie Ho
2023-02-08 15:10 ` [PATCH v2 0/4] crypto: starfive - Add drivers for crypto engine JiaJie Ho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+smaRL9f7g9RWEB@infradead.org \
--to=hch@infradead.org \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jiajie.ho@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).