From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D78EC6379F for ; Tue, 14 Feb 2023 12:06:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229938AbjBNMGx (ORCPT ); Tue, 14 Feb 2023 07:06:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229713AbjBNMGw (ORCPT ); Tue, 14 Feb 2023 07:06:52 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38D9761A0 for ; Tue, 14 Feb 2023 04:06:51 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id h16so15370679wrz.12 for ; Tue, 14 Feb 2023 04:06:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8dTuoqSN3nUDDHUnixCG2GlQIWQEKens+Uo3RsvB8jE=; b=q9h33ThpgiMyYvC2n+ERo8vzFNnzZfEGcIoRHB+lMy8eyajiSNpr5wAiHMT0OjuOnj ATvlfkUN1Igmqv7DCdml7Gqb26JIBMmp7B4/zvGIslPLMc2vLWVE5rwuygpoLkVuB6dB Rh97wAQbE2l6ZIJLcbBtJfeNpHl5pJkzuMeyTNJVDsymwwxJpGqHFeucOxiPwedWUX8c rR1on4AC+rI1SY+dtjoHrO/XtwcfqlMH5lQ4ZjSleA1bYhZ127dA8K4k/y2Jtdn7SDpA 6AdWOPVqXQhsFO9c2xSS35nQmSjhim3BvD3ts39iwEhcmsOM0yl5Pi/GCSmkh8ZCpuDl IHNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8dTuoqSN3nUDDHUnixCG2GlQIWQEKens+Uo3RsvB8jE=; b=WQXuiyn01204qk0AH64YogKiY7tM5eaw1WdueznNWU4yshpQZgTXVFT1PVqh2Kz/4R AocF7pNFcyN5qToqal6P/ONlDYz0MxJDOc5agY4vJQgMzDt1dZa+odztnqpobKW3OQ1Q xGpUHVE0rlBii0fbXFpuT3+C/RSPHyjdXXbJG4ve025ManaBF8Aavf6XjtvpSdrjD8b0 /115bd3gunSly0gR223ccvvnco/H3FRTBs6FWZBzKTmkhgbN3S0ckqcKMSez9Sfqp5CO ljg1UWV0gXsxRmhnQFjX+JDC6yEPo+LrOEUD8zs6tc+M4ERf3FYhWnvKcI0ELhZDqqgb aRdg== X-Gm-Message-State: AO0yUKX3KfVaKZLdQ2Bh6eBYnmg8anQJbAwMc6JZwoc1HKd2E7Kkqjcj OTjdqW2vnPV6No5VM9YBv1Z79g== X-Google-Smtp-Source: AK7set/yJWOH5/Bmi1HyNWbYN6j+KyNu4iEr6LIugfGebQGZt8mZBxo1n7ylPuqzgjj23iLLvZnBIA== X-Received: by 2002:a5d:4006:0:b0:2c5:4ccc:a770 with SMTP id n6-20020a5d4006000000b002c54ccca770mr2077419wrp.7.1676376409738; Tue, 14 Feb 2023 04:06:49 -0800 (PST) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id q9-20020a5d6589000000b002c559405a1csm4632273wru.20.2023.02.14.04.06.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 04:06:49 -0800 (PST) Date: Tue, 14 Feb 2023 14:06:47 +0200 From: Abel Vesa To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Adrian Hunter , Ulf Hansson , "James E . J . Bottomley" , "Martin K . Petersen" , Manivannan Sadhasivam , Eric Biggers Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List , linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [RFC PATCH 0/5] Add dedicated Qcom ICE driver Message-ID: References: <20230214120253.1098426-1-abel.vesa@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230214120253.1098426-1-abel.vesa@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23-02-14 14:02:48, Abel Vesa wrote: > As both SDCC and UFS drivers use the ICE with duplicated implementation, > while none of the currently supported platforms make use concomitantly > of the ICE IP block, the new SM8550 allows both UFS and SDCC to do so. > In order to support such scenario, there is a need for a unified > implementation and a devicetree node to be shared between both types > of storage devices. So lets drop the duplicate implementation of the ICE > from both SDCC and UFS and make it a dedicated (soc) driver. > > This RFC should be treated as work-in-progress. Initially, its goal is > to figure out what is the most agreeable implementation for both types > of storage. Note that currently, only one ICE instance is supported > (like the existing HW suggests) and it is laking refcounting and locking > of any sort. Also missing bindings schema file for now. > > Any suggestions are welcome at this point, including the location of > such a new driver. Forgot to mention here that I only managed to test the UFS on SM8450 HDK. Though functionally nothing should be impacted, I intend to test the SDCC on SDM630 soon. The devicetree sdm630 patch is here for proof-of-concept, mainly. > > Abel Vesa (5): > soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver > arm64: dts: qcom: sm8450: Add the Inline Crypto Engine node > arm64: dts: qcom: sdm630: Add the Inline Crypto Engine node > scsi: ufs: ufs-qcom: Switch to the new ICE API > mmc: sdhci-msm: Switch to the new ICE API > > arch/arm64/boot/dts/qcom/sdm630.dtsi | 18 +- > arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 4 + > arch/arm64/boot/dts/qcom/sm8450.dtsi | 24 +- > drivers/mmc/host/sdhci-msm.c | 252 ++---------------- > drivers/soc/qcom/Kconfig | 10 + > drivers/soc/qcom/Makefile | 1 + > .../ufs-qcom-ice.c => soc/qcom/qcom-ice.c} | 247 +++++++++++------ > drivers/ufs/host/Kconfig | 1 - > drivers/ufs/host/Makefile | 1 - > drivers/ufs/host/ufs-qcom.c | 42 ++- > drivers/ufs/host/ufs-qcom.h | 32 +-- > include/soc/qcom/ice.h | 61 +++++ > 12 files changed, 326 insertions(+), 367 deletions(-) > rename drivers/{ufs/host/ufs-qcom-ice.c => soc/qcom/qcom-ice.c} (50%) > create mode 100644 include/soc/qcom/ice.h > > -- > 2.34.1 >