From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Claudiu Beznea <claudiu.beznea@microchip.com>,
lgirdwood@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, perex@perex.cz,
tiwai@suse.com, nicolas.ferre@microchip.com,
alexandre.belloni@bootlin.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] ASoC: soc-generic-dmaengine-pcm: add option to start DMA after DAI
Date: Tue, 14 Feb 2023 21:26:05 +0000 [thread overview]
Message-ID: <Y+v8bbr4cNSOA1SF@sirena.org.uk> (raw)
In-Reply-To: <b065e2bb-1f11-067a-b085-45d47626927e@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
On Tue, Feb 14, 2023 at 10:14:28AM -0800, Lars-Peter Clausen wrote:
> On 2/14/23 08:14, Claudiu Beznea wrote:
> > @@ -450,6 +450,8 @@ int snd_dmaengine_pcm_register(struct device *dev,
> > else
> > driver = &dmaengine_pcm_component;
> > + driver->start_dma_last = config->start_dma_last;
> This will break if you have multiple sound cards in the system.
> dmaengine_pcm_component must stay const.
Right, if we need to modify it we either need to select which of
multiple const structs to register or to take a copy and modify
that. I've not looked at the actual changes yet.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-02-14 21:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 16:14 [PATCH 0/3] ASoC: mchp-pdmc: fix poc noises when starting capture Claudiu Beznea
2023-02-14 16:14 ` [PATCH 1/3] ASoC: soc-generic-dmaengine-pcm: add option to start DMA after DAI Claudiu Beznea
2023-02-14 18:14 ` Lars-Peter Clausen
2023-02-14 21:26 ` Mark Brown [this message]
2023-02-16 9:49 ` Claudiu.Beznea
2023-02-16 13:53 ` Lars-Peter Clausen
2023-02-17 10:59 ` Claudiu.Beznea
2023-02-14 16:14 ` [PATCH 2/3] ASoC: dt-bindings: sama7g5-pdmc: add microchip,startup-delay-us binding Claudiu Beznea
2023-02-16 10:04 ` Krzysztof Kozlowski
2023-02-16 10:15 ` Claudiu.Beznea
2023-02-16 10:18 ` Krzysztof Kozlowski
2023-02-16 10:41 ` Claudiu.Beznea
2023-02-16 10:43 ` Krzysztof Kozlowski
2023-02-16 14:46 ` Mark Brown
2023-02-14 16:14 ` [PATCH 3/3] ASoC: mchp-pdmc: fix poc noise at capture startup Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+v8bbr4cNSOA1SF@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=claudiu.beznea@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).