* [PATCH v4 0/3] Enable initial support for StarFive VisionFive V1 SBC
@ 2022-10-17 21:05 Cristian Ciocaltea
2022-10-17 21:05 ` [PATCH v4 1/3] dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board Cristian Ciocaltea
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Cristian Ciocaltea @ 2022-10-17 21:05 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Michael Zhu, Drew Fustini, Emil Renner Berthing,
Conor Dooley
Cc: devicetree, linux-riscv, linux-kernel, kernel
The StarFive VisionFive V1 SBC [1] is similar with the already supported
BeagleV Starlight Beta board, both being based on the StarFive JH7100 SoC.
In addition to documenting the necessary compatibles, this patch series
moves most of the content from jh7100-beaglev-starlight.dts to a new file
jh7100-common.dtsi, to be shared between the two boards.
No other changes are required in order to successfully boot the board.
[1] https://github.com/starfive-tech/VisionFive
Changes in v4:
- Rebased onto v6.1.0-rc1
- Fixed a conflict in patch 2/3 as pinctrl-starfive.h has been renamed
to pinctrl-starfive-jh7100.h
Changes in v3:
- Added Reviewed-by tag from Krzysztof in patch 1/3
- Optimized patch 2/3 by enabling copy detection on "git format-patch",
as indicated by Krzysztof
Changes in v2:
- Simplified documentation by using 'enum' instead of 'const' in
patch 1/3, according to Conor's review
- Added Reviewed-by tags from Conor
Cristian Ciocaltea (3):
dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board
riscv: dts: starfive: Add common DT for JH7100 based boards
riscv: dts: starfive: Add StarFive VisionFive V1 device tree
.../devicetree/bindings/riscv/starfive.yaml | 4 +-
arch/riscv/boot/dts/starfive/Makefile | 2 +-
.../dts/starfive/jh7100-beaglev-starlight.dts | 153 +-----------------
...aglev-starlight.dts => jh7100-common.dtsi} | 3 -
.../jh7100-starfive-visionfive-v1.dts | 20 +++
5 files changed, 25 insertions(+), 157 deletions(-)
copy arch/riscv/boot/dts/starfive/{jh7100-beaglev-starlight.dts => jh7100-common.dtsi} (96%)
create mode 100644 arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780
--
2.38.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v4 1/3] dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board
2022-10-17 21:05 [PATCH v4 0/3] Enable initial support for StarFive VisionFive V1 SBC Cristian Ciocaltea
@ 2022-10-17 21:05 ` Cristian Ciocaltea
2022-10-18 8:15 ` Matthias Brugger
2022-10-17 21:05 ` [PATCH v4 2/3] riscv: dts: starfive: Add common DT for JH7100 based boards Cristian Ciocaltea
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Cristian Ciocaltea @ 2022-10-17 21:05 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Michael Zhu, Drew Fustini, Emil Renner Berthing,
Conor Dooley
Cc: devicetree, linux-riscv, linux-kernel, kernel,
Krzysztof Kozlowski
Document the compatibles for StarFive VisionFive V1 SBC [1].
The board is based on the StarFive JH7100 SoC.
[1] https://github.com/starfive-tech/VisionFive
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/riscv/starfive.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml
index 5b36243fd674..5d3fcee52d59 100644
--- a/Documentation/devicetree/bindings/riscv/starfive.yaml
+++ b/Documentation/devicetree/bindings/riscv/starfive.yaml
@@ -19,7 +19,9 @@ properties:
compatible:
oneOf:
- items:
- - const: beagle,beaglev-starlight-jh7100-r0
+ - enum:
+ - beagle,beaglev-starlight-jh7100-r0
+ - starfive,visionfive-v1
- const: starfive,jh7100
additionalProperties: true
--
2.38.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v4 2/3] riscv: dts: starfive: Add common DT for JH7100 based boards
2022-10-17 21:05 [PATCH v4 0/3] Enable initial support for StarFive VisionFive V1 SBC Cristian Ciocaltea
2022-10-17 21:05 ` [PATCH v4 1/3] dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board Cristian Ciocaltea
@ 2022-10-17 21:05 ` Cristian Ciocaltea
2022-10-18 8:22 ` Matthias Brugger
2022-10-17 21:05 ` [PATCH v4 3/3] riscv: dts: starfive: Add StarFive VisionFive V1 device tree Cristian Ciocaltea
2022-11-16 17:50 ` [PATCH v4 0/3] Enable initial support for StarFive VisionFive V1 SBC Conor Dooley
3 siblings, 1 reply; 9+ messages in thread
From: Cristian Ciocaltea @ 2022-10-17 21:05 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Michael Zhu, Drew Fustini, Emil Renner Berthing,
Conor Dooley
Cc: devicetree, linux-riscv, linux-kernel, kernel
In preparation for adding initial device tree support for the StarFive
VisionFive board, which is similar with BeagleV Starlight, move most
of the content from jh7100-beaglev-starlight.dts to a new file, to be
shared between the two boards.
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
---
.../dts/starfive/jh7100-beaglev-starlight.dts | 153 +-----------------
...aglev-starlight.dts => jh7100-common.dtsi} | 3 -
2 files changed, 1 insertion(+), 155 deletions(-)
copy arch/riscv/boot/dts/starfive/{jh7100-beaglev-starlight.dts => jh7100-common.dtsi} (96%)
diff --git a/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts b/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts
index f7a230110512..7cda3a89020a 100644
--- a/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts
+++ b/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts
@@ -5,160 +5,9 @@
*/
/dts-v1/;
-#include "jh7100.dtsi"
-#include <dt-bindings/gpio/gpio.h>
-#include <dt-bindings/leds/common.h>
-#include <dt-bindings/pinctrl/pinctrl-starfive-jh7100.h>
+#include "jh7100-common.dtsi"
/ {
model = "BeagleV Starlight Beta";
compatible = "beagle,beaglev-starlight-jh7100-r0", "starfive,jh7100";
-
- aliases {
- serial0 = &uart3;
- };
-
- chosen {
- stdout-path = "serial0:115200n8";
- };
-
- cpus {
- timebase-frequency = <6250000>;
- };
-
- memory@80000000 {
- device_type = "memory";
- reg = <0x0 0x80000000 0x2 0x0>;
- };
-
- leds {
- compatible = "gpio-leds";
-
- led-ack {
- gpios = <&gpio 43 GPIO_ACTIVE_HIGH>;
- color = <LED_COLOR_ID_GREEN>;
- function = LED_FUNCTION_HEARTBEAT;
- linux,default-trigger = "heartbeat";
- label = "ack";
- };
- };
-};
-
-&gpio {
- i2c0_pins: i2c0-0 {
- i2c-pins {
- pinmux = <GPIOMUX(62, GPO_LOW,
- GPO_I2C0_PAD_SCK_OEN,
- GPI_I2C0_PAD_SCK_IN)>,
- <GPIOMUX(61, GPO_LOW,
- GPO_I2C0_PAD_SDA_OEN,
- GPI_I2C0_PAD_SDA_IN)>;
- bias-disable; /* external pull-up */
- input-enable;
- input-schmitt-enable;
- };
- };
-
- i2c1_pins: i2c1-0 {
- i2c-pins {
- pinmux = <GPIOMUX(47, GPO_LOW,
- GPO_I2C1_PAD_SCK_OEN,
- GPI_I2C1_PAD_SCK_IN)>,
- <GPIOMUX(48, GPO_LOW,
- GPO_I2C1_PAD_SDA_OEN,
- GPI_I2C1_PAD_SDA_IN)>;
- bias-pull-up;
- input-enable;
- input-schmitt-enable;
- };
- };
-
- i2c2_pins: i2c2-0 {
- i2c-pins {
- pinmux = <GPIOMUX(60, GPO_LOW,
- GPO_I2C2_PAD_SCK_OEN,
- GPI_I2C2_PAD_SCK_IN)>,
- <GPIOMUX(59, GPO_LOW,
- GPO_I2C2_PAD_SDA_OEN,
- GPI_I2C2_PAD_SDA_IN)>;
- bias-disable; /* external pull-up */
- input-enable;
- input-schmitt-enable;
- };
- };
-
- uart3_pins: uart3-0 {
- rx-pins {
- pinmux = <GPIOMUX(13, GPO_LOW, GPO_DISABLE,
- GPI_UART3_PAD_SIN)>;
- bias-pull-up;
- drive-strength = <14>;
- input-enable;
- input-schmitt-enable;
- slew-rate = <0>;
- };
- tx-pins {
- pinmux = <GPIOMUX(14, GPO_UART3_PAD_SOUT,
- GPO_ENABLE, GPI_NONE)>;
- bias-disable;
- drive-strength = <35>;
- input-disable;
- input-schmitt-disable;
- slew-rate = <0>;
- };
- };
-};
-
-&i2c0 {
- clock-frequency = <100000>;
- i2c-sda-hold-time-ns = <300>;
- i2c-sda-falling-time-ns = <500>;
- i2c-scl-falling-time-ns = <500>;
- pinctrl-names = "default";
- pinctrl-0 = <&i2c0_pins>;
- status = "okay";
-
- pmic@5e {
- compatible = "ti,tps65086";
- reg = <0x5e>;
- gpio-controller;
- #gpio-cells = <2>;
-
- regulators {
- };
- };
-};
-
-&i2c1 {
- clock-frequency = <400000>;
- i2c-sda-hold-time-ns = <300>;
- i2c-sda-falling-time-ns = <100>;
- i2c-scl-falling-time-ns = <100>;
- pinctrl-names = "default";
- pinctrl-0 = <&i2c1_pins>;
- status = "okay";
-};
-
-&i2c2 {
- clock-frequency = <100000>;
- i2c-sda-hold-time-ns = <300>;
- i2c-sda-falling-time-ns = <500>;
- i2c-scl-falling-time-ns = <500>;
- pinctrl-names = "default";
- pinctrl-0 = <&i2c2_pins>;
- status = "okay";
-};
-
-&osc_sys {
- clock-frequency = <25000000>;
-};
-
-&osc_aud {
- clock-frequency = <27000000>;
-};
-
-&uart3 {
- pinctrl-names = "default";
- pinctrl-0 = <&uart3_pins>;
- status = "okay";
};
diff --git a/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts b/arch/riscv/boot/dts/starfive/jh7100-common.dtsi
similarity index 96%
copy from arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts
copy to arch/riscv/boot/dts/starfive/jh7100-common.dtsi
index f7a230110512..b93ce351a90f 100644
--- a/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts
+++ b/arch/riscv/boot/dts/starfive/jh7100-common.dtsi
@@ -11,9 +11,6 @@
#include <dt-bindings/pinctrl/pinctrl-starfive-jh7100.h>
/ {
- model = "BeagleV Starlight Beta";
- compatible = "beagle,beaglev-starlight-jh7100-r0", "starfive,jh7100";
-
aliases {
serial0 = &uart3;
};
--
2.38.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v4 3/3] riscv: dts: starfive: Add StarFive VisionFive V1 device tree
2022-10-17 21:05 [PATCH v4 0/3] Enable initial support for StarFive VisionFive V1 SBC Cristian Ciocaltea
2022-10-17 21:05 ` [PATCH v4 1/3] dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board Cristian Ciocaltea
2022-10-17 21:05 ` [PATCH v4 2/3] riscv: dts: starfive: Add common DT for JH7100 based boards Cristian Ciocaltea
@ 2022-10-17 21:05 ` Cristian Ciocaltea
2022-10-18 8:26 ` Matthias Brugger
2022-11-16 17:50 ` [PATCH v4 0/3] Enable initial support for StarFive VisionFive V1 SBC Conor Dooley
3 siblings, 1 reply; 9+ messages in thread
From: Cristian Ciocaltea @ 2022-10-17 21:05 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Michael Zhu, Drew Fustini, Emil Renner Berthing,
Conor Dooley
Cc: devicetree, linux-riscv, linux-kernel, kernel
Add initial device tree for the StarFive VisionFive V1 SBC [1], which
is similar with the already supported BeagleV Starlight Beta board,
both being based on the StarFive JH7100 SoC.
[1] https://github.com/starfive-tech/VisionFive
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
---
arch/riscv/boot/dts/starfive/Makefile | 2 +-
.../jh7100-starfive-visionfive-v1.dts | 20 +++++++++++++++++++
2 files changed, 21 insertions(+), 1 deletion(-)
create mode 100644 arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
diff --git a/arch/riscv/boot/dts/starfive/Makefile b/arch/riscv/boot/dts/starfive/Makefile
index 0ea1bc15ab30..039c143cba33 100644
--- a/arch/riscv/boot/dts/starfive/Makefile
+++ b/arch/riscv/boot/dts/starfive/Makefile
@@ -1,2 +1,2 @@
# SPDX-License-Identifier: GPL-2.0
-dtb-$(CONFIG_SOC_STARFIVE) += jh7100-beaglev-starlight.dtb
+dtb-$(CONFIG_SOC_STARFIVE) += jh7100-beaglev-starlight.dtb jh7100-starfive-visionfive-v1.dtb
diff --git a/arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts b/arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
new file mode 100644
index 000000000000..e82af72f1aaf
--- /dev/null
+++ b/arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
@@ -0,0 +1,20 @@
+// SPDX-License-Identifier: GPL-2.0 OR MIT
+/*
+ * Copyright (C) 2021 StarFive Technology Co., Ltd.
+ * Copyright (C) 2021 Emil Renner Berthing <kernel@esmil.dk>
+ */
+
+/dts-v1/;
+#include "jh7100-common.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+
+/ {
+ model = "StarFive VisionFive V1";
+ compatible = "starfive,visionfive-v1", "starfive,jh7100";
+
+ gpio-restart {
+ compatible = "gpio-restart";
+ gpios = <&gpio 63 GPIO_ACTIVE_HIGH>;
+ priority = <224>;
+ };
+};
--
2.38.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v4 1/3] dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board
2022-10-17 21:05 ` [PATCH v4 1/3] dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board Cristian Ciocaltea
@ 2022-10-18 8:15 ` Matthias Brugger
0 siblings, 0 replies; 9+ messages in thread
From: Matthias Brugger @ 2022-10-18 8:15 UTC (permalink / raw)
To: Cristian Ciocaltea
Cc: Rob Herring, Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Michael Zhu, Drew Fustini, Emil Renner Berthing,
Conor Dooley, devicetree, linux-riscv, linux-kernel, kernel,
Krzysztof Kozlowski
On Tue, Oct 18, 2022 at 12:05:40AM +0300, Cristian Ciocaltea wrote:
> Document the compatibles for StarFive VisionFive V1 SBC [1].
> The board is based on the StarFive JH7100 SoC.
>
> [1] https://github.com/starfive-tech/VisionFive
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Matthias Brugger <mbrugger@suse.com>
> ---
> Documentation/devicetree/bindings/riscv/starfive.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml
> index 5b36243fd674..5d3fcee52d59 100644
> --- a/Documentation/devicetree/bindings/riscv/starfive.yaml
> +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml
> @@ -19,7 +19,9 @@ properties:
> compatible:
> oneOf:
> - items:
> - - const: beagle,beaglev-starlight-jh7100-r0
> + - enum:
> + - beagle,beaglev-starlight-jh7100-r0
> + - starfive,visionfive-v1
> - const: starfive,jh7100
>
> additionalProperties: true
> --
> 2.38.0
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 2/3] riscv: dts: starfive: Add common DT for JH7100 based boards
2022-10-17 21:05 ` [PATCH v4 2/3] riscv: dts: starfive: Add common DT for JH7100 based boards Cristian Ciocaltea
@ 2022-10-18 8:22 ` Matthias Brugger
0 siblings, 0 replies; 9+ messages in thread
From: Matthias Brugger @ 2022-10-18 8:22 UTC (permalink / raw)
To: Cristian Ciocaltea
Cc: Rob Herring, Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Michael Zhu, Drew Fustini, Emil Renner Berthing,
Conor Dooley, devicetree, linux-riscv, linux-kernel, kernel
On Tue, Oct 18, 2022 at 12:05:41AM +0300, Cristian Ciocaltea wrote:
> In preparation for adding initial device tree support for the StarFive
> VisionFive board, which is similar with BeagleV Starlight, move most
> of the content from jh7100-beaglev-starlight.dts to a new file, to be
> shared between the two boards.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Matthias Brugger <mbrugger@suse.com>
> ---
> .../dts/starfive/jh7100-beaglev-starlight.dts | 153 +-----------------
> ...aglev-starlight.dts => jh7100-common.dtsi} | 3 -
> 2 files changed, 1 insertion(+), 155 deletions(-)
> copy arch/riscv/boot/dts/starfive/{jh7100-beaglev-starlight.dts => jh7100-common.dtsi} (96%)
>
> diff --git a/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts b/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts
> index f7a230110512..7cda3a89020a 100644
> --- a/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts
> +++ b/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts
> @@ -5,160 +5,9 @@
> */
>
> /dts-v1/;
> -#include "jh7100.dtsi"
> -#include <dt-bindings/gpio/gpio.h>
> -#include <dt-bindings/leds/common.h>
> -#include <dt-bindings/pinctrl/pinctrl-starfive-jh7100.h>
> +#include "jh7100-common.dtsi"
>
> / {
> model = "BeagleV Starlight Beta";
> compatible = "beagle,beaglev-starlight-jh7100-r0", "starfive,jh7100";
> -
> - aliases {
> - serial0 = &uart3;
> - };
> -
> - chosen {
> - stdout-path = "serial0:115200n8";
> - };
> -
> - cpus {
> - timebase-frequency = <6250000>;
> - };
> -
> - memory@80000000 {
> - device_type = "memory";
> - reg = <0x0 0x80000000 0x2 0x0>;
> - };
> -
> - leds {
> - compatible = "gpio-leds";
> -
> - led-ack {
> - gpios = <&gpio 43 GPIO_ACTIVE_HIGH>;
> - color = <LED_COLOR_ID_GREEN>;
> - function = LED_FUNCTION_HEARTBEAT;
> - linux,default-trigger = "heartbeat";
> - label = "ack";
> - };
> - };
> -};
> -
> -&gpio {
> - i2c0_pins: i2c0-0 {
> - i2c-pins {
> - pinmux = <GPIOMUX(62, GPO_LOW,
> - GPO_I2C0_PAD_SCK_OEN,
> - GPI_I2C0_PAD_SCK_IN)>,
> - <GPIOMUX(61, GPO_LOW,
> - GPO_I2C0_PAD_SDA_OEN,
> - GPI_I2C0_PAD_SDA_IN)>;
> - bias-disable; /* external pull-up */
> - input-enable;
> - input-schmitt-enable;
> - };
> - };
> -
> - i2c1_pins: i2c1-0 {
> - i2c-pins {
> - pinmux = <GPIOMUX(47, GPO_LOW,
> - GPO_I2C1_PAD_SCK_OEN,
> - GPI_I2C1_PAD_SCK_IN)>,
> - <GPIOMUX(48, GPO_LOW,
> - GPO_I2C1_PAD_SDA_OEN,
> - GPI_I2C1_PAD_SDA_IN)>;
> - bias-pull-up;
> - input-enable;
> - input-schmitt-enable;
> - };
> - };
> -
> - i2c2_pins: i2c2-0 {
> - i2c-pins {
> - pinmux = <GPIOMUX(60, GPO_LOW,
> - GPO_I2C2_PAD_SCK_OEN,
> - GPI_I2C2_PAD_SCK_IN)>,
> - <GPIOMUX(59, GPO_LOW,
> - GPO_I2C2_PAD_SDA_OEN,
> - GPI_I2C2_PAD_SDA_IN)>;
> - bias-disable; /* external pull-up */
> - input-enable;
> - input-schmitt-enable;
> - };
> - };
> -
> - uart3_pins: uart3-0 {
> - rx-pins {
> - pinmux = <GPIOMUX(13, GPO_LOW, GPO_DISABLE,
> - GPI_UART3_PAD_SIN)>;
> - bias-pull-up;
> - drive-strength = <14>;
> - input-enable;
> - input-schmitt-enable;
> - slew-rate = <0>;
> - };
> - tx-pins {
> - pinmux = <GPIOMUX(14, GPO_UART3_PAD_SOUT,
> - GPO_ENABLE, GPI_NONE)>;
> - bias-disable;
> - drive-strength = <35>;
> - input-disable;
> - input-schmitt-disable;
> - slew-rate = <0>;
> - };
> - };
> -};
> -
> -&i2c0 {
> - clock-frequency = <100000>;
> - i2c-sda-hold-time-ns = <300>;
> - i2c-sda-falling-time-ns = <500>;
> - i2c-scl-falling-time-ns = <500>;
> - pinctrl-names = "default";
> - pinctrl-0 = <&i2c0_pins>;
> - status = "okay";
> -
> - pmic@5e {
> - compatible = "ti,tps65086";
> - reg = <0x5e>;
> - gpio-controller;
> - #gpio-cells = <2>;
> -
> - regulators {
> - };
> - };
> -};
> -
> -&i2c1 {
> - clock-frequency = <400000>;
> - i2c-sda-hold-time-ns = <300>;
> - i2c-sda-falling-time-ns = <100>;
> - i2c-scl-falling-time-ns = <100>;
> - pinctrl-names = "default";
> - pinctrl-0 = <&i2c1_pins>;
> - status = "okay";
> -};
> -
> -&i2c2 {
> - clock-frequency = <100000>;
> - i2c-sda-hold-time-ns = <300>;
> - i2c-sda-falling-time-ns = <500>;
> - i2c-scl-falling-time-ns = <500>;
> - pinctrl-names = "default";
> - pinctrl-0 = <&i2c2_pins>;
> - status = "okay";
> -};
> -
> -&osc_sys {
> - clock-frequency = <25000000>;
> -};
> -
> -&osc_aud {
> - clock-frequency = <27000000>;
> -};
> -
> -&uart3 {
> - pinctrl-names = "default";
> - pinctrl-0 = <&uart3_pins>;
> - status = "okay";
> };
> diff --git a/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts b/arch/riscv/boot/dts/starfive/jh7100-common.dtsi
> similarity index 96%
> copy from arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts
> copy to arch/riscv/boot/dts/starfive/jh7100-common.dtsi
> index f7a230110512..b93ce351a90f 100644
> --- a/arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dts
> +++ b/arch/riscv/boot/dts/starfive/jh7100-common.dtsi
> @@ -11,9 +11,6 @@
> #include <dt-bindings/pinctrl/pinctrl-starfive-jh7100.h>
>
> / {
> - model = "BeagleV Starlight Beta";
> - compatible = "beagle,beaglev-starlight-jh7100-r0", "starfive,jh7100";
> -
> aliases {
> serial0 = &uart3;
> };
> --
> 2.38.0
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 3/3] riscv: dts: starfive: Add StarFive VisionFive V1 device tree
2022-10-17 21:05 ` [PATCH v4 3/3] riscv: dts: starfive: Add StarFive VisionFive V1 device tree Cristian Ciocaltea
@ 2022-10-18 8:26 ` Matthias Brugger
0 siblings, 0 replies; 9+ messages in thread
From: Matthias Brugger @ 2022-10-18 8:26 UTC (permalink / raw)
To: Cristian Ciocaltea
Cc: Rob Herring, Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Michael Zhu, Drew Fustini, Emil Renner Berthing,
Conor Dooley, devicetree, linux-riscv, linux-kernel, kernel
On Tue, Oct 18, 2022 at 12:05:42AM +0300, Cristian Ciocaltea wrote:
> Add initial device tree for the StarFive VisionFive V1 SBC [1], which
> is similar with the already supported BeagleV Starlight Beta board,
> both being based on the StarFive JH7100 SoC.
>
> [1] https://github.com/starfive-tech/VisionFive
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Matthias Brugger <mbrugger@suse.com>
> ---
> arch/riscv/boot/dts/starfive/Makefile | 2 +-
> .../jh7100-starfive-visionfive-v1.dts | 20 +++++++++++++++++++
> 2 files changed, 21 insertions(+), 1 deletion(-)
> create mode 100644 arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
>
> diff --git a/arch/riscv/boot/dts/starfive/Makefile b/arch/riscv/boot/dts/starfive/Makefile
> index 0ea1bc15ab30..039c143cba33 100644
> --- a/arch/riscv/boot/dts/starfive/Makefile
> +++ b/arch/riscv/boot/dts/starfive/Makefile
> @@ -1,2 +1,2 @@
> # SPDX-License-Identifier: GPL-2.0
> -dtb-$(CONFIG_SOC_STARFIVE) += jh7100-beaglev-starlight.dtb
> +dtb-$(CONFIG_SOC_STARFIVE) += jh7100-beaglev-starlight.dtb jh7100-starfive-visionfive-v1.dtb
> diff --git a/arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts b/arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
> new file mode 100644
> index 000000000000..e82af72f1aaf
> --- /dev/null
> +++ b/arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
> @@ -0,0 +1,20 @@
> +// SPDX-License-Identifier: GPL-2.0 OR MIT
> +/*
> + * Copyright (C) 2021 StarFive Technology Co., Ltd.
> + * Copyright (C) 2021 Emil Renner Berthing <kernel@esmil.dk>
> + */
> +
> +/dts-v1/;
> +#include "jh7100-common.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/ {
> + model = "StarFive VisionFive V1";
> + compatible = "starfive,visionfive-v1", "starfive,jh7100";
> +
> + gpio-restart {
> + compatible = "gpio-restart";
> + gpios = <&gpio 63 GPIO_ACTIVE_HIGH>;
> + priority = <224>;
> + };
> +};
> --
> 2.38.0
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 0/3] Enable initial support for StarFive VisionFive V1 SBC
2022-10-17 21:05 [PATCH v4 0/3] Enable initial support for StarFive VisionFive V1 SBC Cristian Ciocaltea
` (2 preceding siblings ...)
2022-10-17 21:05 ` [PATCH v4 3/3] riscv: dts: starfive: Add StarFive VisionFive V1 device tree Cristian Ciocaltea
@ 2022-11-16 17:50 ` Conor Dooley
2022-11-16 21:04 ` Cristian Ciocaltea
3 siblings, 1 reply; 9+ messages in thread
From: Conor Dooley @ 2022-11-16 17:50 UTC (permalink / raw)
To: Cristian Ciocaltea
Cc: Rob Herring, Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Michael Zhu, Drew Fustini, Emil Renner Berthing,
Conor Dooley, devicetree, linux-riscv, linux-kernel, kernel
On Tue, Oct 18, 2022 at 12:05:39AM +0300, Cristian Ciocaltea wrote:
> The StarFive VisionFive V1 SBC [1] is similar with the already supported
> BeagleV Starlight Beta board, both being based on the StarFive JH7100 SoC.
>
> In addition to documenting the necessary compatibles, this patch series
> moves most of the content from jh7100-beaglev-starlight.dts to a new file
> jh7100-common.dtsi, to be shared between the two boards.
>
> No other changes are required in order to successfully boot the board.
>
> [1] https://github.com/starfive-tech/VisionFive
Hey Cristian,
Apologies for the delay here, we've been sorting out re-routing RISC-V
DT stuff via the SoC tree. That should be sorted now, so I have picked
the series up. Should be at:
https://git.kernel.org/conor/c/a3fe69160c7328a284ebc711ccb689f3beec42dc
Thanks,
Conor.
>
> Changes in v4:
> - Rebased onto v6.1.0-rc1
> - Fixed a conflict in patch 2/3 as pinctrl-starfive.h has been renamed
> to pinctrl-starfive-jh7100.h
>
> Changes in v3:
> - Added Reviewed-by tag from Krzysztof in patch 1/3
> - Optimized patch 2/3 by enabling copy detection on "git format-patch",
> as indicated by Krzysztof
>
> Changes in v2:
> - Simplified documentation by using 'enum' instead of 'const' in
> patch 1/3, according to Conor's review
> - Added Reviewed-by tags from Conor
>
> Cristian Ciocaltea (3):
> dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board
> riscv: dts: starfive: Add common DT for JH7100 based boards
> riscv: dts: starfive: Add StarFive VisionFive V1 device tree
>
> .../devicetree/bindings/riscv/starfive.yaml | 4 +-
> arch/riscv/boot/dts/starfive/Makefile | 2 +-
> .../dts/starfive/jh7100-beaglev-starlight.dts | 153 +-----------------
> ...aglev-starlight.dts => jh7100-common.dtsi} | 3 -
> .../jh7100-starfive-visionfive-v1.dts | 20 +++
> 5 files changed, 25 insertions(+), 157 deletions(-)
> copy arch/riscv/boot/dts/starfive/{jh7100-beaglev-starlight.dts => jh7100-common.dtsi} (96%)
> create mode 100644 arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
>
>
> base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780
> --
> 2.38.0
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 0/3] Enable initial support for StarFive VisionFive V1 SBC
2022-11-16 17:50 ` [PATCH v4 0/3] Enable initial support for StarFive VisionFive V1 SBC Conor Dooley
@ 2022-11-16 21:04 ` Cristian Ciocaltea
0 siblings, 0 replies; 9+ messages in thread
From: Cristian Ciocaltea @ 2022-11-16 21:04 UTC (permalink / raw)
To: Conor Dooley
Cc: Rob Herring, Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Michael Zhu, Drew Fustini, Emil Renner Berthing,
Conor Dooley, devicetree, linux-riscv, linux-kernel, kernel
On 11/16/22 19:50, Conor Dooley wrote:
> On Tue, Oct 18, 2022 at 12:05:39AM +0300, Cristian Ciocaltea wrote:
>> The StarFive VisionFive V1 SBC [1] is similar with the already supported
>> BeagleV Starlight Beta board, both being based on the StarFive JH7100 SoC.
>>
>> In addition to documenting the necessary compatibles, this patch series
>> moves most of the content from jh7100-beaglev-starlight.dts to a new file
>> jh7100-common.dtsi, to be shared between the two boards.
>>
>> No other changes are required in order to successfully boot the board.
>>
>> [1] https://github.com/starfive-tech/VisionFive
>
> Hey Cristian,
>
> Apologies for the delay here, we've been sorting out re-routing RISC-V
> DT stuff via the SoC tree. That should be sorted now, so I have picked
> the series up. Should be at:
> https://git.kernel.org/conor/c/a3fe69160c7328a284ebc711ccb689f3beec42dc
Hi Conor,
No problem, thanks for taking care of this!
Regards,
Cristian
> Thanks,
> Conor.
>
>>
>> Changes in v4:
>> - Rebased onto v6.1.0-rc1
>> - Fixed a conflict in patch 2/3 as pinctrl-starfive.h has been renamed
>> to pinctrl-starfive-jh7100.h
>>
>> Changes in v3:
>> - Added Reviewed-by tag from Krzysztof in patch 1/3
>> - Optimized patch 2/3 by enabling copy detection on "git format-patch",
>> as indicated by Krzysztof
>>
>> Changes in v2:
>> - Simplified documentation by using 'enum' instead of 'const' in
>> patch 1/3, according to Conor's review
>> - Added Reviewed-by tags from Conor
>>
>> Cristian Ciocaltea (3):
>> dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board
>> riscv: dts: starfive: Add common DT for JH7100 based boards
>> riscv: dts: starfive: Add StarFive VisionFive V1 device tree
>>
>> .../devicetree/bindings/riscv/starfive.yaml | 4 +-
>> arch/riscv/boot/dts/starfive/Makefile | 2 +-
>> .../dts/starfive/jh7100-beaglev-starlight.dts | 153 +-----------------
>> ...aglev-starlight.dts => jh7100-common.dtsi} | 3 -
>> .../jh7100-starfive-visionfive-v1.dts | 20 +++
>> 5 files changed, 25 insertions(+), 157 deletions(-)
>> copy arch/riscv/boot/dts/starfive/{jh7100-beaglev-starlight.dts => jh7100-common.dtsi} (96%)
>> create mode 100644 arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
>>
>>
>> base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780
>> --
>> 2.38.0
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-11-16 21:05 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-17 21:05 [PATCH v4 0/3] Enable initial support for StarFive VisionFive V1 SBC Cristian Ciocaltea
2022-10-17 21:05 ` [PATCH v4 1/3] dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board Cristian Ciocaltea
2022-10-18 8:15 ` Matthias Brugger
2022-10-17 21:05 ` [PATCH v4 2/3] riscv: dts: starfive: Add common DT for JH7100 based boards Cristian Ciocaltea
2022-10-18 8:22 ` Matthias Brugger
2022-10-17 21:05 ` [PATCH v4 3/3] riscv: dts: starfive: Add StarFive VisionFive V1 device tree Cristian Ciocaltea
2022-10-18 8:26 ` Matthias Brugger
2022-11-16 17:50 ` [PATCH v4 0/3] Enable initial support for StarFive VisionFive V1 SBC Conor Dooley
2022-11-16 21:04 ` Cristian Ciocaltea
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).