From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Dan Scally <dan.scally@ideasonboard.com>
Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>,
devicetree@vger.kernel.org, krzysztof.kozlowski@linaro.org,
leoyang.li@nxp.com, linux-arm-kernel@lists.infradead.org,
marcel.ziswiler@toradex.com, robh@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
debix-tech@polyhex.net
Subject: Re: [PATCH v2 2/3] dt-bindings: arm: fsl: Enumerate Debix Model A Board
Date: Mon, 10 Oct 2022 17:06:14 +0300 [thread overview]
Message-ID: <Y0Qm1qMyM40ud1KF@pendragon.ideasonboard.com> (raw)
In-Reply-To: <7a7699fd-d8aa-3657-eefc-16bac57ff444@ideasonboard.com>
On Mon, Oct 10, 2022 at 02:57:35PM +0100, Dan Scally wrote:
> On 10/10/2022 14:56, Kieran Bingham wrote:
> > Quoting Daniel Scally (2022-10-10 14:31:45)
> >> Add an entry to the list of imx8mp boards denoting the Debix Model A
> >> board from Polyhex Technology Co.
> >>
> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> >> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
> >> ---
> >> Changes in v2:
> >>
> >> - Dropped 2gb suffix, added hyphens for readability (Laurent)
> >>
> >> Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> >> index 7431579ab0e8..fc0c8eb15114 100644
> >> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> >> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> >> @@ -931,6 +931,7 @@ properties:
> >> - dh,imx8mp-dhcom-pdk2 # i.MX8MP DHCOM SoM on PDK2 board
> >> - fsl,imx8mp-evk # i.MX8MP EVK Board
> >> - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board
> >> + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A (2GB) Board
> >
> > If we've dropped the 2gb suffix from the compatible string, does that
> > mean we should drop it from the description too? I presume the
> > implication is that we can support different sizes from the same compat
> > string.
>
> Argh! Yes, my bad - I'll fix that.
What that change,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >> - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules
> >> - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT
> >> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-10-10 14:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 13:31 [PATCH v2 0/3] Debix Model A board devicetree Daniel Scally
2022-10-10 13:31 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add Polyhex Technology Co Daniel Scally
2022-10-10 13:31 ` [PATCH v2 2/3] dt-bindings: arm: fsl: Enumerate Debix Model A Board Daniel Scally
2022-10-10 13:56 ` Kieran Bingham
2022-10-10 13:57 ` Dan Scally
2022-10-10 14:06 ` Laurent Pinchart [this message]
2022-10-10 13:31 ` [PATCH v2 3/3] arm64: dts: Add device tree for the " Daniel Scally
2022-10-10 14:18 ` Laurent Pinchart
2022-10-10 13:49 ` [PATCH v2 0/3] Debix Model A board devicetree Marc Kleine-Budde
2022-10-10 13:57 ` Laurent Pinchart
2022-10-11 6:43 ` Marc Kleine-Budde
2022-10-12 10:22 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0Qm1qMyM40ud1KF@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=dan.scally@ideasonboard.com \
--cc=debix-tech@polyhex.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kieran.bingham@ideasonboard.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=marcel.ziswiler@toradex.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox