[PATCH] dt-bindings: memory: renesas,rpc-if: Document R-Car V4H support

[PATCH] dt-bindings: memory: renesas,rpc-if: Document R-Car V4H support

[Geert Uytterhoeven]

From: Hai Pham <hai.pham.ud@renesas.com>

Document support for the SPI Multi I/O Bus Controller (RPC-IF) in the
R-Car V4H SoC.

Signed-off-by: Hai Pham <hai.pham.ud@renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 .../bindings/memory-controllers/renesas,rpc-if.yaml          | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
index 645249ea21d19cd9..30a403b1b79a2c73 100644
--- a/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml
@@ -42,6 +42,11 @@ properties:
               - renesas,r8a779a0-rpc-if       # R-Car V3U
           - const: renesas,rcar-gen3-rpc-if   # a generic R-Car gen3 or RZ/G2{E,H,M,N} device
 
+      - items:
+          - enum:
+              - renesas,r8a779g0-rpc-if       # R-Car V4H
+          - const: renesas,rcar-gen4-rpc-if   # a generic R-Car gen4 device
+
       - items:
           - enum:
               - renesas,r9a07g043-rpc-if      # RZ/G2UL
-- 
2.25.1

Re: [PATCH] dt-bindings: memory: renesas,rpc-if: Document R-Car V4H support

[Rob Herring]

On Wed, 12 Oct 2022 15:51:46 +0200, Geert Uytterhoeven wrote:
> From: Hai Pham <hai.pham.ud@renesas.com>
> 
> Document support for the SPI Multi I/O Bus Controller (RPC-IF) in the
> R-Car V4H SoC.
> 
> Signed-off-by: Hai Pham <hai.pham.ud@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  .../bindings/memory-controllers/renesas,rpc-if.yaml          | 5 +++++
>  1 file changed, 5 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH] dt-bindings: memory: renesas,rpc-if: Document R-Car V4H support

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

On Wed, Oct 12, 2022 at 03:51:46PM +0200, Geert Uytterhoeven wrote:
> From: Hai Pham <hai.pham.ud@renesas.com>
> 
> Document support for the SPI Multi I/O Bus Controller (RPC-IF) in the
> R-Car V4H SoC.
> 
> Signed-off-by: Hai Pham <hai.pham.ud@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

What about moving V3U to the new Gen4 section?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] dt-bindings: memory: renesas,rpc-if: Document R-Car V4H support

[Geert Uytterhoeven]

Hi Wolfram,

On Wed, Oct 12, 2022 at 9:04 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> On Wed, Oct 12, 2022 at 03:51:46PM +0200, Geert Uytterhoeven wrote:
> > From: Hai Pham <hai.pham.ud@renesas.com>
> >
> > Document support for the SPI Multi I/O Bus Controller (RPC-IF) in the
> > R-Car V4H SoC.
> >
> > Signed-off-by: Hai Pham <hai.pham.ud@renesas.com>
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks!

> What about moving V3U to the new Gen4 section?

I actually wrote such a patch a while back.
However, I didn't send it after discovering the R-Car V3U Series
User’s Manual Rev. 0.50 does not mention the fourth Strobe Timing
Adjustment bit (STRTIM) in the RPC-IF PHY Control Register (PHYCNT),
which is present on R-Car S4-8 and V4H, but not on R-Car Gen3.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] dt-bindings: memory: renesas,rpc-if: Document R-Car V4H support

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]


> I actually wrote such a patch a while back.
> However, I didn't send it after discovering the R-Car V3U Series
> User’s Manual Rev. 0.50 does not mention the fourth Strobe Timing
> Adjustment bit (STRTIM) in the RPC-IF PHY Control Register (PHYCNT),
> which is present on R-Car S4-8 and V4H, but not on R-Car Gen3.

I see. Thanks for the heads up! Maybe this is worth a comment because it
is an exception to the usual behaviour?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] dt-bindings: memory: renesas,rpc-if: Document R-Car V4H support

[Geert Uytterhoeven]

Hi Wolfram,

On Thu, Oct 13, 2022 at 10:00 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> > I actually wrote such a patch a while back.
> > However, I didn't send it after discovering the R-Car V3U Series
> > User’s Manual Rev. 0.50 does not mention the fourth Strobe Timing
> > Adjustment bit (STRTIM) in the RPC-IF PHY Control Register (PHYCNT),
> > which is present on R-Car S4-8 and V4H, but not on R-Car Gen3.
>
> I see. Thanks for the heads up! Maybe this is worth a comment because it
> is an exception to the usual behaviour?

You mean an exception to the exception to the usual behaviour that
R-Car <foo>3 is part of the R-Car Gen3 family, making it the normal
rule? ;-)

We're actually not 100% sure the bit is present or not.  Rev. 0.50 is
still an early revision of the R-Car V3U documentation, so it might lack
some updates.  I tried changing all bits of the PHYCNT register, but
unfortunately all bits except for bit 31 stick on all SoCs I tried, so
we can't use this method to determine which bits exist and which don't.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] dt-bindings: memory: renesas,rpc-if: Document R-Car V4H support

[Krzysztof Kozlowski]

On Wed, 12 Oct 2022 15:51:46 +0200, Geert Uytterhoeven wrote:
> From: Hai Pham <hai.pham.ud@renesas.com>
> 
> Document support for the SPI Multi I/O Bus Controller (RPC-IF) in the
> R-Car V4H SoC.
> 
> 

Applied, thanks!

[1/1] dt-bindings: memory: renesas,rpc-if: Document R-Car V4H support
      https://git.kernel.org/krzk/linux-mem-ctrl/c/fad9489abf932ff01ca2b9a9bf41a11311bdc8d5

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>