From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Sergei Shtylyov <sergei.shtylyov@gmail.com>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Cong Dang <cong.dang.xn@renesas.com>,
Hai Pham <hai.pham.ud@renesas.com>
Subject: Re: [PATCH 1/2] memory: renesas-rpc-if: Clear HS bit during hardware initialization
Date: Thu, 13 Oct 2022 14:01:03 +0200 [thread overview]
Message-ID: <Y0f9/9mcYpXG8Irf@shikoro> (raw)
In-Reply-To: <08d9fb10b3051decebf871267a6e2e7cb2d4faf9.1665583089.git.geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On Wed, Oct 12, 2022 at 04:01:51PM +0200, Geert Uytterhoeven wrote:
> From: Cong Dang <cong.dang.xn@renesas.com>
>
> According to the datasheet, HS bit should be specified to 1 when using
> DMA transfer. As DMA transfer is not supported, it should be cleared to
> 0.
>
> Previously, the driver relied on the HS bit being cleared by prior
> firmware but this is not always the case.
>
> Fix this by ensuring the bit is cleared during hardware initialization.
>
> Fixes: ca7d8b980b67f133 ("memory: add Renesas RPC-IF driver")
> Signed-off-by: Cong Dang <cong.dang.xn@renesas.com>
> Signed-off-by: Hai Pham <hai.pham.ud@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-10-13 12:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 14:01 [PATCH 0/2] memory: renesas-rpc-if: Add support for R-Car Gen4 Geert Uytterhoeven
2022-10-12 14:01 ` [PATCH 1/2] memory: renesas-rpc-if: Clear HS bit during hardware initialization Geert Uytterhoeven
2022-10-13 12:01 ` Wolfram Sang [this message]
2022-10-12 14:01 ` [PATCH 2/2] memory: renesas-rpc-if: Add support for R-Car Gen4 Geert Uytterhoeven
2022-10-13 12:11 ` Wolfram Sang
2022-10-18 15:10 ` [PATCH 0/2] " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0f9/9mcYpXG8Irf@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=cong.dang.xn@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=hai.pham.ud@renesas.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox