From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B03A8C4332F for ; Sat, 15 Oct 2022 18:48:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229554AbiJOSsN (ORCPT ); Sat, 15 Oct 2022 14:48:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229463AbiJOSsN (ORCPT ); Sat, 15 Oct 2022 14:48:13 -0400 Received: from hall.aurel32.net (hall.aurel32.net [IPv6:2001:bc8:30d7:100::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB4C442AD6; Sat, 15 Oct 2022 11:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Content-Transfer-Encoding:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=udmaLLcNhRHnKTv61FxpOiYd0OSEhIFGaRKc/ocnt9s=; b=XwZJSMysrFPcABiCKKHg8P3A26 YH7mmKg7rvv3fsw7CbSyvSC4nY5k9V9gFJ/Gvn9Ft/P2qYYq2F4Sry9idioEVKyAHx7h72UEzDjY1 4p7Iee9kTxF1sqmEn6PKF2AuSAFDWl1wG5m21l/D183qJCw9ZzlIRIpgYvtm3+DK2OuTDFdm1laYc ROMPVYGhYLMCWjFjgT04fVxRI6DISLvFAjocpEnblcookK8cXfOP/kzOLs45lYvf3Ar26XIy95H7d Y6AXByEwGE5cXIvYkkgohBFDuFbgz707Ir/zym7q7yMi/Fv6SBP6xS2sFWPDkjvRDLJsaJd6nYybw ebOHnzYg==; Received: from [2a01:e34:ec5d:a741:8a4c:7c4e:dc4c:1787] (helo=ohm.rr44.fr) by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ojmCV-007BlU-1r; Sat, 15 Oct 2022 20:47:59 +0200 Received: from aurel32 by ohm.rr44.fr with local (Exim 4.96) (envelope-from ) id 1ojmCU-003lRs-1c; Sat, 15 Oct 2022 20:47:58 +0200 Date: Sat, 15 Oct 2022 20:47:58 +0200 From: Aurelien Jarno To: Dan Johansen Cc: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Rockchip SoC support" , "open list:ARM/Rockchip SoC support" , open list , Dongjin Kim Subject: Re: [PATCH v3 00/13] Add support for the Hardkernel ODROID-M1 board Message-ID: Mail-Followup-To: Dan Johansen , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Rockchip SoC support" , "open list:ARM/Rockchip SoC support" , open list , Dongjin Kim References: <20220930051246.391614-1-aurelien@aurel32.net> <8e84786d-8ae9-0f51-3438-24fb340199c6@manjaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.7 (2022-08-07) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022-10-08 15:53, Aurelien Jarno wrote: > On 2022-10-08 14:11, Dan Johansen wrote: > > > > Den 30.09.2022 kl. 07.12 skrev Aurelien Jarno: > > > On the ODROID forum, Dongjin Kim said he is not planning to submit a new > > > version of the patchset adding support for the Hardkernel ODROID-M1 > > > board. I therefore decided to address the issues reported during the > > > initial review, and I also did some small fixes either because some > > > things changed in the meantime on the kernel side or because I noticed > > > some warning or issues when using the hardware. > > > > > > I continued writing some additional patches to complete the ODROID M1 > > > DTS to almost fully support the hardware, the drivers being already > > > present in the kernel. > > > > > > This new version includes feedback from the linux-rockchip mailing list > > > and from the Odroid forum. > > > > > > Changes since v2: > > > * Renamed "Rockchip RK3568 Hardkernel ODROID-M1" into "Hardkernel Odroid > > > M1" and fix the sorting. > > > * Fix sorting of arch/arm64/boot/dts/rockchip/Makefile > > > * Collected Acked-by and Tested-by > > > > Even though I added my Tested-by to this series, it seems I didn't test it > > on eMMC. > > > > This fails to boot for me on eMMC, but works on SD card and NVMe. > > Thanks for the feedback. I do not have an eMMC, so this the only part > from the patchset that I haven't been able to test. > > First of all, which version have you tested? The v2 includes fixes for > the eMMC, there was a conflict with the NOR flash. If the problem is > still there in the v2, could you please send the boot log or the error > message? Sorry I meant v3 above. Anyway in the meantime I have bought an eMMC, and I confirm that: - it does no work with the v2 due to a conflict with the NOR flash driver - it does work with the v3 Therefore can you please retry with the v3? Thanks Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net