From: Lee Jones <lee@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCHv4 07/13] mfd: rk808: split into core and i2c
Date: Mon, 31 Oct 2022 13:56:26 +0000 [thread overview]
Message-ID: <Y1/UCkQQXOb38VW+@google.com> (raw)
In-Reply-To: <20221020204251.108565-8-sebastian.reichel@collabora.com>
On Thu, 20 Oct 2022, Sebastian Reichel wrote:
> Split rk808 into a core and an i2c part in preperation for
> SPI support.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> drivers/clk/Kconfig | 2 +-
> drivers/input/misc/Kconfig | 2 +-
> drivers/mfd/Kconfig | 7 +-
> drivers/mfd/Makefile | 3 +-
> drivers/mfd/{rk808.c => rk8xx-core.c} | 210 ++++----------------------
> drivers/mfd/rk8xx-i2c.c | 209 +++++++++++++++++++++++++
> drivers/pinctrl/Kconfig | 2 +-
> drivers/power/supply/Kconfig | 2 +-
> drivers/regulator/Kconfig | 2 +-
> drivers/rtc/Kconfig | 2 +-
> include/linux/mfd/rk808.h | 6 +
> sound/soc/codecs/Kconfig | 2 +-
> 12 files changed, 263 insertions(+), 186 deletions(-)
> rename drivers/mfd/{rk808.c => rk8xx-core.c} (75%)
> create mode 100644 drivers/mfd/rk8xx-i2c.c
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index d79905f3e174..8448d616b9aa 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -83,7 +83,7 @@ config COMMON_CLK_MAX9485
>
> config COMMON_CLK_RK808
> tristate "Clock driver for RK805/RK808/RK809/RK817/RK818"
> - depends on MFD_RK808
> + depends on MFD_RK8XX
> help
> This driver supports RK805, RK809 and RK817, RK808 and RK818 crystal oscillator clock.
> These multi-function devices have two fixed-rate oscillators, clocked at 32KHz each.
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index 9f088900f863..1899afeaec47 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -588,7 +588,7 @@ config INPUT_PWM_VIBRA
>
> config INPUT_RK805_PWRKEY
> tristate "Rockchip RK805 PMIC power key support"
> - depends on MFD_RK808
> + depends on MFD_RK8XX
> help
> Select this option to enable power key driver for RK805.
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 8b93856de432..8e3de443cc3d 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1201,12 +1201,17 @@ config MFD_RC5T583
> Additional drivers must be enabled in order to use the
> different functionality of the device.
>
> -config MFD_RK808
> +config MFD_RK8XX
> + bool
> + select MFD_CORE
> +
> +config MFD_RK8XX_I2C
> tristate "Rockchip RK805/RK808/RK809/RK817/RK818 Power Management Chip"
> depends on I2C && OF
> select MFD_CORE
> select REGMAP_I2C
> select REGMAP_IRQ
> + select MFD_RK8XX
> help
> If you say yes here you get support for the RK805, RK808, RK809,
> RK817 and RK818 Power Management chips.
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index 7ed3ef4a698c..edf84e870f98 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -223,7 +223,8 @@ obj-$(CONFIG_MFD_PALMAS) += palmas.o
> obj-$(CONFIG_MFD_VIPERBOARD) += viperboard.o
> obj-$(CONFIG_MFD_NTXEC) += ntxec.o
> obj-$(CONFIG_MFD_RC5T583) += rc5t583.o rc5t583-irq.o
> -obj-$(CONFIG_MFD_RK808) += rk808.o
> +obj-$(CONFIG_MFD_RK8XX) += rk8xx-core.o
> +obj-$(CONFIG_MFD_RK8XX_I2C) += rk8xx-i2c.o
> obj-$(CONFIG_MFD_RN5T618) += rn5t618.o
> obj-$(CONFIG_MFD_SEC_CORE) += sec-core.o sec-irq.o
> obj-$(CONFIG_MFD_SYSCON) += syscon.o
> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk8xx-core.c
> similarity index 75%
> rename from drivers/mfd/rk808.c
> rename to drivers/mfd/rk8xx-core.c
> index b154ca96d812..098506972710 100644
> --- a/drivers/mfd/rk808.c
> +++ b/drivers/mfd/rk8xx-core.c
> @@ -3,16 +3,9 @@
> * MFD core driver for Rockchip RK808/RK818
> *
> * Copyright (c) 2014, Fuzhou Rockchip Electronics Co., Ltd
> - *
> - * Author: Chris Zhong <zyw@rock-chips.com>
> - * Author: Zhang Qing <zhangqing@rock-chips.com>
> - *
> * Copyright (C) 2016 PHYTEC Messtechnik GmbH
> - *
> - * Author: Wadim Egorov <w.egorov@phytec.de>
> */
The patch and the premise behind it look reasonable.
What's the reason for taking out the Author tags?
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2022-10-31 13:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 20:42 [PATCHv4 00/13] Introduce RK806 Support Sebastian Reichel
2022-10-20 20:42 ` [PATCHv4 01/13] clk: RK808: reduce 'struct rk808' usage Sebastian Reichel
2022-10-20 20:42 ` [PATCHv4 02/13] regulator: rk808: " Sebastian Reichel
2022-10-20 20:42 ` [PATCHv4 03/13] rtc: " Sebastian Reichel
2022-11-25 23:52 ` Sebastian Reichel
2022-10-20 20:42 ` [PATCHv4 04/13] mfd: rk808: convert to device managed resources Sebastian Reichel
2022-10-20 20:42 ` [PATCHv4 05/13] mfd: rk808: use dev_err_probe Sebastian Reichel
2022-10-20 20:42 ` [PATCHv4 06/13] mfd: rk808: replace 'struct i2c_client' with 'struct device' Sebastian Reichel
2022-10-20 20:42 ` [PATCHv4 07/13] mfd: rk808: split into core and i2c Sebastian Reichel
2022-10-31 13:56 ` Lee Jones [this message]
2022-10-20 20:42 ` [PATCHv4 08/13] dt-bindings: mfd: add rk806 binding Sebastian Reichel
2022-10-21 22:19 ` Rob Herring
2022-10-20 20:42 ` [PATCHv4 09/13] mfd: rk8xx: add rk806 support Sebastian Reichel
2022-10-31 14:04 ` Lee Jones
2022-10-20 20:42 ` [PATCHv4 10/13] pinctrl: rk805: add rk806 pinctrl support Sebastian Reichel
2022-10-20 20:42 ` [PATCHv4 11/13] regulator: rk808: Use dev_err_probe Sebastian Reichel
2022-11-25 19:33 ` [PATCH v4 " Mark Brown
2022-11-25 23:46 ` Sebastian Reichel
2022-10-20 20:42 ` [PATCHv4 12/13] regulator: expose regulator_find_closest_bigger Sebastian Reichel
2022-10-20 20:42 ` [PATCHv4 13/13] regulator: rk808: add rk806 support Sebastian Reichel
2022-11-28 19:05 ` (subset) [PATCHv4 00/13] Introduce RK806 Support Mark Brown
2022-12-11 19:59 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1/UCkQQXOb38VW+@google.com \
--to=lee@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).