* Re: [PATCH] of: fix repeated words in comments
2022-10-19 18:53 ` Randy Dunlap
@ 2022-10-19 18:57 ` Conor Dooley
2022-10-20 13:34 ` Bagas Sanjaya
2022-10-20 1:39 ` Theodore Ts'o
2022-10-20 13:35 ` Bagas Sanjaya
2 siblings, 1 reply; 9+ messages in thread
From: Conor Dooley @ 2022-10-19 18:57 UTC (permalink / raw)
To: Randy Dunlap, Jilin Yuan, robh+dt, frowand.list; +Cc: devicetree, linux-kernel
On 19/10/2022 19:53, Randy Dunlap wrote:
>
>
> On 10/19/22 06:02, Jilin Yuan wrote:
>> Delete the redundant word 'of'.
>>
>> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
>> ---
>> drivers/of/device.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/of/device.c b/drivers/of/device.c
>> index 8cefe5a7d04e..16c7e5a2a868 100644
>> --- a/drivers/of/device.c
>> +++ b/drivers/of/device.c
>> @@ -19,7 +19,7 @@
>>
>> /**
>> * of_match_device - Tell if a struct device matches an of_device_id list
>> - * @matches: array of of device match structures to search in
>> + * @matches: array of device match structures to search in
>
> Hi,
> Rob has already explained this at least 2 times.
>
> The second "of" is "open firmware".
> I would write it
> array of OF device match structures to search in
> :)
Good luck getting a response out of these guys, at this point
you've gotta wonder if they're real people or bots.
>
>> * @dev: the of device structure to match against
>> *
>> * Used by a driver to check whether an platform_device present in the
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] of: fix repeated words in comments
2022-10-19 18:57 ` Conor Dooley
@ 2022-10-20 13:34 ` Bagas Sanjaya
0 siblings, 0 replies; 9+ messages in thread
From: Bagas Sanjaya @ 2022-10-20 13:34 UTC (permalink / raw)
To: Conor Dooley
Cc: Randy Dunlap, Jilin Yuan, robh+dt, frowand.list, devicetree,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 412 bytes --]
On Wed, Oct 19, 2022 at 07:57:44PM +0100, Conor Dooley wrote:
> Good luck getting a response out of these guys, at this point
> you've gotta wonder if they're real people or bots.
>
I think @cdjrlc.com people only have one-way communication with kernel
community, since they send patches but ignoring (critical) review on
these.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] of: fix repeated words in comments
2022-10-19 18:53 ` Randy Dunlap
2022-10-19 18:57 ` Conor Dooley
@ 2022-10-20 1:39 ` Theodore Ts'o
2022-10-20 1:54 ` Randy Dunlap
2022-10-20 13:15 ` Rob Herring
2022-10-20 13:35 ` Bagas Sanjaya
2 siblings, 2 replies; 9+ messages in thread
From: Theodore Ts'o @ 2022-10-20 1:39 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Jilin Yuan, robh+dt, frowand.list, devicetree, linux-kernel
On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote:
>
> On 10/19/22 06:02, Jilin Yuan wrote:
> > Delete the redundant word 'of'.
> >
> > Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> > ---
> > drivers/of/device.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/of/device.c b/drivers/of/device.c
> > index 8cefe5a7d04e..16c7e5a2a868 100644
> > --- a/drivers/of/device.c
> > +++ b/drivers/of/device.c
> > @@ -19,7 +19,7 @@
> >
> > /**
> > * of_match_device - Tell if a struct device matches an of_device_id list
> > - * @matches: array of of device match structures to search in
> > + * @matches: array of device match structures to search in
>
> Hi,
> Rob has already explained this at least 2 times.
>
> The second "of" is "open firmware".
> I would write it
> array of OF device match structures to search in
> :)
Actually, I'd probably do something like
array of Open Firmware (OF) device match structures...
This is the first place in that file (at least in a comment) where OF
gets used, and I've always been a big fan of using the fully expanded
acronym before using the acronym form. Remember, PCMCIA stands for
People Can't Memorize Computer Industry Acronyms. :-)
(Actually, it's Personal Computer Memory Chip Industry Association,
but most people don't know that, because using acronyms without
defining them first makes you feel like you're an "insider". :-)
- Ted
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] of: fix repeated words in comments
2022-10-20 1:39 ` Theodore Ts'o
@ 2022-10-20 1:54 ` Randy Dunlap
2022-10-20 13:15 ` Rob Herring
1 sibling, 0 replies; 9+ messages in thread
From: Randy Dunlap @ 2022-10-20 1:54 UTC (permalink / raw)
To: Theodore Ts'o
Cc: Jilin Yuan, robh+dt, frowand.list, devicetree, linux-kernel
On 10/19/22 18:39, Theodore Ts'o wrote:
> On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote:
>>
>> On 10/19/22 06:02, Jilin Yuan wrote:
>>> Delete the redundant word 'of'.
>>>
>>> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
>>> ---
>>> drivers/of/device.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/of/device.c b/drivers/of/device.c
>>> index 8cefe5a7d04e..16c7e5a2a868 100644
>>> --- a/drivers/of/device.c
>>> +++ b/drivers/of/device.c
>>> @@ -19,7 +19,7 @@
>>>
>>> /**
>>> * of_match_device - Tell if a struct device matches an of_device_id list
>>> - * @matches: array of of device match structures to search in
>>> + * @matches: array of device match structures to search in
>>
>> Hi,
>> Rob has already explained this at least 2 times.
>>
>> The second "of" is "open firmware".
>> I would write it
>> array of OF device match structures to search in
>> :)
>
> Actually, I'd probably do something like
>
> array of Open Firmware (OF) device match structures...
Sure, that's good.
> This is the first place in that file (at least in a comment) where OF
> gets used, and I've always been a big fan of using the fully expanded
> acronym before using the acronym form. Remember, PCMCIA stands for
> People Can't Memorize Computer Industry Acronyms. :-)
>
> (Actually, it's Personal Computer Memory Chip Industry Association,
Card International Association :)
> but most people don't know that, because using acronyms without
> defining them first makes you feel like you're an "insider". :-)
--
~Randy
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] of: fix repeated words in comments
2022-10-20 1:39 ` Theodore Ts'o
2022-10-20 1:54 ` Randy Dunlap
@ 2022-10-20 13:15 ` Rob Herring
1 sibling, 0 replies; 9+ messages in thread
From: Rob Herring @ 2022-10-20 13:15 UTC (permalink / raw)
To: Theodore Ts'o
Cc: Randy Dunlap, Jilin Yuan, frowand.list, devicetree, linux-kernel
On Wed, Oct 19, 2022 at 8:39 PM Theodore Ts'o <tytso@mit.edu> wrote:
>
> On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote:
> >
> > On 10/19/22 06:02, Jilin Yuan wrote:
> > > Delete the redundant word 'of'.
> > >
> > > Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> > > ---
> > > drivers/of/device.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/of/device.c b/drivers/of/device.c
> > > index 8cefe5a7d04e..16c7e5a2a868 100644
> > > --- a/drivers/of/device.c
> > > +++ b/drivers/of/device.c
> > > @@ -19,7 +19,7 @@
> > >
> > > /**
> > > * of_match_device - Tell if a struct device matches an of_device_id list
> > > - * @matches: array of of device match structures to search in
> > > + * @matches: array of device match structures to search in
> >
> > Hi,
> > Rob has already explained this at least 2 times.
> >
> > The second "of" is "open firmware".
> > I would write it
> > array of OF device match structures to search in
> > :)
>
> Actually, I'd probably do something like
>
> array of Open Firmware (OF) device match structures...
Or just put the struct name in there: of_device_id
But at this point I prefer to just leave it alone for the
entertainment factor of how many times can I get this patch from
send-only email accts.
Rob
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] of: fix repeated words in comments
2022-10-19 18:53 ` Randy Dunlap
2022-10-19 18:57 ` Conor Dooley
2022-10-20 1:39 ` Theodore Ts'o
@ 2022-10-20 13:35 ` Bagas Sanjaya
2022-10-20 17:36 ` Randy Dunlap
2 siblings, 1 reply; 9+ messages in thread
From: Bagas Sanjaya @ 2022-10-20 13:35 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Jilin Yuan, robh+dt, frowand.list, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 427 bytes --]
On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote:
> > /**
> > * of_match_device - Tell if a struct device matches an of_device_id list
> > - * @matches: array of of device match structures to search in
> > + * @matches: array of device match structures to search in
>
> Hi,
> Rob has already explained this at least 2 times.
>
On what?
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] of: fix repeated words in comments
2022-10-20 13:35 ` Bagas Sanjaya
@ 2022-10-20 17:36 ` Randy Dunlap
0 siblings, 0 replies; 9+ messages in thread
From: Randy Dunlap @ 2022-10-20 17:36 UTC (permalink / raw)
To: Bagas Sanjaya; +Cc: Jilin Yuan, robh+dt, frowand.list, devicetree, linux-kernel
On 10/20/22 06:35, Bagas Sanjaya wrote:
> On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote:
>>> /**
>>> * of_match_device - Tell if a struct device matches an of_device_id list
>>> - * @matches: array of of device match structures to search in
>>> + * @matches: array of device match structures to search in
>>
>> Hi,
>> Rob has already explained this at least 2 times.
>>
>
> On what?
>
I have seen them on lkml mailing list.
--
~Randy
^ permalink raw reply [flat|nested] 9+ messages in thread