From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 856E7C433FE for ; Fri, 21 Oct 2022 06:40:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230153AbiJUGk1 (ORCPT ); Fri, 21 Oct 2022 02:40:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229515AbiJUGkZ (ORCPT ); Fri, 21 Oct 2022 02:40:25 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A070112A96; Thu, 20 Oct 2022 23:40:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E688EB82ADA; Fri, 21 Oct 2022 06:40:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4B59C433D6; Fri, 21 Oct 2022 06:40:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666334419; bh=sSDsv8sNrV4MWlFb62YOB+RVifnK0tCFSxdozhi2KE4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aksXMaxXMeRvPuoZU14QDKDiGuGGTwPIhJul2Z60muawg8b7ekV6ZDVQQeeJ9+9cq 9R1szce+/cZdhvcZx9xGVe2M2/qKnpBPIy02FrsDgUVNxkqeiU+/yoAgTxITqBhbNz N1FOsikN0SJHBXA4OrLaFSQyGl48X1X2whKpKnGrTO5vj4dnUe/jr4Z7tpbos4L3Lo UpYBe483uJYXHFYQXFVD2YE2J5Mm3nbPnTYEuP9nNoKLFdEKxyf5xwfZegEfkmJi73 m92DLrkkhhk2/SQT+Hoe7aWlqUhnNvcvbD+dreLWEfwXP5gPFldV0fsEQzYsYnWcGT YiurHGZvac48Q== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1ollhN-0001Z7-Ju; Fri, 21 Oct 2022 08:40:05 +0200 Date: Fri, 21 Oct 2022 08:40:05 +0200 From: Johan Hovold To: Krzysztof Kozlowski Cc: Johan Hovold , Stanimir Varbanov , Lorenzo Pieralisi , Andy Gross , Bjorn Andersson , Konrad Dybcio , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Krishna chaitanya chundru , quic_vbadigan@quicinc.com, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: PCI: qcom: Add SC8280XP/SA8540P interconnects Message-ID: References: <20221017112449.2146-1-johan+linaro@kernel.org> <20221017112449.2146-2-johan+linaro@kernel.org> <010b6de2-5df6-77c9-2f04-43f2edc89ff2@linaro.org> <972db8bd-e45a-47b1-c2c4-008c279c6b59@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <972db8bd-e45a-47b1-c2c4-008c279c6b59@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Oct 20, 2022 at 08:29:02AM -0400, Krzysztof Kozlowski wrote: > On 20/10/2022 03:57, Johan Hovold wrote: > > On Wed, Oct 19, 2022 at 10:37:31AM -0400, Krzysztof Kozlowski wrote: > >> On 17/10/2022 07:24, Johan Hovold wrote: > >>> Add the missing SC8280XP/SA8540P "pcie-mem" and "cpu-pcie" interconnect > >>> paths to the bindings. > >>> > >>> Fixes: 76d777ae045e ("dt-bindings: PCI: qcom: Add SC8280XP to binding") > >>> Fixes: 76c4207f4085 ("dt-bindings: PCI: qcom: Add SA8540P to binding") > >>> Signed-off-by: Johan Hovold > >>> --- > >>> .../devicetree/bindings/pci/qcom,pcie.yaml | 25 +++++++++++++++++++ > >>> 1 file changed, 25 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > >>> index 22a2aac4c23f..a55434f95edd 100644 > >>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > >>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > Are you suggesting something like moving the names to the common > > constraints for now: > > > > interconnects: > > maxItems: 2 > > > > interconnect-names: > > items: > > - const: pcie-mem > > - const: cpu-pcie > > > > and then in the allOf: > > > > - if: > > properties: > > compatible: > > contains: > > enum: > > - qcom,pcie-sa8540p > > - qcom,pcie-sc8280xp > > then: > > required: > > - interconnects > > - interconnect-names > > else: > > properties: > > interconnects: false > > interconnect-names: false > > > > This way we'd catch anyone adding interconnects to a DTS without first > > updating the bindings, but it also seems to go against the idea of > > bindings fully describing the hardware by saying that no other platforms > > have interconnects (when they actually do even if we don't describe it > > just yet). > > You can add a comment to the else like "TODO: Not described yet". I > would prefer to have specific but incomplete bindings, instead of loose > one which later might cause people adding whatever names they like. > > > Or should we do the above but without the else clause to have some > > constraints in place on the names at least? > > This would work as well if you think the names are applicable for other > devices. I think that's a reasonable assumption so I'll go with this alternative. Thanks! Johan