devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v6 0/1] arm64: dts: qcom: pwm: Drop PWM reg dependency + update MAINTAINERS
@ 2022-09-28  0:05 Bryan O'Donoghue
  2022-09-28  0:05 ` [PATCH v6 1/1] dt-bindings: mfd: qcom,spmi-pmic: Drop PWM reg dependency Bryan O'Donoghue
  0 siblings, 1 reply; 3+ messages in thread
From: Bryan O'Donoghue @ 2022-09-28  0:05 UTC (permalink / raw)
  To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
	lee, linux-arm-msm, devicetree
  Cc: bryan.odonoghue

V6:
- Drops the change to MAINTAINERS
  Reading Documentation/process/submitting-patches.rst the declaration of
  who needs to be mailed and what "Maintained" and "Supported" mean don't
  match up at all.

  In any case that's out of scope for this simple yaml change so I'll send
  along a proposed patch separately to this.

V5:
- Resend the yaml fix
- Update MAINTAINERS to mark Lee as Maintainer not Supporter of the YAML
  files for MFD.
  I rely on scripts/get_mainter.pl to tell me who needs to be mailed and
  who doesn't, given the YAML change has to go through Lee, the MAINTAINERS
  file should make that show up in get_maintainers.pl

V4:
- Churn patch#1 prefix to "dt-bindings: mfd: qcom,spmi-pmic:" - Krzysztof
- Add's Krzysztof's RB as indicated

V3:
- Splits dtsi and yaml
- Uses Krzysztof's suggested commit log in the yaml

V2:
The accompanying patch removes reg = <> and pwm@reg from the yaml and dtsi.
This follows on from discussions between Bupesh, Dmitry, Bjorn, Krzysztof and myself.

https://lore.kernel.org/all/20220719205058.1004942-1-bhupesh.sharma@linaro.org/
https://lore.kernel.org/all/20220721195502.1525214-1-bhupesh.sharma@linaro.org/
https://lore.kernel.org/all/20220822120300.2633790-1-bryan.odonoghue@linaro.org/

The previous discussion tended towards either removing pwm@reg and reg = <> or
extending out the yaml to support multiple reg declarations for PWM compatible.

This patch does the former. I've left node: label in place, dropped both pwm@reg
and reg = <> I kept "label: nodename" though because it looked more like what we
already have for rpm regulators.

Per our previous discussion I've modified the yaml and dtsi in one go.

Bryan O'Donoghue (1):
  dt-bindings: mfd: qcom,spmi-pmic: Drop PWM reg dependency

 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
2.37.3


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v6 1/1] dt-bindings: mfd: qcom,spmi-pmic: Drop PWM reg dependency
  2022-09-28  0:05 [PATCH v6 0/1] arm64: dts: qcom: pwm: Drop PWM reg dependency + update MAINTAINERS Bryan O'Donoghue
@ 2022-09-28  0:05 ` Bryan O'Donoghue
  2022-10-24 12:31   ` Lee Jones
  0 siblings, 1 reply; 3+ messages in thread
From: Bryan O'Donoghue @ 2022-09-28  0:05 UTC (permalink / raw)
  To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
	lee, linux-arm-msm, devicetree
  Cc: bryan.odonoghue, Krzysztof Kozlowski

The PWM node is not a separate device and is expected to be part of parent
SPMI PMIC node, thus it obtains the address space from the parent. One IO
address in "reg" is also not correct description because LPG block maps to
several regions.

Fixes: 3f5117be9584 ("dt-bindings: mfd: convert to yaml Qualcomm SPMI PMIC")
Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 65cbc6dee545e..2a5bafe0660a0 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -92,6 +92,10 @@ properties:
     type: object
     $ref: /schemas/regulator/regulator.yaml#
 
+  pwm:
+    type: object
+    $ref: /schemas/leds/leds-qcom-lpg.yaml#
+
 patternProperties:
   "^adc@[0-9a-f]+$":
     type: object
@@ -117,10 +121,6 @@ patternProperties:
     type: object
     $ref: /schemas/power/reset/qcom,pon.yaml#
 
-  "pwm@[0-9a-f]+$":
-    type: object
-    $ref: /schemas/leds/leds-qcom-lpg.yaml#
-
   "^rtc@[0-9a-f]+$":
     type: object
     $ref: /schemas/rtc/qcom-pm8xxx-rtc.yaml#
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v6 1/1] dt-bindings: mfd: qcom,spmi-pmic: Drop PWM reg dependency
  2022-09-28  0:05 ` [PATCH v6 1/1] dt-bindings: mfd: qcom,spmi-pmic: Drop PWM reg dependency Bryan O'Donoghue
@ 2022-10-24 12:31   ` Lee Jones
  0 siblings, 0 replies; 3+ messages in thread
From: Lee Jones @ 2022-10-24 12:31 UTC (permalink / raw)
  To: Bryan O'Donoghue
  Cc: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
	linux-arm-msm, devicetree, Krzysztof Kozlowski

On Wed, 28 Sep 2022, Bryan O'Donoghue wrote:

> The PWM node is not a separate device and is expected to be part of parent
> SPMI PMIC node, thus it obtains the address space from the parent. One IO
> address in "reg" is also not correct description because LPG block maps to
> several regions.
> 
> Fixes: 3f5117be9584 ("dt-bindings: mfd: convert to yaml Qualcomm SPMI PMIC")
> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied, thanks.

NB: This applied with conflicts.  I fixed them up, but they might be
incorrect.  Please ensure you review them, either in the MFD tree, or
when they appear in -next.

-- 
Lee Jones [李琼斯]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-24 13:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-28  0:05 [PATCH v6 0/1] arm64: dts: qcom: pwm: Drop PWM reg dependency + update MAINTAINERS Bryan O'Donoghue
2022-09-28  0:05 ` [PATCH v6 1/1] dt-bindings: mfd: qcom,spmi-pmic: Drop PWM reg dependency Bryan O'Donoghue
2022-10-24 12:31   ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).