From: Johan Hovold <johan@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: add TCSR node
Date: Mon, 24 Oct 2022 15:42:22 +0200 [thread overview]
Message-ID: <Y1aWPhP7/ft8s+bh@hovoldconsulting.com> (raw)
In-Reply-To: <94e05a63-e7f3-a78f-d0a6-8efcae619726@linaro.org>
On Mon, Oct 24, 2022 at 09:34:22AM -0400, Krzysztof Kozlowski wrote:
> On 24/10/2022 08:58, Johan Hovold wrote:
> > Add the TCSR node which is needed for PCIe configuration.
> >
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---
> > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 5 +++++
>
> Please send the patches together with the binding. There is no need to
> have this split and it causes additional effort during review - lookup
> of the binding.
I was under the impression that the dts changes should be submitted
separately from the binding as they go through different trees. (And
last time I posted them together the subsystem maintainer ended up
taking also the dts changes by mistake).
The binding has been picked up by Lee now so I posted the dts change.
Could have added a lore link though.
> Also additional effort during binding review - lack of usage of bindings.
>
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Johan
next prev parent reply other threads:[~2022-10-24 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 12:58 [PATCH] arm64: dts: qcom: sc8280xp: add TCSR node Johan Hovold
2022-10-24 13:34 ` Krzysztof Kozlowski
2022-10-24 13:42 ` Johan Hovold [this message]
2022-10-24 14:09 ` Krzysztof Kozlowski
2022-10-24 14:54 ` Johan Hovold
2022-10-24 16:31 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1aWPhP7/ft8s+bh@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).