From: Johan Hovold <johan@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Vinod Koul <vkoul@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/13] dt-bindings: phy: qcom,qmp-usb: fix sc8280xp binding
Date: Fri, 28 Oct 2022 08:09:11 +0200 [thread overview]
Message-ID: <Y1tyBw2iQvV89+UB@hovoldconsulting.com> (raw)
In-Reply-To: <c9940701-8486-5a0c-4c7d-9c85b9460a7f@linaro.org>
On Thu, Oct 27, 2022 at 10:15:45PM -0400, Krzysztof Kozlowski wrote:
> On 24/10/2022 06:06, Johan Hovold wrote:
> > The current QMP USB PHY bindings are based on the original MSM8996 PCIe
> > PHY binding which provided multiple PHYs per IP block and these in turn
> > were described by child nodes.
> >
> > The QMP USB PHY block only provide a single PHY and the remnant child
> > node does not really reflect the hardware.
> >
> > The original MSM8996 binding also ended up describing the individual
> > register blocks as belonging to either the wrapper node or the PHY child
> > nodes.
> >
>
> (...)
>
> > then:
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb-phy.yaml
> > new file mode 100644
> > index 000000000000..95ee81d782f9
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb-phy.yaml
>
> Filename based on compatible, so in this case
> "qcom,sc8280xp-qmp-usb3-uni-phy.yaml", unless it's like the PCI case?
Yes, you're right. Thanks for catching that. This should be the only
sc8280xp USB PHY compatible so the file name should be updates as you
suggested.
I'll wait a bit and see if Vinod has any comments before respinning this
series.
Johan
next prev parent reply other threads:[~2022-10-28 6:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 10:06 [PATCH 00/13] phy: qcom-qmp-usb: fix sc8280xp binding Johan Hovold
2022-10-24 10:06 ` [PATCH 01/13] phy: qcom-qmp-usb: fix sc8280xp PCS_USB offset Johan Hovold
2022-10-24 13:32 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 02/13] phy: qcom-qmp-usb: sort device-id table Johan Hovold
2022-10-24 13:33 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 03/13] phy: qcom-qmp-usb: move " Johan Hovold
2022-10-24 13:33 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 04/13] phy: qcom-qmp-usb: move pm ops Johan Hovold
2022-10-24 13:33 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 05/13] phy: qcom-qmp-usb: merge driver data Johan Hovold
2022-10-24 13:33 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 06/13] phy: qcom-qmp-usb: clean up device-tree parsing Johan Hovold
2022-10-24 13:34 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 07/13] phy: qcom-qmp-usb: clean up probe initialisation Johan Hovold
2022-10-24 13:34 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 08/13] phy: qcom-qmp-usb: rename PHY ops structure Johan Hovold
2022-10-24 13:34 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 09/13] phy: qcom-qmp-usb: clean up PHY init Johan Hovold
2022-10-24 13:34 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 10/13] dt-bindings: phy: qcom,qmp-usb: rename current bindings Johan Hovold
2022-10-28 2:12 ` Krzysztof Kozlowski
2022-10-24 10:06 ` [PATCH 11/13] dt-bindings: phy: qcom,qmp-usb: fix sc8280xp binding Johan Hovold
2022-10-28 2:15 ` Krzysztof Kozlowski
2022-10-28 6:09 ` Johan Hovold [this message]
2022-10-28 6:13 ` Johan Hovold
2022-10-28 13:05 ` Vinod Koul
2022-10-24 10:06 ` [PATCH 12/13] phy: qcom-qmp-usb: restructure PHY creation Johan Hovold
2022-10-24 13:35 ` Dmitry Baryshkov
2022-10-24 10:06 ` [PATCH 13/13] phy: qcom-qmp-usb: add support for updated sc8280xp binding Johan Hovold
2022-10-24 13:35 ` Dmitry Baryshkov
2022-10-24 13:38 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1tyBw2iQvV89+UB@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).