From: Mark Brown <broonie@kernel.org>
To: Ajye Huang <ajye_huang@compal.corp-partner.google.com>
Cc: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
linux-kernel@vger.kernel.org, robh@kernel.org,
alsa-devel@alsa-project.org,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
devicetree@vger.kernel.org,
angelogioacchino.delregno@collabora.corp-partner.google.com,
"Shengjiu Wang" <shengjiu.wang@nxp.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Takashi Iwai" <tiwai@suse.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Arnaud Pouliquen" <arnaud.pouliquen@foss.st.com>
Subject: Re: [PATCH v1 2/2] ASoC: dmic: Add optional dmic selection
Date: Fri, 28 Oct 2022 13:58:55 +0100 [thread overview]
Message-ID: <Y1vSDyZlZBaGyJyb@sirena.org.uk> (raw)
In-Reply-To: <CALprXBavrYqWxKUgEJMWNXGCuBnKNjKk1n_4eFOeo+=6=juHYQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
On Fri, Oct 28, 2022 at 08:54:31PM +0800, Ajye Huang wrote:
> Yes, the original version I tried the implementation on audio machine
> driver, but one person gave me an idea for this dmic.c
> Do you think it is appropriate on dmic.c?
> If it isn't, I will add kcontrol into audio machine driver. thanks
It's definitely a better fit somewhere else - like I said in reply to
the DT binding it's really a mux that sits between the DMICs and the DAI
so that's probably where a generic version should be implemented.
Please don't top post, reply in line with needed context. This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-10-28 12:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 10:24 [PATCH v1 0/2] Add optional dmic selection for two DMICs Ajye Huang
2022-10-28 10:24 ` [PATCH v1 1/2] ASoC: dt-bindings: Document dmic_sel-gpios optional prop for two DMICs case Ajye Huang
2022-10-28 11:56 ` Mark Brown
2022-10-31 18:43 ` Rob Herring
2022-10-31 20:47 ` Mark Brown
2022-11-01 1:04 ` Ajye Huang
2022-11-01 1:07 ` Ajye Huang
2022-10-28 10:24 ` [PATCH v1 2/2] ASoC: dmic: Add optional dmic selection Ajye Huang
2022-10-28 11:44 ` Amadeusz Sławiński
2022-10-28 12:54 ` Ajye Huang
2022-10-28 12:58 ` Mark Brown [this message]
2022-10-28 11:57 ` Mark Brown
2022-10-28 12:59 ` Ajye Huang
2022-10-28 13:01 ` Mark Brown
2022-10-28 13:09 ` Ajye Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1vSDyZlZBaGyJyb@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ajye_huang@compal.corp-partner.google.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.corp-partner.google.com \
--cc=arnaud.pouliquen@foss.st.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).