From: Johan Hovold <johan@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Johan Hovold <johan+linaro@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 08/15] phy: qcom-qmp-pcie: add register init helper
Date: Fri, 28 Oct 2022 15:07:03 +0200 [thread overview]
Message-ID: <Y1vT94blD9PJHKDp@hovoldconsulting.com> (raw)
In-Reply-To: <Y1vRDv+hrMmnqwPj@matsya>
On Fri, Oct 28, 2022 at 06:24:38PM +0530, Vinod Koul wrote:
> On 21-10-22, 13:32, Johan Hovold wrote:
> > [...] This is not about keeping the
> > diff small, this is about readability of the new helper function as I
> > already told you.
> >
> > And this is a *local* identifier, not some state member that needs a
> > super descriptive name. And the rest of the driver used "tbl"
> > consistently until your EP/RC mode patches for that matter.
>
> I would disagree here... You can change tbls/tables but then it does not
> help _this_ patch
>
> Right thing would be to change tbls to tables first and then add init
> helper... For a reviewer seeing an undocumented change and unnecessary
> diff is not right..
I still think that it belongs in the patch adding the new helper
because it is essentially only in that new function that the improved
readability due to the shorter identifier matters (the earlier helpers
where per table type).
> Pls split if you would still like the rename
But if you prefer I'll split it out in a preparatory patch.
Johan
next prev parent reply other threads:[~2022-10-28 13:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 11:09 [PATCH v3 00/15] phy: qcom-qmp-pcie: add support for sc8280xp Johan Hovold
2022-10-21 11:09 ` [PATCH v3 01/15] phy: qcom-qmp-pcie: sort device-id table Johan Hovold
2022-10-21 11:09 ` [PATCH v3 02/15] phy: qcom-qmp-pcie: move " Johan Hovold
2022-10-21 11:09 ` [PATCH v3 03/15] phy: qcom-qmp-pcie: merge driver data Johan Hovold
2022-10-21 11:09 ` [PATCH v3 04/15] phy: qcom-qmp-pcie: clean up device-tree parsing Johan Hovold
2022-10-21 11:09 ` [PATCH v3 05/15] phy: qcom-qmp-pcie: clean up probe initialisation Johan Hovold
2022-10-21 11:09 ` [PATCH v3 06/15] phy: qcom-qmp-pcie: rename PHY ops structure Johan Hovold
2022-10-21 11:09 ` [PATCH v3 07/15] phy: qcom-qmp-pcie: clean up PHY lane init Johan Hovold
2022-10-21 11:09 ` [PATCH v3 08/15] phy: qcom-qmp-pcie: add register init helper Johan Hovold
2022-10-21 11:18 ` Dmitry Baryshkov
2022-10-21 11:32 ` Johan Hovold
2022-10-28 12:54 ` Vinod Koul
2022-10-28 13:07 ` Johan Hovold [this message]
2022-10-28 13:08 ` Vinod Koul
2022-10-21 11:09 ` [PATCH v3 09/15] dt-bindings: phy: qcom,qmp-pcie: rename current bindings Johan Hovold
2022-10-21 11:09 ` [PATCH v3 10/15] dt-bindings: phy: qcom,qmp-pcie: add sc8280xp bindings Johan Hovold
2022-10-21 11:09 ` [PATCH v3 11/15] phy: qcom-qmp-pcie: restructure PHY creation Johan Hovold
2022-10-21 11:09 ` [PATCH v3 12/15] phy: qcom-qmp-pcie: fix initialisation reset Johan Hovold
2022-10-21 11:09 ` [PATCH v3 13/15] phy: qcom-qmp-pcie: add support for pipediv2 clock Johan Hovold
2022-10-21 11:15 ` Dmitry Baryshkov
2022-10-21 11:09 ` [PATCH v3 14/15] phy: qcom-qmp-pcie: add support for sc8280xp Johan Hovold
2022-10-21 11:09 ` [PATCH v3 15/15] phy: qcom-qmp-pcie: add support for sc8280xp 4-lane PHYs Johan Hovold
2022-10-21 11:19 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1vT94blD9PJHKDp@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).