From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FC74FA3745 for ; Fri, 28 Oct 2022 13:06:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230367AbiJ1NGi (ORCPT ); Fri, 28 Oct 2022 09:06:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230364AbiJ1NGP (ORCPT ); Fri, 28 Oct 2022 09:06:15 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1C0C1C19E5; Fri, 28 Oct 2022 06:05:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 5A8F9CE2B25; Fri, 28 Oct 2022 13:05:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5C0FC433D6; Fri, 28 Oct 2022 13:05:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666962343; bh=fWTLQkHg0kXZkdXLU2JEa23QeLvNM23OHgnTkuCfUdg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ww0pFcRilUvnjfM4W+Dgyi8JNYcnfF1lQkgbl81ew0dyq4gmRj2xnPrxxL/K50aH9 L/xgzIEAl/V5Z1BEBflHVwqUTdtnWigsD9dvLATqhpHDQy3cSRqnqjQfV2fevKD0Ah 4Y0yF+JgtdWNgb008x2szhQqlp/KmNFl35W1WYxnMyGaRP8Coy9CJcqpia+JQdmftu +I9La6FTeU8Z0AD7UI37cHgPd8IU9Bzb+DsrkzjAjuE1ahqXdfUnsuI3mJ4Qm2fpIQ 2Q1wAOv33KTSASt/fIqgqTCyEER/x+R6M6WGPpuIrulNqF880NdzhSIrfPgoj2OYLT 3lIO6DRDOwdjw== Date: Fri, 28 Oct 2022 18:35:39 +0530 From: Vinod Koul To: Johan Hovold Cc: Krzysztof Kozlowski , Johan Hovold , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/13] dt-bindings: phy: qcom,qmp-usb: fix sc8280xp binding Message-ID: References: <20221024100632.20549-1-johan+linaro@kernel.org> <20221024100632.20549-12-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28-10-22, 08:09, Johan Hovold wrote: > On Thu, Oct 27, 2022 at 10:15:45PM -0400, Krzysztof Kozlowski wrote: > > On 24/10/2022 06:06, Johan Hovold wrote: > > > The current QMP USB PHY bindings are based on the original MSM8996 PCIe > > > PHY binding which provided multiple PHYs per IP block and these in turn > > > were described by child nodes. > > > > > > The QMP USB PHY block only provide a single PHY and the remnant child > > > node does not really reflect the hardware. > > > > > > The original MSM8996 binding also ended up describing the individual > > > register blocks as belonging to either the wrapper node or the PHY child > > > nodes. > > > > > > > (...) > > > > > then: > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb-phy.yaml > > > new file mode 100644 > > > index 000000000000..95ee81d782f9 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb-phy.yaml > > > > Filename based on compatible, so in this case > > "qcom,sc8280xp-qmp-usb3-uni-phy.yaml", unless it's like the PCI case? > > Yes, you're right. Thanks for catching that. This should be the only > sc8280xp USB PHY compatible so the file name should be updates as you > suggested. > > I'll wait a bit and see if Vinod has any comments before respinning this > series. lgtm, pls respin -- ~Vinod