From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] arm64: tegra: Update console for Jetson Xavier and Orin
Date: Fri, 28 Oct 2022 16:17:07 +0200 [thread overview]
Message-ID: <Y1vkYyuCPoLLCXDO@orome> (raw)
In-Reply-To: <20221028123556.134435-1-jonathanh@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 2654 bytes --]
On Fri, Oct 28, 2022 at 01:35:56PM +0100, Jon Hunter wrote:
> The Tegra Combined UART (TCU) is the default serial interface for Jetson
> Xavier and Orin platforms and so update the bootargs for these platforms
> to use the TCU.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 2 +-
> arch/arm64/boot/dts/nvidia/tegra194-p3668.dtsi | 2 +-
> arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
I'm a little confused now. You're certainly right that the TCU is the
serial interface, but then why haven't we seen any fallout from this?
That is, why does console=ttyS0,115200n8 still work just fine?
Looking a little more into stdout-path (which we already point to the
TCU), that ends up adding TCU as the preferred console already. So I
wonder if we really need to set the console here at all.
Do you see any difference in behavior after this patch? Does it fix
anything? Could you perhaps try to remove this option altogether and see
if that makes a difference?
Thierry
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
> index 3837ebc67c8e..ccdb32c67861 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
> @@ -23,7 +23,7 @@ aliases {
> };
>
> chosen {
> - bootargs = "console=ttyS0,115200n8";
> + bootargs = "console=ttyTCU0,115200n8";
> stdout-path = "serial0:115200n8";
> };
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p3668.dtsi b/arch/arm64/boot/dts/nvidia/tegra194-p3668.dtsi
> index 916ea3419ee5..f147324d72f3 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra194-p3668.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra194-p3668.dtsi
> @@ -20,7 +20,7 @@ aliases {
> };
>
> chosen {
> - bootargs = "console=ttyS0,115200n8";
> + bootargs = "console=ttyTCU0,115200n8";
> stdout-path = "serial0:115200n8";
> };
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
> index df703fb0cfff..96aa2267b06d 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
> @@ -2025,7 +2025,7 @@ hda@3510000 {
> };
>
> chosen {
> - bootargs = "console=ttyS0,115200n8";
> + bootargs = "console=ttyTCU0,115200n8";
> stdout-path = "serial0:115200n8";
> };
>
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-10-28 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 12:35 [PATCH] arm64: tegra: Update console for Jetson Xavier and Orin Jon Hunter
2022-10-28 14:17 ` Thierry Reding [this message]
2022-10-28 14:45 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1vkYyuCPoLLCXDO@orome \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox