From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>, kishon@kernel.org
Cc: robh+dt@kernel.org, kw@linux.com, bhelgaas@google.com,
krzk+dt@kernel.org, marek.vasut+renesas@gmail.com,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v6 06/10] PCI: dwc: Add reset_all_bars flag
Date: Fri, 11 Nov 2022 13:34:09 +0100 [thread overview]
Message-ID: <Y25BQS3GZkzbz8OL@lpieralisi> (raw)
In-Reply-To: <20220922080647.3489791-7-yoshihiro.shimoda.uh@renesas.com>
On Thu, Sep 22, 2022 at 05:06:43PM +0900, Yoshihiro Shimoda wrote:
> Some PCIe endpoint drivers reset all BARs in each ep_init() ops.
> So, we can reset the BARs into the common code if the flag is set.
Is there a reason why only some drivers do it ? What I am really asking
is whether instead of a flag we could reset them unconditionally in all
drivers.
It would be good to come up with a set of guidelines on kernel
expectations rather than adding them per EP.
Lorenzo
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> drivers/pci/controller/dwc/pcie-designware-ep.c | 10 ++++++++++
> drivers/pci/controller/dwc/pcie-designware.h | 1 +
> 2 files changed, 11 insertions(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
> index 1b7e9e1b8d52..a79482824e74 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> @@ -83,6 +83,14 @@ void dw_pcie_ep_reset_bar(struct dw_pcie *pci, enum pci_barno bar)
> }
> EXPORT_SYMBOL_GPL(dw_pcie_ep_reset_bar);
>
> +static void dw_pcie_ep_reset_all_bars(struct dw_pcie *pci)
> +{
> + enum pci_barno bar;
> +
> + for (bar = BAR_0; bar < PCI_STD_NUM_BARS; bar++)
> + dw_pcie_ep_reset_bar(pci, bar);
> +}
> +
> static u8 __dw_pcie_ep_find_next_cap(struct dw_pcie_ep *ep, u8 func_no,
> u8 cap_ptr, u8 cap)
> {
> @@ -759,6 +767,8 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep)
>
> if (ep->ops->ep_init)
> ep->ops->ep_init(ep);
> + if (ep->reset_all_bars)
> + dw_pcie_ep_reset_all_bars(pci);
>
> ret = pci_epc_mem_init(epc, ep->phys_base, ep->addr_size,
> ep->page_size);
> diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
> index 9ed9621a12e4..0ad9ed77affb 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.h
> +++ b/drivers/pci/controller/dwc/pcie-designware.h
> @@ -353,6 +353,7 @@ struct dw_pcie_ep {
> void __iomem *msi_mem;
> phys_addr_t msi_mem_phys;
> struct pci_epf_bar *epf_bar[PCI_STD_NUM_BARS];
> + bool reset_all_bars;
> };
>
> struct dw_pcie_ops {
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-11-11 12:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 8:06 [PATCH v6 00/10] PCI: rcar-gen4: Add R-Car Gen4 PCIe support Yoshihiro Shimoda
2022-09-22 8:06 ` [PATCH v6 01/10] dt-bindings: PCI: renesas: Add R-Car Gen4 PCIe Host Yoshihiro Shimoda
2022-09-22 8:06 ` [PATCH v6 02/10] dt-bindings: PCI: renesas: Add R-Car Gen4 PCIe Endpoint Yoshihiro Shimoda
2022-09-22 8:06 ` [PATCH v6 03/10] PCI: Add PCI_EXP_LNKCAP_MLW macros Yoshihiro Shimoda
2022-09-22 8:06 ` [PATCH v6 04/10] PCI: designware-ep: Expose dw_pcie_ep_exit() to module Yoshihiro Shimoda
2022-09-22 8:06 ` [PATCH v6 05/10] PCI: designware-ep: Add ep_pre_init() callback to dw_pcie_ep_ops Yoshihiro Shimoda
2022-11-11 12:00 ` Lorenzo Pieralisi
2022-11-14 6:12 ` Yoshihiro Shimoda
2022-11-14 6:19 ` Manivannan Sadhasivam
2022-11-14 6:52 ` Yoshihiro Shimoda
2022-09-22 8:06 ` [PATCH v6 06/10] PCI: dwc: Add reset_all_bars flag Yoshihiro Shimoda
2022-11-11 12:34 ` Lorenzo Pieralisi [this message]
2022-11-14 6:18 ` Yoshihiro Shimoda
2022-09-22 8:06 ` [PATCH v6 07/10] PCI: dwc: Avoid reading a register to detect whether eDMA exists Yoshihiro Shimoda
2022-09-22 8:06 ` [PATCH v6 08/10] PCI: rcar-gen4: Add R-Car Gen4 PCIe Host support Yoshihiro Shimoda
2022-09-22 8:06 ` [PATCH v6 09/10] PCI: rcar-gen4-ep: Add R-Car Gen4 PCIe Endpoint support Yoshihiro Shimoda
2022-09-22 8:06 ` [PATCH v6 10/10] MAINTAINERS: Update PCI DRIVER FOR RENESAS R-CAR for R-Car Gen4 Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y25BQS3GZkzbz8OL@lpieralisi \
--to=lpieralisi@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).