Re: [PATCH 0/2] PCI: mvebu: add support for orion soc

Mauri Sandberg
2022-07-30T13:22:21Z

Hi Bjorn!

On 29.07.22 20:22, Bjorn Helgaas wrote:
> On Mon, Jul 18, 2022 at 11:28:40PM +0300, Mauri Sandberg wrote:
>> Hello all!
>>
>> Working in close co-operation with Pali we made an initial attempt at bringing
>> support for orion PCIe into mvebu PCIe driver. Currently the address of
>> workaround memory range is hard coded and based on compatible string only. As
>> Pali describes in another thread, we were not able to figure out what's the
>> correct way to configure a configuration space. That discussion is here:
>> https://lore.kernel.org/linux-pci/20220710225108.bgedria6igtqpz5l@pali/T/#u
>>
>> I tested this with D-Link DNS-323 rev A1 and it's working. As usual, all
>> comments and feedback is welcome.
>>
>> Thanks,
>> Mauri
>>
>> Mauri Sandberg (2):
>> dt-bindings: PCI: mvebu: Add orion5x compatible
>> PCI: mvebu: add support for orion5x
>>
>> .../devicetree/bindings/pci/mvebu-pci.txt | 1 +
>> arch/arm/mach-orion5x/common.c | 13 ----
>> drivers/pci/controller/Kconfig | 2 +-
>> drivers/pci/controller/pci-mvebu.c | 59 +++++++++++++++++++
>> 4 files changed, 61 insertions(+), 14 deletions(-)
>
> Hi Mauri,
>
> Can you address anything in 2/2 (if necessary), incorporate any acks,
> and post a v2? There was some confusion around the first patch (there
> are two in the thread, likely the same?), and I didn't read the 2/2
> feedback in detail to see if any changes were needed.
>

I give it a little bit time to see if the discussion on how to configure
the configuration space would pick up, but I'll attend to the comments
and post a clean v2 soonish.