Re: [PATCH v3 net-next 1/8] arm64: dts: mediatek: mt7986: add support for RX Wireless Ethernet Dispatch

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2274 bytes --]

> Il 03/11/22 10:28, Lorenzo Bianconi ha scritto:
> > Similar to TX Wireless Ethernet Dispatch, introduce RX Wireless Ethernet
> > Dispatch to offload traffic received by the wlan interface to lan/wan
> > one.
> > 
> > Co-developed-by: Sujuan Chen <sujuan.chen@mediatek.com>
> > Signed-off-by: Sujuan Chen <sujuan.chen@mediatek.com>
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> 
> Hello Lorenzo,

Hi Angelo,

> thanks for the patch! However, there's something to improve...
> 
> > ---
> >   arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 75 +++++++++++++++++++++++
> >   1 file changed, 75 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> > index 72e0d9722e07..b0a593c6020e 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> 
> ..snip..
> 
> > @@ -226,6 +252,12 @@ ethsys: syscon@15000000 {
> >   			 reg = <0 0x15000000 0 0x1000>;
> >   			 #clock-cells = <1>;
> >   			 #reset-cells = <1>;
> > +
> > +			ethsysrst: reset-controller {
> 
> That's not right. It works, yes, but your ethsys rightfully declares #reset-cells,
> because it is supposed to also be a reset controller (even though I don't see any
> reset controller registering action in clk-mt7986-eth.c).
> 
> Please document the ethernet reset in the appropriate dt-bindings header and
> register the reset controller in clk-mt7986-eth.c.
> 
> Finally, you won't need any "ti,syscon-reset" node, and resets will look like
> 
> 	resets = <&ethsys MT7986_ETHSYS_SOMETHING_SWRST>;
> 
> If you need any hint about how to do that, please check clk-mt8195-infra_ao.c.

reviewing the code I think we do not have any mt7986-eth reset line consumer at the
moment, since:
- mtk_eth_soc driver rely on syscon for resetting the chip writing directly in the register
  in ethsys_reset()
- we do not rely on reset api in wed wo code.

I think we can just drop reset support in ethsys/wo-dlm nodes at the moment (since it
is not used in this series) and convert the driver to reset api as soon as
we have proper support in clk-mt7986-eth.c (AFAIU sam will work on it).

Regards,
Lorenzo

> 
> Regards,
> Angelo
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]