Re: [PATCH v5 2/3] arm64: dts: qcom: sa8295p: move common nodes to dtsi

Krzysztof Kozlowski
2022-10-03T13:29:05Z

On 03/10/2022 14:54, Parikshit Pareek wrote:
> There are many ADP boards with lot of common features. Move common
> nodes, like remoteproc, regulators etc. to sa8540p-adp.dtsi file.
> This will be base for many ADP boards to be introduced in near future.
> Common nodes are like clocks, remoteproc, regulators etc.
>
> The differences between the sa8295 ADP board, and sa8540p ADP board
> (Qdrive-3), with respect to device/connector-interface, are as following:
>
> PCIE: pcie nodes are not supported as of now, and will be supported
> in subsequent patches.
>
> UFS: Devices ufs_mem_hc and ufs_card_hc, both are mounted on ADP air
> board. Whereas, only ufs_mem_hc is only mounted on Qdrive-3.
>
> USB: Devices usb0 and usb2 are present on Qdrive-3 board. Whereas on sa8295
> ADP board, usb0, usb1, and usb2 are present. On Qdrive-3, usb2 has only one
> port supported(of the external embedded hub). Whereas on sa8295, all four
> ports of usb2 are supported.
>
> There are different connectors for ethernet and camera, but connected
> to same interface towards soc. So, there is no need of any difference
> regarding device tree.
>
> Artificial intelligence chip SA9000P is present only on Qdrive-3 board
> as PCIE endpoint.
>
> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 528 +++++-------------
> .../{sa8295p-adp.dts => sa8540p-adp.dtsi} | 133 -----
> 2 files changed, 146 insertions(+), 515 deletions(-)
> rewrite arch/arm64/boot/dts/qcom/sa8295p-adp.dts (70%)
> copy arch/arm64/boot/dts/qcom/{sa8295p-adp.dts => sa8540p-adp.dtsi} (72%)
>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof