From: Brian Norris <computersforpeace@gmail.com>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Hendrik Koerner <koerhen@web.de>
Subject: Re: [PATCH] ARM: dts: qcom: ipq8064: disable mmc-ddr-1_8v for sdcc1
Date: Sun, 6 Nov 2022 01:01:55 -0700 [thread overview]
Message-ID: <Y2dp8+2tfi2+nXNL@localhost> (raw)
In-Reply-To: <20221024233817.27410-1-ansuelsmth@gmail.com>
On Tue, Oct 25, 2022 at 01:38:17AM +0200, Christian Marangi wrote:
> It was reported non working mmc with this option enabled.
> Both mmc for ipq8064 are supplied by a fixed 3.3v regulator so mmc can't
> be run at 1.8v.
> Disable it to restore correct functionality of this SoC feature.
>
> Tested-by: Hendrik Koerner <koerhen@web.de>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Perhaps there's some board where this property makes sense, but it seems
like something that should be added when needed in the leaf DTS, and not
supplied in the base DTSI. So:
Reviewed-by: Brian Norris <computersforpeace@gmail.com>
This also fixes problems I've seen on my systems, so:
Tested-by: Brian Norris <computersforpeace@gmail.com>
Thanks!
next prev parent reply other threads:[~2022-11-06 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 23:38 [PATCH] ARM: dts: qcom: ipq8064: disable mmc-ddr-1_8v for sdcc1 Christian Marangi
2022-11-06 8:01 ` Brian Norris [this message]
2022-11-07 3:11 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2dp8+2tfi2+nXNL@localhost \
--to=computersforpeace@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=koerhen@web.de \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).