Re: [RESEND PATCH v3 2/2] phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8

[Vinod Koul <vkoul@kernel.org>]

On 07-11-22, 01:50, Yoshihiro Shimoda wrote:
> Hi Vinod,
> 
> > From: Vinod Koul, Sent: Saturday, November 5, 2022 11:31 PM
> > 
> > On 27-10-22, 22:40, Yoshihiro Shimoda wrote:
> > > Add Renesas Ethernet SERDES driver for R-Car S4-8 (r8a779f0).
> > > The datasheet describes initialization procedure without any information
> > > about registers' name/bits. So, this is all black magic to initialize
> > > the hardware. Especially, all channels should be initialized at once.
> > >
> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > > ---
> > >  drivers/phy/renesas/Kconfig                 |   7 +
> > >  drivers/phy/renesas/Makefile                |   1 +
> > >  drivers/phy/renesas/r8a779f0-ether-serdes.c | 416 ++++++++++++++++++++
> > >  3 files changed, 424 insertions(+)
> > >  create mode 100644 drivers/phy/renesas/r8a779f0-ether-serdes.c
> > >
> > > diff --git a/drivers/phy/renesas/Kconfig b/drivers/phy/renesas/Kconfig
> > > index 111bdcae775c..68f160b0e8ef 100644
> > > --- a/drivers/phy/renesas/Kconfig
> > > +++ b/drivers/phy/renesas/Kconfig
> > > @@ -32,3 +32,10 @@ config PHY_RCAR_GEN3_USB3
> > >  	select GENERIC_PHY
> > >  	help
> > >  	  Support for USB 3.0 PHY found on Renesas R-Car generation 3 SoCs.
> > > +
> > > +config PHY_R8A779F0_ETHERNET_SERDES
> > > +	tristate "Renesas R-Car S4-8 Ethernet SERDES driver"
> > > +	depends on ARCH_RENESAS || COMPILE_TEST
> > > +	select GENERIC_PHY
> > > +	help
> > > +	  Support for Ethernet SERDES found on Renesas R-Car S4-8 SoCs.
> > 
> > Sorted alphabetically please and not at the end
> 
> I intended to sort alphabetically about the prompt strings:
> 
> <snip>
> "Renesas R-Car generation 3 USB 2.0 PHY driver"
> "Renesas R-Car generation 3 USB 3.0 PHY driver"
> "Renesas R-Car S4-8 Ethernet SERDES driver"
> 
> However, IIUC, should we sort alphabetically about the config strings like below?
> 
> config PHY_R8A779F0_ETHERNET_SERDES
> config PHY_RCAR_GEN3_PCIE

We sort them based on config symbol and not the prompt string
-- 
~Vinod