From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CBADC433FE for ; Tue, 22 Nov 2022 20:51:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233369AbiKVUvK (ORCPT ); Tue, 22 Nov 2022 15:51:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234134AbiKVUvJ (ORCPT ); Tue, 22 Nov 2022 15:51:09 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B7B165E9 for ; Tue, 22 Nov 2022 12:51:08 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id e11so13711335wru.8 for ; Tue, 22 Nov 2022 12:51:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Gx+YWWCvKUmbpLOLiEAgZGjZu2bsrwzEPK49+jDiEKo=; b=U56Z6HyNr+8U7X+k5HY107gitq8tL55XN2/davLUBfTrDuUK/wgOuxPbIhRlUiIVpO DYiWZLrzE8vv1RgqzthucM0LGY5AejmXMIFCceBB+xXVc1q8laevMaTjTSQ1K4+yReCk ivjrOu2Q+d1Az+uZFN3rQ3yjeChpiRD0cyV09df3LYnV1bxdwG8wFxGb7KHI+tSJWadR lgWzcabIOJAqvnPLLZRT2k9d2q6BylVfP9uIudIU2iVIgFvIf31udR4aXIRRfUQQ7rIx WX0fNWjMgCRBHI9FVZzxY8czhxUmgYfgFJzZV+XJ4X1WhNO7rTjq1YrZRlcqmNL9dSPM b9Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Gx+YWWCvKUmbpLOLiEAgZGjZu2bsrwzEPK49+jDiEKo=; b=QgV8LXQdR9er7pplQzKXbdH0xi1XkJdBr3d5LRcqmw8kdgSgRV0h/whpeMbpLgZga+ Kpm45lpT/3Zdo8JPGIDtu3ZBOwBnHtIeH6gGpI1ivSmB47V2Eh7aQY0bIrZqHyYA/0Nk pLPmmCkAIl0ePe724/Mv4HrO0EQLAEWqJ2RczU5Mv+2cllANZZFsz8F8Zn4QJzSH7xlt o9qkrRdfkwFa+0Avikj56NjsL5pka0tXWiWcQ9p49fD37VKIzvnRl9yd1MrU/ye1lO+J m/1Z5WauHyV/N72nHiEMiI9E+HFIIJqRcZyt4O92i0wxN6rLV898VfsW42mtCWH++RAe pDIQ== X-Gm-Message-State: ANoB5pk9b9acDnhMKRPLqSjXVMa9IkqdDLdZ37ZfgQJSt46bEtpcX2bZ sjjB6EJggiJwrgXU6GEOHrY0dxEp9CF3sg== X-Google-Smtp-Source: AA0mqf5rPIjXhCXwCsxypSw1YhJ5JSXNE50WJhrKBKNpz+S35+WjBJXucChHKXjjj5trZ8uCMH3gUw== X-Received: by 2002:a5d:6052:0:b0:241:eba1:84fd with SMTP id j18-20020a5d6052000000b00241eba184fdmr168609wrt.696.1669150267102; Tue, 22 Nov 2022 12:51:07 -0800 (PST) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id t1-20020a1c7701000000b003cf4d99fd2asm17606458wmi.6.2022.11.22.12.51.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 12:51:06 -0800 (PST) Date: Tue, 22 Nov 2022 22:51:04 +0200 From: Abel Vesa To: Konrad Dybcio Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Linux Kernel Mailing List , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8550-mtp: Add UFS host controller and PHY node Message-ID: References: <20221116125112.2788318-1-abel.vesa@linaro.org> <20221116125112.2788318-3-abel.vesa@linaro.org> <22a41a8c-9b4a-ecca-ddd2-5e217d00d20c@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22a41a8c-9b4a-ecca-ddd2-5e217d00d20c@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22-11-16 13:56:36, Konrad Dybcio wrote: > > > On 16/11/2022 13:51, Abel Vesa wrote: > > Enable UFS host controller and PHY node on SM8550 MTP board. > > > > Signed-off-by: Abel Vesa > > --- > > arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 22 ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > > index d4c8d5b2497e..fef7793a7dec 100644 > > --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > > +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > > @@ -417,3 +417,25 @@ data-pins { > > &uart7 { > > status = "okay"; > > }; > > + > > +&ufs_mem_hc { > > + status = "okay"; > Status last, please. Yep. Will do. > > > + > > + reset-gpios = <&tlmm 210 GPIO_ACTIVE_LOW>; > > + > > + vcc-supply = <&vreg_l17b_2p5>; > > + vcc-max-microamp = <1300000>; > All these -microamp properties are downstream and do not exist in the > mainline kernel. Remove them. > Actually, ufshcd-qcom complains if they are missing: [ 3.287836] ufshcd-qcom 1d84000.ufshc: ufshcd_populate_vreg: unable to find vcc-max-microamp [ 3.331904] ufshcd-qcom 1d84000.ufshc: ufshcd_populate_vreg: unable to find vccq-max-microamp [ 3.346766] ufshcd-qcom 1d84000.ufshc: ufshcd_populate_vreg: unable to find vccq2-max-microamp > Konrad > > + vccq-supply = <&vreg_l1g_1p2>; > > + vccq-max-microamp = <1200000>; > > + vccq2-supply = <&vreg_l3g_1p2>; > > + vccq2-max-microamp = <100>; > > +}; > > + > > +&ufs_mem_phy { > > + status = "okay"; > > + > > + vdda-phy-supply = <&vreg_l1d_0p88>; > > + vdda-phy-max-microamp = <188000>; These ones from PHY I can drop, since the driver won't complain. > > + vdda-pll-supply = <&vreg_l3e_1p2>; > > + vdda-pll-max-microamp = <18300>; > > +};