From: Matthias Kaehlcke <mka@chromium.org>
To: Owen Yang <ecs.taipeikernel@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Stephen Boyd <swboyd@chromium.org>, Harvey <hunge@google.com>,
Bob Moragues <moragues@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Adding DT binding for zombie
Date: Wed, 23 Nov 2022 14:23:39 +0000 [thread overview]
Message-ID: <Y34s6xRnroQ6fAd2@google.com> (raw)
In-Reply-To: <20221123181043.1.Idfcba5344b7995b44b7fa2e20f1aa4351defeca6@changeid>
On Wed, Nov 23, 2022 at 06:11:12PM +0800, Owen Yang wrote:
> Subject: [PATCH 1/2] dt-bindings: arm: qcom: Adding DT binding for zombie
nit: s/Adding/Add/ besides dropping the redundant 'DT binding for' as
requested by Krzysztof.
Please version your patches. This is v3 if I'm keeping track correctly, so
the next one with the fixed subject should be v4.
> Add an entry in the device tree binding for sc7280-zombie.
>
> Signed-off-by: Owen Yang <ecs.taipeikernel@gmail.com>
> ---
>
> Documentation/devicetree/bindings/arm/qcom.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 463509f0f23a..7ec6240311db 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -655,6 +655,16 @@ properties:
> - const: google,villager-sku512
> - const: qcom,sc7280
>
> + - description: Google Zombie (newest rev)
> + items:
> + - const: google,zombie
> + - const: qcom,sc7280
> +
> + - description: Google Zombie with LTE (newest rev)
> + items:
> + - const: google,zombie-sku512
> + - const: qcom,sc7280
> +
> - items:
> - enum:
> - lenovo,flex-5g
> --
> 2.17.1
>
prev parent reply other threads:[~2022-11-23 14:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 10:11 [PATCH 1/2] dt-bindings: arm: qcom: Adding DT binding for zombie Owen Yang
2022-11-23 10:11 ` [PATCH 2/2] arm64: dts: qcom: sc7280: Add DT for sc7280-herobrine-zombie Owen Yang
2022-11-23 14:39 ` Matthias Kaehlcke
2022-11-23 14:58 ` Krzysztof Kozlowski
2022-11-23 15:16 ` Matthias Kaehlcke
2022-11-23 10:34 ` [PATCH 1/2] dt-bindings: arm: qcom: Adding DT binding for zombie Krzysztof Kozlowski
2022-11-23 14:23 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y34s6xRnroQ6fAd2@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=ecs.taipeikernel@gmail.com \
--cc=hunge@google.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moragues@chromium.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).