From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A95C9C43217 for ; Thu, 24 Nov 2022 13:53:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229630AbiKXNx1 (ORCPT ); Thu, 24 Nov 2022 08:53:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbiKXNx0 (ORCPT ); Thu, 24 Nov 2022 08:53:26 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EC69E0DC0; Thu, 24 Nov 2022 05:53:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1669298004; x=1700834004; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=iJYwQQbsEFPUK7ZmqDMRO9t/URWDUHZSWtb8FdSzfbk=; b=HTTIR1XKt9pHUe/rJ3cb2RBtBXKfnBjA/kXAOepJ/0W232AEzso50Df4 oHn/ozMSXt9tWPLFGfG2DiLbnzjZcKZU6ostqqPUA3H+Bus7Ej3d9Di6R wJBs/ZThv1wckfVls1VONTSOM1/YxvVvlS4xcuRJQlm+evoswluJRO2E0 UFjmRjjNtTjhGXvkjkqsw366kDPeyhWEfdcFuCyuSij1H7P97/SobTfks ArXOZ02fZGe3kORTBctissysJ/CZESXl4n1ElcRhd2nhGkO0t58g+TmDf Om44iujHFOAn/selPhZnuTHQkyWcRY8hqIsHcUIxEizwG3B/hfH43ISOp w==; X-IronPort-AV: E=Sophos;i="5.96,190,1665471600"; d="scan'208";a="188521747" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 24 Nov 2022 06:53:23 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 24 Nov 2022 06:53:18 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Thu, 24 Nov 2022 06:53:16 -0700 Date: Thu, 24 Nov 2022 13:52:58 +0000 From: Conor Dooley To: Heiko =?iso-8859-1?Q?St=FCbner?= CC: , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Jones , Guo Ren , , Subject: Re: [PATCH 2/2] dt-bindings: riscv: fix single letter canonical order Message-ID: References: <20221124130440.306771-1-conor.dooley@microchip.com> <20221124130440.306771-3-conor.dooley@microchip.com> <7034611.lOV4Wx5bFT@diego> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7034611.lOV4Wx5bFT@diego> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Nov 24, 2022 at 02:42:20PM +0100, Heiko Stübner wrote: > Am Donnerstag, 24. November 2022, 14:04:41 CET schrieb Conor Dooley: > > I used the wikipedia table for ordering extensions when updating the > > pattern here in foo. > > ^ foo? :-) God damn it! I wrote foo, left nvim to check what the fixes tag would be, came back and added it below but did not update this part of the commit log... > > Unfortunately that table did not match canonical order, as defined by > > the RISC-V ISA Manual, which defines extension ordering in (what is > > currently) Table 41, "Standard ISA extension names". Fix things up by > > re-sorting v (vector) and adding p (packed-simd) & j (dynamic > > languages). The e (reduced integer) and g (general) extensions are still > > intentionally left out. > > > > Link: https://github.com/riscv/riscv-isa-manual/releases/tag/riscv-unpriv-pdf-from-asciidoc-15112022 # Chapter 29.5 > > Fixes: 299824e68bd0 ("dt-bindings: riscv: add new riscv,isa strings for emulators") > > Signed-off-by: Conor Dooley > > So I have compared the new pattern to the isa manual, > and it looks like the order checks out, so > > Reviewed-by: Heiko Stuebner Thanks!