From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36794C433FE for ; Mon, 14 Nov 2022 12:55:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237508AbiKNMzW (ORCPT ); Mon, 14 Nov 2022 07:55:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237510AbiKNMzV (ORCPT ); Mon, 14 Nov 2022 07:55:21 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 479A42790F; Mon, 14 Nov 2022 04:55:21 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id A8B32CE0FEE; Mon, 14 Nov 2022 12:55:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB4F9C433D6; Mon, 14 Nov 2022 12:55:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668430518; bh=Y9y2PP3dM3aiSA0/EAu5FI2WtvutiNqnsGRh3fAAYKs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JT7GVlQcKaoFspCF0Vi/SNKgAgvJvHP4XchNVWu2eWfohcMUBpjEZhzu6frXmim3T k0+elV1VjXnF5OEaMOfpTp5PbvsXAF7ByKuD5V+6GOGIRboRZA4EUoqq4AjXEPaTZm sS4dKt+/cWk8Y5poG289Z8uuUdLX2KNQy3ye7ht/aJ+u+ekX4rB5jolOtA5MuzvaTy VboHuB1znUQFhL5YXTlCqIuuNr2Ep2ochgjjh5c2IW3g86yeodVM92r4bSW/wHcLlj CxkVlfWEn/8IMia/ZJCwuDVHzIXdfjHb1HwzDj04F1bXPyJZQaKVqJpW03q4Vg3ZXF w52/SsQs8+FaA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1ouYz6-0002SD-TR; Mon, 14 Nov 2022 13:54:45 +0100 Date: Mon, 14 Nov 2022 13:54:44 +0100 From: Johan Hovold To: Dmitry Baryshkov Cc: Johan Hovold , Vinod Koul , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/14] phy: qcom-qmp-combo: rename common-register pointers Message-ID: References: <20221111092457.10546-1-johan+linaro@kernel.org> <20221111092457.10546-13-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Nov 12, 2022 at 02:31:27PM +0300, Dmitry Baryshkov wrote: > On 11/11/2022 12:24, Johan Hovold wrote: > > The common registers are shared by the USB and DP parts of the PHY so > > drop the misleading "dp" prefix from the corresponding pointers. > > > > Note that the "DP" prefix could also be dropped from the corresponding > > defines, but leave that in place for now. > > > > Signed-off-by: Johan Hovold > > --- > > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 24 +++++++++++------------ > > 1 file changed, 12 insertions(+), 12 deletions(-) > > Reviewed-by: Dmitry Baryshkov > > Note regarding the last phrase: I'd suggest leaving the DP prefix in > register names, it makes it easier to visually note & verify the > register block. My point is that "DP" was never part of the COM register block name. The confusion likely comes from the vendor driver naming these defines along the lines of USB3_DP_COM_POWER_DOWN_CTRL Here "USB3_DP" is the common prefix for all defines that apply to both "parts" of the PHY so the corresponding Linux define QPHY_V3_DP_COM_POWER_DOWN_CTRL should either include "USB3" or drop "DP". This becomes more apparent on SC8280XP where the corresponding define is: USB43DP_COM_POWER_DOWN_CTRL Johan