From: Thierry Reding <thierry.reding@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Jon Hunter <jonathanh@nvidia.com>,
Wayne Chang <waynec@nvidia.com>,
mathias.nyman@intel.com, p.zabel@pengutronix.de,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-tegra@vger.kernel.org, singhanc@nvidia.com,
balbi@kernel.org, linux-phy@lists.infradead.org,
vkoul@kernel.org, ajayg@nvidia.com,
heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
treding@nvidia.com, jckuo@nvidia.com,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2 02/13] dt-bindings: usb: Add NVIDIA Tegra234 XUSB host controller binding
Date: Mon, 14 Nov 2022 11:15:30 +0100 [thread overview]
Message-ID: <Y3IVQtY94GenVpGL@orome> (raw)
In-Reply-To: <20221111173236.GA3561612-robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1962 bytes --]
On Fri, Nov 11, 2022 at 11:32:36AM -0600, Rob Herring wrote:
> On Fri, Nov 11, 2022 at 02:38:21PM +0000, Jon Hunter wrote:
> >
> > On 11/11/2022 13:30, Rob Herring wrote:
> > >
> > > On Fri, 11 Nov 2022 18:14:58 +0800, Wayne Chang wrote:
> > > > Add device-tree binding documentation for the XUSB host controller present
> > > > on Tegra234 SoC. This controller supports the USB 3.1 specification.
> > > >
> > > > Signed-off-by: Wayne Chang <waynec@nvidia.com>
> > > > ---
> > > > V1 -> V2: new change for adding nvidia,tegra234-xusb.yaml
> > > > .../bindings/usb/nvidia,tegra234-xusb.yaml | 159 ++++++++++++++++++
> > > > 1 file changed, 159 insertions(+)
> > > > create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.yaml
> > > >
> > >
> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > >
> > > yamllint warnings/errors:
> > >
> > > dtschema/dtc warnings/errors:
> > > Error: Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.example.dts:36.27-28 syntax error
> > > FATAL ERROR: Unable to parse input tree
> > > make[1]: *** [scripts/Makefile.lib:406: Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.example.dtb] Error 1
> > > make[1]: *** Waiting for unfinished jobs....
> > > make: *** [Makefile:1492: dt_binding_check] Error 2
> >
> > This compiles fine on top of -next. We are just missing the change that
> > populates the required definitions.
>
> Where exactly is that mentioned in the commit msg?
>
> No maintainer can take patches which apply against linux-next, so not a
> good dependency to mention either.
It would probably be easiest for me to pick this up into the Tegra tree
since that's where the dt-bindings header file change is that adds these
symbols. Alternatively we could strip the symbols from the example and
use literals instead.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-11-14 10:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 10:14 [PATCH v2 00/13] Enable USB host and device functions on Jetson Wayne Chang
2022-11-11 10:14 ` [PATCH v2 01/13] dt-bindings: usb: tegra-xudc: Add Tegra234 XUSB controller support Wayne Chang
2022-11-11 10:14 ` [PATCH v2 02/13] dt-bindings: usb: Add NVIDIA Tegra234 XUSB host controller binding Wayne Chang
2022-11-11 13:30 ` Rob Herring
2022-11-11 14:38 ` Jon Hunter
2022-11-11 17:32 ` Rob Herring
2022-11-14 10:15 ` Thierry Reding [this message]
2022-11-14 10:57 ` Jon Hunter
2022-11-11 10:14 ` [PATCH v2 03/13] dt-bindings: usb: Add binding for Cypress cypd4226 I2C driver Wayne Chang
2022-11-11 14:36 ` Jon Hunter
2022-11-14 12:01 ` Wayne Chang
2022-11-11 10:15 ` [PATCH v2 04/13] arm64: tegra: Enable XUSB host and device on Jetson AGX Orin Wayne Chang
2022-11-11 10:15 ` [PATCH v2 05/13] usb: typec: ucsi_ccg: Add OF support Wayne Chang
2022-11-11 10:15 ` [PATCH v2 06/13] usb: typec: ucsi_ccg: Add cypress,firmware-build as a well-known regex Wayne Chang
2022-11-11 10:15 ` [PATCH v2 07/13] i2c: nvidia-gpu: " Wayne Chang
2022-11-11 10:15 ` [PATCH v2 08/13] usb: typec: ucsi_ccg: Remove ccgx,firmware-build property Wayne Chang
2022-11-11 10:15 ` [PATCH v2 09/13] i2c: nvidia-gpu: " Wayne Chang
2022-11-11 10:15 ` [PATCH v2 10/13] phy: tegra: xusb: Disable trk clk when not in use Wayne Chang
2022-11-11 10:15 ` [PATCH v2 11/13] phy: tegra: xusb: Add Tegra234 support Wayne Chang
2022-11-11 10:15 ` [PATCH v2 12/13] usb: host: xhci-tegra: Add Tegra234 XHCI support Wayne Chang
2022-11-11 10:15 ` [PATCH v2 13/13] usb: gadget: tegra-xudc: Add Tegra234 support Wayne Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3IVQtY94GenVpGL@orome \
--to=thierry.reding@gmail.com \
--cc=ajayg@nvidia.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=singhanc@nvidia.com \
--cc=treding@nvidia.com \
--cc=vkoul@kernel.org \
--cc=waynec@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).