From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B272FC4332F for ; Mon, 14 Nov 2022 10:16:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236293AbiKNKQn (ORCPT ); Mon, 14 Nov 2022 05:16:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235591AbiKNKQQ (ORCPT ); Mon, 14 Nov 2022 05:16:16 -0500 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EFD91EC65; Mon, 14 Nov 2022 02:15:34 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id k2so27103458ejr.2; Mon, 14 Nov 2022 02:15:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=N7U98HqvMeOnm6Eh8maT1EIBJe9LLM6lCpqSN06lRLY=; b=dFK25eTLa0eWqTq1hV4xDddW+/ZFK5/w/Ztv+doP2F4WDUT3jf8llh8klwE/Y8E2ig RDsdFX6YnKJhYxy7ECgmW03rZwxArQNpNNKkBIkUx4jW7TABIWHEkFtW4MzWUrWpCwRU xK40/VNf4ckptopeDK4FkDVOXX6H1iVuXygjbZzfjSmBY62Etib5peawv+huwDUYt+z4 1/Tw1xEu18Xx29/sH4DyBDHaDfv5nL7eVoDvborW45TDxohlGejZdsgUieNu02XYlCID oxpu5vhxQFUVUsiOX6B9MS6le+KpUOtmG7u0n58uHzHlgaTnJBhbdL/mEjxY0uJDuvkd 53aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N7U98HqvMeOnm6Eh8maT1EIBJe9LLM6lCpqSN06lRLY=; b=LyrQiKN0rn3Vv7sGgiwIimJVEMV0J5nJS2uWYXZa99lDPm5pIeVmrc60R/8BoTaONI lNK/UUvEnk20OYnt3Mri2LZaUYjk2pWwK6Dk4CTGHzRQgJIcLCTrgwzqK1yF2/jCTJDg AHQD3FjzhiXm02DkrDYg/ypSA4Pc/Za0BLCT2jK8rjO1/qu7zHJvG0pdYbJ+57VpQfGs 7/j8K6ecppakS+3HzHnLD6SEJGWqIluKOz7qQJnj7clfo879fxkHHPgb9Q8DJ1hBu7kB TZh/0FMlgR/Fqw+u3ZQoq72vnYQgaX53bSHP/vcq5eC7w3EN5AUp4uVwSshgI+hwJAUr kErA== X-Gm-Message-State: ANoB5pnmGpjB0VmAvKjkZga3XAQ7gkaTBS57pxJISDi+lZ1hFNEPUuul 66+7yfI8/TyVOi/u6mBu3ClJZwx5F/I= X-Google-Smtp-Source: AA0mqf5Zqswe5wI3zWZCj5Gwtm8okjT9rxQpGuiMZDc/XmRpoxHc5/yiMagpgyssM4IcKzqjCFvXXw== X-Received: by 2002:a17:906:c251:b0:7ae:1874:3e09 with SMTP id bl17-20020a170906c25100b007ae18743e09mr9194067ejb.534.1668420933118; Mon, 14 Nov 2022 02:15:33 -0800 (PST) Received: from orome (p200300e41f201d00f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f20:1d00:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id ky14-20020a170907778e00b0078afe360800sm3948522ejc.199.2022.11.14.02.15.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Nov 2022 02:15:31 -0800 (PST) Date: Mon, 14 Nov 2022 11:15:30 +0100 From: Thierry Reding To: Rob Herring Cc: Jon Hunter , Wayne Chang , mathias.nyman@intel.com, p.zabel@pengutronix.de, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-tegra@vger.kernel.org, singhanc@nvidia.com, balbi@kernel.org, linux-phy@lists.infradead.org, vkoul@kernel.org, ajayg@nvidia.com, heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org, treding@nvidia.com, jckuo@nvidia.com, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH v2 02/13] dt-bindings: usb: Add NVIDIA Tegra234 XUSB host controller binding Message-ID: References: <20221111101509.999589-1-waynec@nvidia.com> <20221111101509.999589-3-waynec@nvidia.com> <166817308790.3060162.14990231448404857914.robh@kernel.org> <5782d31a-9a0c-33da-ff84-20cae29f977e@nvidia.com> <20221111173236.GA3561612-robh@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2hyjIjtsn0nH3kf8" Content-Disposition: inline In-Reply-To: <20221111173236.GA3561612-robh@kernel.org> User-Agent: Mutt/2.2.8 (2022-11-05) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --2hyjIjtsn0nH3kf8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 11, 2022 at 11:32:36AM -0600, Rob Herring wrote: > On Fri, Nov 11, 2022 at 02:38:21PM +0000, Jon Hunter wrote: > >=20 > > On 11/11/2022 13:30, Rob Herring wrote: > > >=20 > > > On Fri, 11 Nov 2022 18:14:58 +0800, Wayne Chang wrote: > > > > Add device-tree binding documentation for the XUSB host controller = present > > > > on Tegra234 SoC. This controller supports the USB 3.1 specification. > > > >=20 > > > > Signed-off-by: Wayne Chang > > > > --- > > > > V1 -> V2: new change for adding nvidia,tegra234-xusb.yaml > > > > .../bindings/usb/nvidia,tegra234-xusb.yaml | 159 +++++++++++++= +++++ > > > > 1 file changed, 159 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/usb/nvidia,t= egra234-xusb.yaml > > > >=20 > > >=20 > > > My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_ch= eck' > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > >=20 > > > yamllint warnings/errors: > > >=20 > > > dtschema/dtc warnings/errors: > > > Error: Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.exa= mple.dts:36.27-28 syntax error > > > FATAL ERROR: Unable to parse input tree > > > make[1]: *** [scripts/Makefile.lib:406: Documentation/devicetree/bind= ings/usb/nvidia,tegra234-xusb.example.dtb] Error 1 > > > make[1]: *** Waiting for unfinished jobs.... > > > make: *** [Makefile:1492: dt_binding_check] Error 2 > >=20 > > This compiles fine on top of -next. We are just missing the change that > > populates the required definitions. >=20 > Where exactly is that mentioned in the commit msg? >=20 > No maintainer can take patches which apply against linux-next, so not a= =20 > good dependency to mention either. It would probably be easiest for me to pick this up into the Tegra tree since that's where the dt-bindings header file change is that adds these symbols. Alternatively we could strip the symbols from the example and use literals instead. Thierry --2hyjIjtsn0nH3kf8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmNyFUIACgkQ3SOs138+ s6H1Uw//WLqL8StUoYtObkq8iiJpsfdxOjQvDdyaW0F4virLoWtaqoLEFVpbja40 YjX08K9B0iNoo58bTXGyUrgTKPsrj4GxOFqD13ons2T7NkjDGd+k0MHhoe/5dY02 rshoIdDbqd+ZjQMyrtPCyWgHfgcKeMVd0xmBhJKF7eBUljX6mhZTboCmWTKvFake wWCQQs+5m83Zm5oFOQyu2zcl7Y+127zrofOluMv1l5pRYESmmzndykB5ZTGBmWJm IE3NExzLNoAjRn0v/0fC9yaPi8GCYVDxmuKYZYuYXKGUioesTOHpeu29iEVcfVLI e1+Et89Z+Sot37r4qenXlZmLcXMu29UvC5mrckAGxynu8eB7LgfRUMDoXr+2/teg sOUltlxbzw4wdQsh2sf+aRZZdDtFUlpIZpxkijsHsO1Rhz/q8e4kkOab5VUx6jCe VmEcjSlsiQkYSNzyFilJhx7t14AIqLIcmW0M9086JbcFulyJdojZjov/9iP9xPZa NVVTrlvhskA6ouRJYmtS6bp5/RRfEVMHV+rKjjU+gkWW5mE5gC3uwJWtFR/qDCjq nbPXWgj2OOZJVQovD5ahbziAkHKSPcsx8J2dhNnF15S+/dC0LkHdBzNWbVGRnGk5 bIAhSqcG9BMu2rOmf+L4J5P3dcTSvlOnTnrfgA0RuYby/sbaMDc= =QvgG -----END PGP SIGNATURE----- --2hyjIjtsn0nH3kf8--