From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andrew Davis <afd@ti.com>
Cc: Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: Cleanup DT Overlay intermediate files as appropriate
Date: Tue, 15 Nov 2022 13:43:40 +0200 [thread overview]
Message-ID: <Y3N7bLuSTKJYPcIC@smile.fi.intel.com> (raw)
In-Reply-To: <20221114205939.27994-1-afd@ti.com>
On Mon, Nov 14, 2022 at 02:59:39PM -0600, Andrew Davis wrote:
> %.dtbo.o and %.dtbo.S files are used to build-in DT Overlay. They should
> should not be removed by Make or the kernel will be needlessly rebuilt.
>
> These should be removed by "clean" and ignored by git like other
> intermediate files.
Fixes: 941214a512d8 ("kbuild: Allow DTB overlays to built into .dtbo.S files")
Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reported-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
> .gitignore | 1 +
> Makefile | 4 +++-
> scripts/Makefile.build | 2 ++
> 3 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/.gitignore b/.gitignore
> index 5da004814678d..3ec73ead6757e 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -20,6 +20,7 @@
> *.dtb
> *.dtbo
> *.dtb.S
> +*.dtbo.S
> *.dwo
> *.elf
> *.gcno
> diff --git a/Makefile b/Makefile
> index 3735d5996c637..0dd7e8d022289 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2003,7 +2003,9 @@ clean: $(clean-dirs)
> @find $(or $(KBUILD_EXTMOD), .) $(RCS_FIND_IGNORE) \
> \( -name '*.[aios]' -o -name '*.rsi' -o -name '*.ko' -o -name '.*.cmd' \
> -o -name '*.ko.*' \
> - -o -name '*.dtb' -o -name '*.dtbo' -o -name '*.dtb.S' -o -name '*.dt.yaml' \
> + -o -name '*.dtb' -o -name '*.dtbo' \
> + -o -name '*.dtb.S' -o -name '*.dtbo.S' \
> + -o -name '*.dt.yaml' \
> -o -name '*.dwo' -o -name '*.lst' \
> -o -name '*.su' -o -name '*.mod' -o -name '*.usyms' \
> -o -name '.*.d' -o -name '.*.tmp' -o -name '*.mod.c' \
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 41f3602fc8de7..3ceab076127b7 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -468,10 +468,12 @@ intermediate_targets = $(foreach sfx, $(2), \
> $(filter %$(strip $(1)), $(targets))))
> # %.asn1.o <- %.asn1.[ch] <- %.asn1
> # %.dtb.o <- %.dtb.S <- %.dtb <- %.dts
> +# %.dtbo.o <- %.dtbo.S <- %.dtbo <- %.dtso
> # %.lex.o <- %.lex.c <- %.l
> # %.tab.o <- %.tab.[ch] <- %.y
> targets += $(call intermediate_targets, .asn1.o, .asn1.c .asn1.h) \
> $(call intermediate_targets, .dtb.o, .dtb.S .dtb) \
> + $(call intermediate_targets, .dtbo.o, .dtbo.S .dtbo) \
> $(call intermediate_targets, .lex.o, .lex.c) \
> $(call intermediate_targets, .tab.o, .tab.c .tab.h)
>
> --
> 2.38.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-15 11:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 20:59 [PATCH] kbuild: Cleanup DT Overlay intermediate files as appropriate Andrew Davis
2022-11-15 11:43 ` Andy Shevchenko [this message]
2022-11-15 12:11 ` Masahiro Yamada
2022-11-18 20:46 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3N7bLuSTKJYPcIC@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).