From: Johan Hovold <johan@kernel.org>
To: Parikshit Pareek <quic_ppareek@quicinc.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andrew Halaney <ahalaney@redhat.com>,
Shazad Hussain <quic_shazhuss@quicinc.com>,
Brian Masney <bmasney@redhat.com>
Subject: Re: [PATCH v8 2/2] arm64: dts: qcom: add SA8540P ride(Qdrive-3)
Date: Wed, 16 Nov 2022 09:16:32 +0100 [thread overview]
Message-ID: <Y3ScYKVYIVyj/mG0@hovoldconsulting.com> (raw)
In-Reply-To: <20221116075207.32363-3-quic_ppareek@quicinc.com>
On Wed, Nov 16, 2022 at 01:22:07PM +0530, Parikshit Pareek wrote:
> Introduce the Qualcomm SA8540P ride automotive platform, also known as
> Qdrive-3 development board.
>
> This initial contribution supports SMP, CPUFreq, cluster idle, UFS, RPMh
> regulators, debug UART, PMICs, remoteprocs and USB.
>
> The SA8540P ride contains four PM8450 PMICs. A separate DTSI file has
> been created for PMIC, so that it can be used for future SA8540P based
> boards.
>
> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
> +&ufs_mem_hc {
> + reset-gpios = <&tlmm 228 GPIO_ACTIVE_LOW>;
> +
> + vcc-supply = <&vreg_l17c>;
> + vcc-max-microamp = <800000>;
> + vccq-supply = <&vreg_l6c>;
> + vccq-max-microamp = <900000>;
> +
> + status = "disabled";
> +};
> +
> +&ufs_mem_phy {
> + vdda-phy-supply = <&vreg_l8g>;
> + vdda-pll-supply = <&vreg_l3g>;
> +
> + status = "disabled";
> +};
Why are these disabled? This should be mentioned somewhere (e.g. commit
message and/or comment) or you can drop the nodes until support is in
place.
Johan
next prev parent reply other threads:[~2022-11-16 8:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 7:52 [PATCH v8 0/2] arm64: dts: qcom: add dts for sa8540p-ride board Parikshit Pareek
2022-11-16 7:52 ` [PATCH v8 1/2] dt-bindings: arm: qcom: Document additional sa8540p device Parikshit Pareek
2022-11-16 7:52 ` [PATCH v8 2/2] arm64: dts: qcom: add SA8540P ride(Qdrive-3) Parikshit Pareek
2022-11-16 8:16 ` Johan Hovold [this message]
2022-11-16 9:54 ` Parikshit Pareek
2022-11-16 10:25 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3ScYKVYIVyj/mG0@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_ppareek@quicinc.com \
--cc=quic_shazhuss@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox