From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C99CAC433FE for ; Wed, 16 Nov 2022 09:20:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233346AbiKPJUp (ORCPT ); Wed, 16 Nov 2022 04:20:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233392AbiKPJUm (ORCPT ); Wed, 16 Nov 2022 04:20:42 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3980626127; Wed, 16 Nov 2022 01:20:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1668590441; x=1700126441; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=PBvpl/LIIC4KatBxSf7OTdZHj1uA/ufQHvck22uMENM=; b=pp+TfWhU2y+NWgdhKx3W2JYDDrJjYKZ3o5XKcybHLDZGQ89pHSrveuYn wDqcKvAsofQI4Ha+X667Jj8DWXJY6OaaBDX78mU5KeRb1X69XWKgr9nz5 myboTlvLj6jiIOSlBMpFOEsY4wfLwFkiiZIbD//MyDfSaK0wQGsK4gIjH guIsAdPKjorSQG6lcLRb+aqPMTrd+FUErV5xlg5P2oG+ojrhRxZgFA/wC qd5pxC2d6RPKNdHWw8c8TedpVXTOx05dkkZnMQtz4jyePCRP5kRupYeBJ SogEwuvzYsUYXXgrT8HBtr8z8YREgqzzfczu89Ru00+k0qkS+v1UICsTg A==; X-IronPort-AV: E=Sophos;i="5.96,167,1665471600"; d="scan'208";a="123666759" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 16 Nov 2022 02:20:40 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Wed, 16 Nov 2022 02:20:40 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Wed, 16 Nov 2022 02:20:37 -0700 Date: Wed, 16 Nov 2022 09:20:20 +0000 From: Conor Dooley To: Krzysztof Kozlowski CC: Conor Dooley , Anup Patel , Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Atish Patra , Alistair Francis , Anup Patel , , , Subject: Re: [PATCH 4/9] dt-bindings: Add RISC-V incoming MSI controller bindings Message-ID: References: <20221111044207.1478350-1-apatel@ventanamicro.com> <20221111044207.1478350-5-apatel@ventanamicro.com> <3037b4f9-268d-df03-380c-393a5d01f3ba@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <3037b4f9-268d-df03-380c-393a5d01f3ba@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Nov 16, 2022 at 10:00:27AM +0100, Krzysztof Kozlowski wrote: > On 15/11/2022 23:34, Conor Dooley wrote: > > On Mon, Nov 14, 2022 at 05:59:00PM +0530, Anup Patel wrote: > >> On Sun, Nov 13, 2022 at 8:18 PM Conor Dooley wrote: > > > >>> Also, the file name says "riscv,imsic", the description says "IMSIC" but > >>> you've used "imsics" in the compatible. Is this a typo, or a plural? > >> > >> Yes, the file name should be consistent. I will update the file name. > > > > Is there a reason why the compatible is plural when all of the other > > mentions etc do not have an "s"? It really did look like a typo to me. > > > > It's the "incoming MSI controller", so I am unsure as to where the "s" > > actually even comes from. Why not just use "riscv,imsic"? > > Yep, should be rather consistent with all others, and IMSIC stands for > Integrated Circuit? Incoming Message Signalled Interrupts Controller, no?