From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rahul Tanwar <rtanwar@maxlinear.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"alan@lxorguk.ukuu.org.uk" <alan@lxorguk.ukuu.org.uk>,
"dirk.brandewie@gmail.com" <dirk.brandewie@gmail.com>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"sodaville@linutronix.de" <sodaville@linutronix.de>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
linux-lgm-soc <linux-lgm-soc@maxlinear.com>
Subject: Re: [PATCH v2 1/2] x86/of: Add support for boot time interrupt delivery mode configuration
Date: Wed, 16 Nov 2022 15:34:46 +0200 [thread overview]
Message-ID: <Y3Tm9htYb1fwyRXH@smile.fi.intel.com> (raw)
In-Reply-To: <7efa66ec-8aa7-d44f-fae3-ee4f82d8f157@maxlinear.com>
On Wed, Nov 16, 2022 at 11:25:47AM +0000, Rahul Tanwar wrote:
> On 16/11/2022 6:42 pm, Andy Shevchenko wrote:
> > On Wed, Nov 16, 2022 at 06:28:20PM +0800, Rahul Tanwar wrote:
...
> > Why not pr_notice() in both cases?
>
> Reset of the file uses printk(KERN_xxx ""). In v1, i used pr_notice()
> but on reviewing again found it to be odd one out in the file. So
> switched to printk(KERN_xxx ""). I can revert back to using pr_notice()
> if you think that's a better fit. Thanks.
I don;t know why we should use antique style of printing APIs in new patches.
Even if the old code uses that, you can create a followup that can do two
things:
- uses pr_lvl() instead of printk(KERN_LVL)
- keeps string literals unbroken between the lines (if any
of such breakage exists)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-16 13:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 10:28 [PATCH v2 0/2] x86/of: Fix a bug in x86 arch OF support Rahul Tanwar
2022-11-16 10:28 ` [PATCH v2 1/2] x86/of: Add support for boot time interrupt delivery mode configuration Rahul Tanwar
2022-11-16 10:41 ` Rahul Tanwar
2022-11-16 10:42 ` Andy Shevchenko
2022-11-16 11:25 ` Rahul Tanwar
2022-11-16 13:34 ` Andy Shevchenko [this message]
2022-11-16 11:27 ` Rahul Tanwar
2022-11-16 10:28 ` [PATCH v2 2/2] x86/of: Convert & update Intel's APIC related binding schemas Rahul Tanwar
2022-11-16 10:41 ` Rahul Tanwar
2022-11-16 10:41 ` Andy Shevchenko
2022-11-16 10:52 ` Rahul Tanwar
2022-11-16 13:36 ` Andy Shevchenko
2022-11-16 10:41 ` [PATCH v2 0/2] x86/of: Fix a bug in x86 arch OF support Rahul Tanwar
2022-11-16 13:31 ` Andy Shevchenko
2022-11-16 15:29 ` [PATCH v2 2/2] x86/of: Convert & update Intel's APIC related binding schemas Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3Tm9htYb1fwyRXH@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=devicetree@vger.kernel.org \
--cc=dirk.brandewie@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-lgm-soc@maxlinear.com \
--cc=mingo@redhat.com \
--cc=robh@kernel.org \
--cc=rtanwar@maxlinear.com \
--cc=sodaville@linutronix.de \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox