From: Andrew Lunn <andrew@lunn.ch>
To: Andy Chiu <andy.chiu@sifive.com>
Cc: davem@davemloft.net, kuba@kernel.org, michal.simek@xilinx.com,
radhey.shyam.pandey@xilinx.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
robh+dt@kernel.org, pabeni@redhat.com, edumazet@google.com,
greentime.hu@sifive.com
Subject: Re: [PATCH v5 net-next 3/3] net: axienet: set mdio clock according to bus-frequency
Date: Fri, 18 Nov 2022 01:07:38 +0100 [thread overview]
Message-ID: <Y3bMyjEWk73oabnA@lunn.ch> (raw)
In-Reply-To: <20221117154014.1418834-4-andy.chiu@sifive.com>
On Thu, Nov 17, 2022 at 11:40:14PM +0800, Andy Chiu wrote:
> Some FPGA platforms have 80KHz MDIO bus frequency constraint when
> connecting Ethernet to its on-board external Marvell PHY. Thus, we may
> have to set MDIO clock according to the DT. Otherwise, use the default
> 2.5 MHz, as specified by 802.3, if the entry is not present.
>
> Also, change MAX_MDIO_FREQ to DEFAULT_MDIO_FREQ because we may actually
> set MDIO bus frequency higher than 2.5MHz if undelying devices support
> it. And properly disable the mdio bus clock in error path.
>
> Signed-off-by: Andy Chiu <andy.chiu@sifive.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2022-11-18 0:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 15:40 [PATCH v5 net-next 0/3] net: axienet: Use a DT property to configure frequency of the MDIO bus Andy Chiu
2022-11-17 15:40 ` [PATCH v5 net-next 1/3] net: axienet: Unexport and remove unused mdio functions Andy Chiu
2022-11-17 15:40 ` [PATCH v5 net-next 2/3] dt-bindings: describe the support of "clock-frequency" in mdio Andy Chiu
2022-11-17 15:40 ` [PATCH v5 net-next 3/3] net: axienet: set mdio clock according to bus-frequency Andy Chiu
2022-11-17 15:46 ` Pandey, Radhey Shyam
2022-11-18 0:07 ` Andrew Lunn [this message]
2022-11-21 10:40 ` [PATCH v5 net-next 0/3] net: axienet: Use a DT property to configure frequency of the MDIO bus patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3bMyjEWk73oabnA@lunn.ch \
--to=andrew@lunn.ch \
--cc=andy.chiu@sifive.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=greentime.hu@sifive.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).